From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove process_stratum_target::hostio_last_error abstraction (Re: [PATCH] gdb, gdbserver: remove WinCE support code)
Date: Mon, 12 Apr 2021 19:56:52 -0400 [thread overview]
Message-ID: <3ad38117-d471-3aee-ecde-08af1029154d@polymtl.ca> (raw)
In-Reply-To: <d21c52d1-0cf9-8945-1ed7-266604b40dd3@palves.net>
On 2021-04-12 6:20 p.m., Pedro Alves wrote:> On 12/04/21 16:24, Simon Marchi wrote:
>> On 2021-04-12 11:12 a.m., Simon Marchi via Gdb-patches wrote:
>>> On 2021-04-12 7:42 a.m., Pedro Alves wrote:
>
>>>> We can also get rid of the whole
>>>>
>>>> the_target->hostio_last_error / hostio-errno.cc / hostio_last_error_from_errno
>>>>
>>>> abstraction now.
>>>
>>> Ok, I didn't really know what that was for. I pushed the patch and will
>>> send a follow up for that.
>
>>
>> Well, I spoke too soon, I don't really understand what abstraction you
>> are talking about.
>
>
> This.
>
> From 6a3ffc7e3f65799402078dc9c0721eeb33fc19c9 Mon Sep 17 00:00:00 2001
> From: Pedro Alves <pedro@palves.net>
> Date: Mon, 12 Apr 2021 20:23:54 +0100
> Subject: [PATCH] Remove process_stratum_target::hostio_last_error abstraction
>
> Now that the WinCE port is gone, all ports map host I/O errors from
> errno, so this abstraction is no longer necessary.
>
> Basically undoes:
> https://sourceware.org/pipermail/gdb-patches/2008-January/055246.html
> https://sourceware.org/pipermail/gdb-patches/attachments/20080131/f44e7012/attachment.bin
>
> gdbserver/ChangeLog:
>
> * Makefile.in (SFILES): Remove hostio-errno.cc.
> * configure: Regenerate.
> * configure.ac (GDBSERVER_DEPFILES): No longer add
> $srv_hostio_err_objs.
> * configure.srv (srv_hostio_err_objs): Delete.
> * hostio-errno.cc: Delete.
> * hostio.cc (hostio_error): Inline hostio_last_error_from_errno
> here.
> * hostio.h (hostio_last_error_from_errno): Delete.
> * target.cc (process_stratum_target::hostio_last_error): Delete.
> * target.h (class process_stratum_target) <hostio_last_error>:
> Delete.
OK, I see. Well, that LGTM!
Simon
next prev parent reply other threads:[~2021-04-12 23:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 23:10 [PATCH] gdb, gdbserver: remove WinCE support code Simon Marchi
2021-04-12 11:42 ` Pedro Alves
2021-04-12 15:12 ` Simon Marchi
2021-04-12 15:24 ` Simon Marchi
2021-04-12 22:20 ` [PATCH] Remove process_stratum_target::hostio_last_error abstraction (Re: [PATCH] gdb, gdbserver: remove WinCE support code) Pedro Alves
2021-04-12 22:52 ` Pedro Alves
2021-04-12 23:56 ` Simon Marchi [this message]
2021-04-13 13:12 ` Pedro Alves
2021-04-12 13:57 ` [PATCH] gdb, gdbserver: remove WinCE support code Luis Machado
2021-04-12 14:01 ` Simon Marchi
2021-04-12 14:07 ` Luis Machado
2021-04-13 19:29 ` Tom Tromey
2021-04-13 21:14 ` Pedro Alves
2021-04-13 21:20 ` [pushed] Remove WinCE code from gdbreplay Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ad38117-d471-3aee-ecde-08af1029154d@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).