From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 1BEC3385801D for ; Mon, 12 Apr 2021 23:57:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1BEC3385801D Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13CNuqM2023811 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Apr 2021 19:56:57 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13CNuqM2023811 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id BE7361F0FE; Mon, 12 Apr 2021 19:56:52 -0400 (EDT) Subject: Re: [PATCH] Remove process_stratum_target::hostio_last_error abstraction (Re: [PATCH] gdb, gdbserver: remove WinCE support code) To: Pedro Alves , gdb-patches@sourceware.org References: <20210410231021.1232451-1-simon.marchi@polymtl.ca> <563cec09-990a-77f4-042f-2b95215e9829@palves.net> <1dd71397-369c-b88f-832d-b6c525e5bee8@polymtl.ca> <4e6132b6-acd0-0c9d-fdee-d693784efe13@polymtl.ca> From: Simon Marchi Message-ID: <3ad38117-d471-3aee-ecde-08af1029154d@polymtl.ca> Date: Mon, 12 Apr 2021 19:56:52 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 12 Apr 2021 23:56:52 +0000 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Apr 2021 23:57:04 -0000 On 2021-04-12 6:20 p.m., Pedro Alves wrote:> On 12/04/21 16:24, Simon Marchi wrote: >> On 2021-04-12 11:12 a.m., Simon Marchi via Gdb-patches wrote: >>> On 2021-04-12 7:42 a.m., Pedro Alves wrote: > >>>> We can also get rid of the whole >>>> >>>> the_target->hostio_last_error / hostio-errno.cc / hostio_last_error_from_errno >>>> >>>> abstraction now. >>> >>> Ok, I didn't really know what that was for. I pushed the patch and will >>> send a follow up for that. > >> >> Well, I spoke too soon, I don't really understand what abstraction you >> are talking about. > > > This. > > From 6a3ffc7e3f65799402078dc9c0721eeb33fc19c9 Mon Sep 17 00:00:00 2001 > From: Pedro Alves > Date: Mon, 12 Apr 2021 20:23:54 +0100 > Subject: [PATCH] Remove process_stratum_target::hostio_last_error abstraction > > Now that the WinCE port is gone, all ports map host I/O errors from > errno, so this abstraction is no longer necessary. > > Basically undoes: > https://sourceware.org/pipermail/gdb-patches/2008-January/055246.html > https://sourceware.org/pipermail/gdb-patches/attachments/20080131/f44e7012/attachment.bin > > gdbserver/ChangeLog: > > * Makefile.in (SFILES): Remove hostio-errno.cc. > * configure: Regenerate. > * configure.ac (GDBSERVER_DEPFILES): No longer add > $srv_hostio_err_objs. > * configure.srv (srv_hostio_err_objs): Delete. > * hostio-errno.cc: Delete. > * hostio.cc (hostio_error): Inline hostio_last_error_from_errno > here. > * hostio.h (hostio_last_error_from_errno): Delete. > * target.cc (process_stratum_target::hostio_last_error): Delete. > * target.h (class process_stratum_target) : > Delete. OK, I see. Well, that LGTM! Simon