From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 6B6C5396ECD3 for ; Thu, 26 Nov 2020 15:30:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6B6C5396ECD3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 065651E590; Thu, 26 Nov 2020 10:30:25 -0500 (EST) Subject: Re: [PATCH] gdb: define COFF file offsets with file_ptr To: Jameson Nash , gdb-patches@sourceware.org References: From: Simon Marchi Message-ID: <3ae1bf3c-4804-0acf-c7e3-58c26f03f161@simark.ca> Date: Thu, 26 Nov 2020 10:30:25 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Nov 2020 15:30:27 -0000 On 2020-11-25 2:14 p.m., Jameson Nash via Gdb-patches wrote: > The arguments to these functions are file_ptr, so these declarations > were accidentally implicitly down-casting them to signed int. This > allows for reading files between 2 and 4 GB in size in my testing (I > don't have a larger dll currently to test). These may not be natively > supported by Windows, but can appear when using split-dwarf information. > > This solves a "can't get string table" error resulting from attempting to > pass a negative offset to bfd_seek. I encountered this occuring while > trying to use a debug file for libLLVM.dll, but searching online reveals at > least one other person may have run into a similar problem with Firefox? > https://sourceforge.net/p/mingw-w64/mailman/mingw-w64-public/thread/CA+cU71k2bU0azQxjy4-77ynQj1O+TKmgtaTKe59n7Bjub1y7Tg@mail.gmail.com/ > With this patch, the debug file appears to load successfully and I can see > debug information in gdb for the library. Hi Jameson, Thanks for the patch, I think that makes sense. I am however unable to apply the patch, probably because you sent it using an email client that wrapped lines or something. Can you please send it again but using git-send-email this time? https://sourceware.org/gdb/wiki/ContributionChecklist#Submitting_patches > gdb/ChangeLog: > *gdb/coffread.c: define COFF file offsets with file_ptr to support > files over 2GB For the ChangeLog entry: - Remove the "gdb/" portion of the file name - Start with a capital letter - End with a period. - Wrap at 74 columns Simon