From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by sourceware.org (Postfix) with ESMTPS id E0F2C3856271 for ; Wed, 4 May 2022 12:04:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E0F2C3856271 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f49.google.com with SMTP id 1-20020a05600c248100b00393fbf11a05so3071418wms.3 for ; Wed, 04 May 2022 05:04:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=k7c8O1wEZ8Y+Y+aRfBPiFSUSpfEecSOvexkKHuc7DzQ=; b=530V4L6JIgIt8UH1Q6DPG0K+VFOz7eKNDzDGRWf6iuOnsUEWABEtQvxuomTj7SALDx /JmCQF5+M8QtDNbrSNSHQzwyN03m2h6+anw2C16HmiV5rPqu6PGbgqgq/cFlqANstsuQ 6omUryP4/nCzQiomENj4yTO5AmARkKc8KLCnedgZxZsQBfbQ5WqJJj23o2IQrn103trT 5NK7HC20aBdgwfgkgu/KBmqQV7wqrv9NZ2d+/mgOziboxrsl/SIQLg9glEvXchn8KEF2 k8IiyCDp1Skrz8CyxBxMpvzJCN9GhNGiMLEdZ/+td/NKVpsOwkFICEoKtvXeGK9nR5js eW1w== X-Gm-Message-State: AOAM533QrAuhm6yum157VxEMl3dSqU1v3jwt3zre9V4IJl1qXVs4Fmfd 3jXnyKGDTsREdjRmYHTVXXMyWRW171w= X-Google-Smtp-Source: ABdhPJwMZqgTQXFDOI7VUTrjZlkmU6BhvxkMLbZpWfklrsBF5pLlyEfQF/dCogBwroX3ey9hQr743Q== X-Received: by 2002:a05:600c:12c9:b0:394:54ab:52c5 with SMTP id v9-20020a05600c12c900b0039454ab52c5mr4664762wmd.141.1651665843863; Wed, 04 May 2022 05:04:03 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id e13-20020adf9bcd000000b0020c5253d8basm11621545wrc.6.2022.05.04.05.04.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 May 2022 05:04:02 -0700 (PDT) Message-ID: <3b089300-e2bf-ada5-f5f5-1f4a3d54c3ad@palves.net> Date: Wed, 4 May 2022 13:04:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 1/2] gdb/remote: iterate on pspace inferiors in remote_new_objfile Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20220430032115.524232-1-simon.marchi@polymtl.ca> <20220430032115.524232-2-simon.marchi@polymtl.ca> From: Pedro Alves In-Reply-To: <20220430032115.524232-2-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 12:04:06 -0000 On 2022-04-30 04:21, Simon Marchi via Gdb-patches wrote: > To fix this, make remote_new_objfile iterate on all inferiors bound to > the affected program space. Remove the target_has_execution check from > remote_check_symbols, replace it with an assert. All callers must > ensure that the current inferior has execution before calling it. OK.