From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7853D3858D32 for ; Fri, 25 Aug 2023 19:46:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7853D3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692992814; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9wV4HDbNcrgYbSIIIGRIInH6MdQBmrmlKDjQ24QPgig=; b=D/rAF5SLH1A4MaQlMZkwaNVqIyVfzRkTCH6MfDMVPSPa5tpo2AYsQeZXgPSxlJDHRbbwl2 D50Dbm+Wx3f+1LDGiFCbjT3rLpebk4uP2hZTy9WV7dDegjLCyP8ROXPxfaTcb7KJmBE5qZ fKlxvL0k04TzGbHnyoQAF5TDAgjGVqU= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-690-uQzToDMsM5GhArcf_Gwbow-1; Fri, 25 Aug 2023 15:46:50 -0400 X-MC-Unique: uQzToDMsM5GhArcf_Gwbow-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 24E653C0C4B3; Fri, 25 Aug 2023 19:46:50 +0000 (UTC) Received: from [10.22.32.58] (unknown [10.22.32.58]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DA8B140C2073; Fri, 25 Aug 2023 19:46:49 +0000 (UTC) Message-ID: <3b0896a6-04d4-4c7c-ac32-9ae78acdb66c@redhat.com> Date: Fri, 25 Aug 2023 12:46:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Verify COFF symbol stringtab offset To: Tom Tromey , Keith Seitz via Gdb-patches References: <20230822152335.231921-1-keiths@redhat.com> <877cpnw04v.fsf@tromey.com> From: Keith Seitz In-Reply-To: <877cpnw04v.fsf@tromey.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/22/23 08:46, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz via Gdb-patches writes: > > Keith> Unfortunately, I haven't any idea how else to test this patch since > Keith> COFF is not very common anymore. GCC removed support for it five > Keith> years ago with GCC 8. > > If it is really that dead, then -- like stabs -- I'd like to remove it. > These dead formats just make it harder to improve gdb while not > providing value to any user. > > Actually with the advent of fuzzers, this code now has negative value, > because it wastes time coming up with patches to fix bugs in code no one > uses. I was tempted to suggest either removing it or at least adding a --disable-reader-coff option to disable the code, but I could not convince myself that there wouldn't be relatively widespread disagreement. If you feel there's a chance, let me know if you like either of these approaches, and I will get it on my TODO list. > Hmm, I should probably go reply on the stabs thread. > > Anyway, this is ok. Thank you again for your quick review! Pushed 58abdf88782. Keith