From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id D5DFF385828F for ; Mon, 18 Dec 2023 14:07:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D5DFF385828F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D5DFF385828F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702908425; cv=none; b=XQdqzFLEmtRPu5jz6XJ1Fz1TUsyroNDN82N3sRQ/n3lRgsocF6UOrYX5sQRbxx+gmNjUtLyvgrvbnFNvllSVOBChdK2TCzYhs9ym2JH6NJzPoYBqLAB/p/AgJ86iMkNQUJL5a2C92/t2lvjFQ/fWXRQ6FMifdWxaL3Vx1lJj9SE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702908425; c=relaxed/simple; bh=QIaS3UfF06nz4vz0D7DkB522olaNGH9KunLAZsI/xT8=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=vNz9xEzMMEO8/hMK8BdzdBJ0wtqXs7CDYoe0je6UBEkkdIJAx/5rPVpZRUEAgvJxHsxYOAXXbemssK2T23mKCehMrni+63PSiLgFIWQ8kGnK6YdzaiSs4TyIUjYT9egk9zInbM+2al5RxHU125ib1JIlQeV8B/um0eOUhYEFvcs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 622A021F8C; Mon, 18 Dec 2023 14:07:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702908422; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=955/vwqA74sNcYMp7HNfTiLkfimsBOFU2WzWqxqa4r4=; b=SPvYmFxlUUR5ER+w1gw/omB1npcRMG8eebYaJNgtyb5cmPtxuA/sTjUDv7sstKUsn6lMZx 1ebaNni4yZigUDHrnhk5vnCOyg2V3SPkyco+PSzGoAQxea3q+XN51z8oEKqhEGDYGZXQfL jUFiZKe3UAz+KRTeVrwsUZDvLMeRAQs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702908422; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=955/vwqA74sNcYMp7HNfTiLkfimsBOFU2WzWqxqa4r4=; b=ba710x4UQMUwp+b5sYzrMnDITlk3ecc83PmL+qs/Xmd2aA6C8Y+YbRAes4ySn/St8DJzpM vUpRzvfjiiN5aOCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702908422; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=955/vwqA74sNcYMp7HNfTiLkfimsBOFU2WzWqxqa4r4=; b=SPvYmFxlUUR5ER+w1gw/omB1npcRMG8eebYaJNgtyb5cmPtxuA/sTjUDv7sstKUsn6lMZx 1ebaNni4yZigUDHrnhk5vnCOyg2V3SPkyco+PSzGoAQxea3q+XN51z8oEKqhEGDYGZXQfL jUFiZKe3UAz+KRTeVrwsUZDvLMeRAQs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702908422; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=955/vwqA74sNcYMp7HNfTiLkfimsBOFU2WzWqxqa4r4=; b=ba710x4UQMUwp+b5sYzrMnDITlk3ecc83PmL+qs/Xmd2aA6C8Y+YbRAes4ySn/St8DJzpM vUpRzvfjiiN5aOCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4A16013894; Mon, 18 Dec 2023 14:07:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id MOWiEAZSgGW4ZwAAD6G6ig (envelope-from ); Mon, 18 Dec 2023 14:07:02 +0000 Message-ID: <3b0f76a0-3c69-4ff5-83ec-357aa69435c6@suse.de> Date: Mon, 18 Dec 2023 15:07:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/14] Cleanups for the TUi register window Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20231217-tui-regs-cleanup-v1-0-67bd0ea1e8be@tromey.com> From: Tom de Vries In-Reply-To: <20231217-tui-regs-cleanup-v1-0-67bd0ea1e8be@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: X-Spam-Level: X-Spamd-Result: default: False [-0.10 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-0.01)[49.09%]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] Authentication-Results: smtp-out1.suse.de; none X-Spam-Score: -0.10 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/17/23 20:50, Tom Tromey wrote: > This series is a grab-bag of cleanups to the TUI register window. > > I've tried to untangle the code somewhat, with the goal being removing > the extra rerender overload. > > This series also fixes the 'exit' bug and removes the hacky and > unnecessary recursion flag from tui-hooks.c. > I've applied the series and tested the TUI test-cases, all looks good. I've also confirmed that killing an inferior gets us "no registers available". Tested-By: Tom de Vries Thanks, - Tom > More cleanups here are possible -- the register window is pretty old > code and pretty ugly. In particular: > > * the layout code is still pretty bad > > * it doesn't really make sense for check_register_values to accept a > frame, because the window can only really ever use the selected > frame anyway > > * there's no horizontal scrolling, but for vector registers this might > be nice (there's a bug about this) > > --- > Tom Tromey (14): > Use pop_back in tui_register_format > Minor C++ cleanups in tui-regs.c > Simplify tui_data_window::show_register_group > Rename tui_data_item_window -> tui_register_info > Remove tui_register_info::visible > Move scrollok call in register window > Simplify update_register_data > Remove the TUI register window rerender overload > Simplify tui_data_win::erase_data_content > Remove tui_refreshing_registers > Remove redundant check from tui_refresh_frame_and_register_information > Return void from tui_show_frame_info > Rename show_registers -> set_register_group > Update TUI register window when the inferior exits > > gdb/testsuite/gdb.tui/regs.exp | 8 ++ > gdb/tui/tui-hooks.c | 36 +++---- > gdb/tui/tui-regs.c | 220 +++++++++++++++-------------------------- > gdb/tui/tui-regs.h | 47 +++++---- > gdb/tui/tui-stack.c | 16 ++- > gdb/tui/tui-stack.h | 2 +- > 6 files changed, 137 insertions(+), 192 deletions(-) > --- > base-commit: 2757c1c65fd6ba10c55ba5cf38d600814cf9dc1b > change-id: 20231217-tui-regs-cleanup-36d8f390a65a > > Best regards,