Re: [PATCH 1/2] gdb/testsuite: make gdb_test_multiple return immediately if send_gdb fails

[Simon Marchi <simon.marchi@polymtl.ca>]

On 11/23/22 05:59, Philippe Waroquiers wrote:
> Thanks for this, it will for sure help me in the future to not miss anymore
> some regressions I introduce.
> 
> One small question:
> Is a GDB crash the only reason for which we could have a message such as:
>    Couldn't send python print(objfile.filename) to GDB.
> ?
> Possibly better then to indicate that GDB crashed (on an internal error) ?
> Or if there are some other reasons, it might be good to give more details about the
> reason ?

If send_gdb fails, it's generally because the underlying send (the
expect proc) has failed, because GDB's spawn id is no longer valid.  And
that is normally due to a crash.  But the reality is that we do not know
for sure, it could also be a testsuite problem, where we closed GDB and
failed to reinitialize $gdb_spawn_id.  So saying GDB crashed could also
give you a wrong lead.  I prefer to stick with what we know.

> Note that if this is not straightforward to do, not a big deal
> as just making the problem visible with UNRESOLVED should draw the attention
> and the detailed log will show the crash I guess.

I think that's the important part, it's the previous command that caused
the crash, that one should show up in the logs.  Looking at lib/gdb.exp
there are many more uses of gdb_expect that could be converted to
gdb_test_multiple.

Simon