From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 771F73856DC0 for ; Fri, 21 Oct 2022 18:26:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 771F73856DC0 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 29LIQB19004856 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Oct 2022 14:26:15 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 29LIQB19004856 Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E31401E0D5; Fri, 21 Oct 2022 14:26:10 -0400 (EDT) Message-ID: <3b15cdf1-52f1-9259-1709-936886e13c69@polymtl.ca> Date: Fri, 21 Oct 2022 14:26:10 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 2/2] gdb: make inherit_abstract_dies use vector iterators Content-Language: en-US To: Tom Tromey , Simon Marchi via Gdb-patches References: <20221021132104.1772565-1-simon.marchi@polymtl.ca> <20221021132104.1772565-2-simon.marchi@polymtl.ca> <87fsfhaw8k.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87fsfhaw8k.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 21 Oct 2022 18:26:11 +0000 X-Spam-Status: No, score=-3032.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2022 18:26:19 -0000 On 2022-10-21 14:04, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> Small cleanup to use std::vector iterators rather than raw pointers. > > Looks good. > > I think my previous note about hoisting the loop might be wrong after > all. > > Simon> - if (offsetp >= offsets_end > Simon> - || *offsetp > origin_child_die->sect_off) > Simon> + if (offsets_it == offsets.end () > > ... like I guess this could trigger. That's what I thought. I will push the series, leaving this part as is just to stay on the safe side. Thanks, Simon