From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 11681385841D for ; Fri, 29 Dec 2023 09:27:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 11681385841D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 11681385841D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703842062; cv=none; b=pB2RrgLdS+cViNP4xRXixOSH9RhIqTBZ+xA315WBGRRgH9rW+XgoFOoEtalYDWiGX/ShM5Ju6SPluL40bAfdpFsDFVjaGuzv0Kz8q0A29Q7Is6mA/4s54U7eI/y7tKuI2/+VQhfEyvparDWE9AKLtQGLyWxjVzqI176hg8XNLt0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703842062; c=relaxed/simple; bh=wC+8XjovlvSz40z/SCWSxsnD5N4G/fgjCoDlYpR0bXU=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=BoQD61ynPmg85XHp2S5xfNRa18qkKgsUqmIbRoL0TeC6Iuf1BqJ1aDNusadsBXV2jKvNyo4ywMx5I4sa6+9fCx6NeW563DSeNY+zAztPkAxYUn1hAITU2njfqwncQhR5FbLOQp3oatT9zC5pCXXNsJgRknKYsvEnIZjaix73q08= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703842048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r4KKjf9CHXaRSgLU/TWVSGyM9kF3ixYQtvK9qzuoSzc=; b=UaDhUISkkECERS4pqSs+nYTlGfsOP7NCag9RtAAX+PBrLjSrpYoXlwuAOcd0QcHCFxrHJM TzHuwPcebuCr/f5egD8WKpKGDaBPkLE1ZeeyMcORKtj92dHUNJ7lGE8yDG9UWWbaSxvU2u /5Kp59la7e9C1PQdqHkStjDg0pJGxTw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-378-mKkUlvdlOPi-Oxl7Nj_Q2w-1; Fri, 29 Dec 2023 04:27:27 -0500 X-MC-Unique: mKkUlvdlOPi-Oxl7Nj_Q2w-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40d4a29dca7so51945365e9.0 for ; Fri, 29 Dec 2023 01:27:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703842045; x=1704446845; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r4KKjf9CHXaRSgLU/TWVSGyM9kF3ixYQtvK9qzuoSzc=; b=JRtV6f3PQ769XUk3zWWDKGhBFhgnAojNMNPDbeTUEMu8RHQEq6HNoU+Vqy5d0tqwPT pwA6tyb5lWe1wfweZI8nIWycdvzYEowq2M2MWqrYW42HKdBIni1khxjsQcPBwmftHNl9 JudFnyqSBBVczPWYwgisbjNoIpN9p/Hd8gxmrfU9LTklaI5ZyJg6WULdzvc+EYep/FK2 yMPV/IV+xi8WI7dv+oii9kvG6m/MKbXPntpKn5f0A+8JnK+tC1MeWW32eQlYbwve3JOq K+mojobim+9jD75FTrgzzCgjs3xygyx+0WGsLRHiNn2Azq3aMthM+pHTJUDC4sQzAUqu yUkw== X-Gm-Message-State: AOJu0Yzj6T7Tz6PRthXiAslUXVJI/pnBJdTRMWNmwNQ1VKSM+6zJMJvE 5Tul7AZn6TmNkD+7g97bhSK18jDkYOmhrFup+mdOyiPGAd6GVOcG2lJu/w2HfcbSQAyCSQpNFIe 4frtQiqXuPR08VJD3/HnfTg8w6ArQyN62NZpItRMKITT9WudC5Swpob12AZcKW7SfYGleteHNE7 wKQZihwpTfMi3Vkw== X-Received: by 2002:a05:600c:138a:b0:40d:64a7:b550 with SMTP id u10-20020a05600c138a00b0040d64a7b550mr1320419wmf.60.1703842045486; Fri, 29 Dec 2023 01:27:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IHBvslzHzd2DY7rUKb3J8ylrY5/C3rAwPM7D4ctf7pHa+p5GX8cLXTsc9kubxuo11YPw6N7mw== X-Received: by 2002:a05:600c:138a:b0:40d:64a7:b550 with SMTP id u10-20020a05600c138a00b0040d64a7b550mr1320413wmf.60.1703842045218; Fri, 29 Dec 2023 01:27:25 -0800 (PST) Received: from localhost ([2a00:23c7:c696:e701:85a5:8a0c:1403:2dc]) by smtp.gmail.com with ESMTPSA id q11-20020a05600c46cb00b0040d2d33312csm30224068wmo.2.2023.12.29.01.27.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Dec 2023 01:27:24 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv8 08/14] gdb: remove tracepoint_probe_create_sals_from_location_spec Date: Fri, 29 Dec 2023 09:27:03 +0000 Message-Id: <3b214d40b896abeaffe4e2fa9fd2b15fdc99176e.1703841366.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The tracepoint_probe_create_sals_from_location_spec function just forwards all its arguments to bkpt_probe_create_sals_from_location_spec, and is only used in one place. Lets delete tracepoint_probe_create_sals_from_location_spec and replace it with bkpt_probe_create_sals_from_location_spec. There should be no user visible changes after this commit. --- gdb/breakpoint.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 69c55c833f4..232186888ae 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -283,9 +283,6 @@ static bool strace_marker_p (struct breakpoint *b); static void bkpt_probe_create_sals_from_location_spec (location_spec *locspec, struct linespec_result *canonical); -static void tracepoint_probe_create_sals_from_location_spec - (location_spec *locspec, - struct linespec_result *canonical); const struct breakpoint_ops code_breakpoint_ops = { @@ -300,10 +297,11 @@ static const struct breakpoint_ops bkpt_probe_breakpoint_ops = create_breakpoints_sal, }; -/* Tracepoints set on probes. */ +/* Tracepoints set on probes. We use the same methods as for breakpoints + on probes. */ static const struct breakpoint_ops tracepoint_probe_breakpoint_ops = { - tracepoint_probe_create_sals_from_location_spec, + bkpt_probe_create_sals_from_location_spec, create_breakpoints_sal, }; @@ -12411,17 +12409,6 @@ tracepoint::print_recreate (struct ui_file *fp) const gdb_printf (fp, " passcount %d\n", pass_count); } -/* Virtual table for tracepoints on static probes. */ - -static void -tracepoint_probe_create_sals_from_location_spec - (location_spec *locspec, - struct linespec_result *canonical) -{ - /* We use the same method for breakpoint on probes. */ - bkpt_probe_create_sals_from_location_spec (locspec, canonical); -} - void dprintf_breakpoint::re_set () { -- 2.25.4