From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>,
Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] [gdb/symtab] Handle self-reference in inherit_abstract_dies
Date: Mon, 4 Sep 2023 13:47:08 +0200 [thread overview]
Message-ID: <3b3216d6-dd6f-fbb5-3060-fa7e1c0b6c3b@suse.de> (raw)
In-Reply-To: <875y4zuuiw.fsf@tromey.com>
On 8/28/23 16:11, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Tom> Building gdb with gcc 7.5.0 and -flto -O2 -flto-partition=one generates a
> Tom> self-referencing DIE:
> Tom> ...
> Tom> <2><91dace>: Abbrev Number: 405 (DW_TAG_label)
> Tom> <91dad0> DW_AT_abstract_origin: <0x91dace>
> Tom> ...
>
> Tom> When encountering the self-reference DIE in inherit_abstract_dies we loop
> Tom> following the abstract origin, effectively hanging gdb.
>
> Tom> Fix this by handling self-referencing DIEs in the loop in
> Tom> inherit_abstract_dies.
>
> I wonder if these have ever happened from compiler bugs, or only from
> hand-made tests.
>
> Anyway, seems fine. If we're ever worried about chains of inheritance
> that form loops, we can do some kind of tortoise/hare thing.
FTR, filed as https://sourceware.org/bugzilla/show_bug.cgi?id=30822 .
Thanks,
- Tom
prev parent reply other threads:[~2023-09-04 11:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 6:36 Tom de Vries
2023-08-28 14:11 ` Tom Tromey
2023-08-28 14:32 ` Tom de Vries
2023-09-04 11:47 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b3216d6-dd6f-fbb5-3060-fa7e1c0b6c3b@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).