From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 154A73858D33 for ; Fri, 26 Jan 2024 16:34:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 154A73858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 154A73858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706286898; cv=none; b=QqJ7NDPzGg2HJa+Uk689SCiPPwEuAJAXEYwIUW3vyNJoZPEOHcNQhAxJyBd2LKE32Z1KzhI/HrXo8+pnCnOVM/9kkQ2vKgq1xwUSlE2ArB9Oe/CzsxawZMUJ8pJHNYEiNq4APlOM4vCWQLKG0277z71bKqwAUMnqP+e0icEtoto= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706286898; c=relaxed/simple; bh=brbXzuAlxE4/jE3wNj2fCPESzL+zw/XXBL3hSmBw6SA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=n+U0jOHYccjOMUtHPLL4nXq/HrMQSm/opg04r4P5U05Gjr1T2Ty/0hiLyYKl5UzPb3jOz+ZMjN47uLqgE7FuIdcwkYCye3ke2kFKBXvrRt+uRR4SOOVB1aB8lp2mnM5zuLFc0hiXClrKyBJH5EkyqtZV6AGfn+MbKwvDEyx6l4s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706286895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bVz2l+9zpYO89q324FGzANANL4/EjqwW6FnVCXKSa3g=; b=SujhlQaE1pjLdhG0H06wvC0137E1v8EE4aaLRbprYit4r84eqEb6c8RuqCZuYTEDKJ36Uy gY/Z56zTnDPrzUJZ2l30hkbBtIhthcKsDPBD27luKkL2HjmanAZOMiNxD/2x3M7+SNYZMh gZ8VD/Ds14a/IyaWD/wJO38MPbbec5I= Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-280-fl2wQX5cO3-pEPD8trHtCg-1; Fri, 26 Jan 2024 11:34:54 -0500 X-MC-Unique: fl2wQX5cO3-pEPD8trHtCg-1 Received: by mail-oo1-f71.google.com with SMTP id 006d021491bc7-598c21f698fso617489eaf.2 for ; Fri, 26 Jan 2024 08:34:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706286892; x=1706891692; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bVz2l+9zpYO89q324FGzANANL4/EjqwW6FnVCXKSa3g=; b=CBstnRp8ivWCulqvGXwQPn8CtY46HAVVbQMTFz9szrsSBzN7/Xok8wD9dAT8clICsK /evN9/SCZMgnnCTupBLzWthjbihnjXQgfemyXVHpUrgr7h4Z8D9lQfow9cgRe0dkbOKM TcwAnLchTGYXVFNWnv8DN7IfUQEZ4/7sMna10g+hD8QqsSNX0FxliDnMszSp/1dhVE3a 1+adldRiSnevrtiY1qkjTM5xIKvSNttL1DDcoctmOvR75J6JXfjZhbQ+ZgPp/CKyto5u rZuT/ruyMogokw7Oy/POVX/2WrJZZ3EzZV2aRvQDWAl9U25X1X5qBueIz0Lg2poOvaHP VIIw== X-Gm-Message-State: AOJu0Yy/lEg6zJSqAukv3b924deQDVEmEN3ekuh441Avvl6+E47NMxec F27p0VlVTWzpGhEj31UqbPKqebTfd5gx6YAblDTJ/G9oG7BalHlrMsTp9O6s7t5dT2EetX49O1n XO549AAnGPdX22J6cx2MFieR5kvOu2s7wlQ8ONtf3zoSTvUJ3PKx8vGdv3qERboUwcFA= X-Received: by 2002:a05:6358:3421:b0:176:ca53:39e1 with SMTP id h33-20020a056358342100b00176ca5339e1mr1056034rwd.28.1706286892455; Fri, 26 Jan 2024 08:34:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IFrDprEv8V9l0p1wHxQ9aEW5gLP6VHltbjMPPimhjbsTWBWPSkpvCehQHFo1VZd7ChA+9F24w== X-Received: by 2002:a05:6358:3421:b0:176:ca53:39e1 with SMTP id h33-20020a056358342100b00176ca5339e1mr1056024rwd.28.1706286892196; Fri, 26 Jan 2024 08:34:52 -0800 (PST) Received: from [150.1.200.12] (174-21-92-140.tukw.qwest.net. [174.21.92.140]) by smtp.gmail.com with ESMTPSA id b185-20020a6334c2000000b0059d6f5196fasm1264248pga.78.2024.01.26.08.34.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jan 2024 08:34:51 -0800 (PST) Message-ID: <3ba8d70a-62d1-4594-9912-7f14fc197304@redhat.com> Date: Fri, 26 Jan 2024 08:34:51 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] gdb/s390: Add packed-stack support to the backchain unwinder To: Ilya Leoshkevich Cc: gdb-patches@sourceware.org References: <20231128223702.869501-1-iii@linux.ibm.com> From: Keith Seitz In-Reply-To: <20231128223702.869501-1-iii@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Thank you for your patience. It comes sometimes be a very lengthy process to get patches accepted. Since I've already "granted" (???) my Reviewed-by, this is effectively just a "ping" for you. On 11/28/23 14:36, Ilya Leoshkevich wrote: > Regtested on s390x-redhat-linux. Ok for master? > > > > v1: https://sourceware.org/pipermail/gdb-patches/2023-October/203562.html > https://sourceware.org/pipermail/gdb-patches/2023-November/204230.html > > Move variable declarations closer to their first usages, add a test > (Keith). > > Ignore the return value of the 2nd try_backchain() call, it does > not cause any warnings, since try_backchain() is not marked with > __attribute__ ((__warn_unused_result__)). Furthermore, the logic > does not require any special actions if it fails. I've retested this internally and reviewed the revision, and everything looks okay. I hope a global or area maintainer will be able to help push this forward. forward. Keith