From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130053.outbound.protection.outlook.com [40.107.13.53]) by sourceware.org (Postfix) with ESMTPS id B958A3858D35 for ; Fri, 11 Nov 2022 12:48:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B958A3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Ccr/HLN6xAo7ZmEx5iEVk4OHENfpaDMTGS2ABf7z1vqWUASyu8LwAChI5pEybEl2rbf6AbdKNx+5Kq+vgmLizvt0oPDDkI2A7ij0Ms0ad7aPVjqRo/9FzHVTRGJmVDh6IBARFbzidMOQBRiqtCk7orDDKJzPomQ7IDXZaMPUpXoKtJxBachDy9TtXWv2ikRFwUafHEv6y1ghT8Cj5fc0xWXG1T9ZkPsLMEiyFUxQ5dQnpek61zphCNLRrhA0RatFHATuDXPxMU5Fh1ZuAOTZt+B+2DOEFdTpljuxNo+NgULB8Uz7AgRHovm2s0wS36yq++sN2Jpf09/30tuL+Xf30A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yHiexGQ6JIlzJsEt+beFjpWawd2Mfp17egnUH/ltYzc=; b=MGHjO/L36oe+cZN28YoOoZluZyfW6mJ5lZ3uhqx8DnIX1/BtnqExBydFIa0ZFt4f6nlXg/U+1PZ9qluYQeWmRQ2mSSG0ehb+7BBuevIgjbOFBmc+8yIo4UuuqSvjewvcthmUb2lNZUmUXl1mfFa2gO36d3gk9kBTIUjxbrRP/tgq5DLfT1PRofRYLmWPqpoPepcZ5yHPR9gDtYb5q1OmqJhGfVVzHXH/kzC+rS0XuDtzxPgcVwd1wIpQCt9j5ew1Xw+nSxglWzthWP4SY9fkN2ABygohw8b/tjdx4qMiomweYmnqlqN9y1IoBCjXoiNOjt3TsHvH9+yIqAOhmDAvWw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yHiexGQ6JIlzJsEt+beFjpWawd2Mfp17egnUH/ltYzc=; b=w8I5qSAHH8+CuFZ4OgoMBcStCRxKt7Ra6VnKWB0OfrUrtYwXgTVO0dGj/gArfHyNyS1/5BnuYHjyWz62dw0s6Cq4oQO24A610r3TN0C8S68U7tCGqykyaFSCfKIyCrc8rg/mLNZ3nyPZjTOWcJ4f72/3Z7PWac5C48WepU67aMc= Received: from DU2PR04CA0043.eurprd04.prod.outlook.com (2603:10a6:10:234::18) by PAVPR08MB9115.eurprd08.prod.outlook.com (2603:10a6:102:32a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 12:48:22 +0000 Received: from DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:234:cafe::3b) by DU2PR04CA0043.outlook.office365.com (2603:10a6:10:234::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Fri, 11 Nov 2022 12:48:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT023.mail.protection.outlook.com (100.127.142.253) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 12:48:22 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Fri, 11 Nov 2022 12:48:22 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 0792dcfb1c60419e X-CR-MTA-TID: 64aa7808 Received: from 408e8775e47e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E08824EC-DFB7-4EE0-A243-CEFBB056E89D.1; Fri, 11 Nov 2022 12:48:14 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 408e8775e47e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Nov 2022 12:48:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PMWqNSndS5cv0sLPP26R4U424RDr8R3VMiRV4cdNmCTTGkisOS2/Nb8ybcJmHRcjO7HUSlw5vY7BNd2nVr5pf4asmTHJX5likACXhbz+Mly0exB9wrOCjOlX/NLEKT79YdyYOZ1mwR1j92pCPtjsLH/CmFu2XQX/Q2KklBIRaNPa5Fg/7QAip0D5aLkdwfD1KUWU+PI6Inj9pPp8cLsEri9u+hObUYLLof2sSHWn5WKuFU5tHv8zUIr6JmVznVDDdODSQHxAWhCR/cLlYaWbrwZs56Jb/WaCJqk9ry38VmbR2wUTdj1a5mMI5wVfSjsFlFmA/A18+6DZSWCogrU3pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yHiexGQ6JIlzJsEt+beFjpWawd2Mfp17egnUH/ltYzc=; b=U8vKbGivvLXcx3dolcYZ4+howe4C10OoQ3kyucV5zBK/86pkfm2o7M312VowvpERBg7nwP671Y4499RaAlfb9apLra1YFctMrZY1DXbNonxUcJXzMy7TosvaLF/bi1+hhchW+4xz/vVSQEXsq5r3w6NJhlJoMPP/Vg00E1GSRkHAwxUyZjMGauVZFSVQCkhnROwD1dA9GcC+NR2j+GRhzP01tFvQ3ECnDWbGvc1ju9UOUMqSgyoTB8xPQiJh3fWG2YOLGd1PQ9SyvShW8enOy7Jief1QiQowdmeBwAh8fG/IC1e96rYwhQcMqjXP0HBsDq99C5aiFw1q2NCfndUMLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yHiexGQ6JIlzJsEt+beFjpWawd2Mfp17egnUH/ltYzc=; b=w8I5qSAHH8+CuFZ4OgoMBcStCRxKt7Ra6VnKWB0OfrUrtYwXgTVO0dGj/gArfHyNyS1/5BnuYHjyWz62dw0s6Cq4oQO24A610r3TN0C8S68U7tCGqykyaFSCfKIyCrc8rg/mLNZ3nyPZjTOWcJ4f72/3Z7PWac5C48WepU67aMc= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS4PR08MB7602.eurprd08.prod.outlook.com (2603:10a6:20b:4cc::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 12:48:13 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::f9e6:599b:e673:801]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::f9e6:599b:e673:801%5]) with mapi id 15.20.5813.013; Fri, 11 Nov 2022 12:48:13 +0000 Message-ID: <3ba96f06-ad48-15fe-c85e-81a577b257d9@arm.com> Date: Fri, 11 Nov 2022 12:48:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH,v3] [PR gdb/29272] Make sure a copy_insn_closure is available when we have a match in copy_insn_closure_by_addr Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20221026084100.28009-1-luis.machado@arm.com> <20221111093201.747609-1-luis.machado@arm.com> From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA9PR03CA0028.namprd03.prod.outlook.com (2603:10b6:806:20::33) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS4PR08MB7602:EE_|DBAEUR03FT023:EE_|PAVPR08MB9115:EE_ X-MS-Office365-Filtering-Correlation-Id: 3c371f38-5d65-41b3-6659-08dac3e30425 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8FTnDrY1QwbTIZ4LfE+JpJATVWicJSQUrOMFhdAtZoP65paHJXVYpthpTd50zMGkkL+MZ2KJXxrbbe/783ehGKNVZRzW4HaDxr7Qrj+NLxI0gB2rN7Ang20xI+12Qo4R9zia6Gt8cvbNJCaIeYH9EMKO32jpkKLo6fWStVUNoZMsN7Uki/jSpvIHA3j9wWFqlXY0JMIk/WmAb7Z5VPfdOWMzlqiB2B9LFMD9wX8PzvL4sf/MQaM9q7S/WSyXyK9kK3Uw6KSSQUzp+G+zMCQmKcwKZPTdr65jLrITh3LOulW38sz35WqyaAJ6QksVkofG2+eU2a6kJ/dLr8eX5aQAZBxkLoy47E2OOn+chZS/YAX8RyPN3+2wE/uAxzzUSNmnuSTDePponklIz6ZouuABFmPrq7SYfDIaD6M2ACy7gWv2toEgJ3Gu3nFTPUcfAxHgDF1wiXR9nruepEyF5zPx4CStdGgBhNNIOavgR0S+OQQJdfSprsa2KPMNjIp5nzlD25exe3fway/s1jL2BzwVVjD3yzBJMz1ZNnH7YPFPGAiBfmLXXtLyJs1fH4lB1MYpDnS613wvkBAmWtkB/jiW8sEZOG4qaCU3+viPBx4abC80z8y195RbPR2GSOgFmPVPo+QYVJbUeJIw/Q18DHOeT9OKrTqiVOKWrE3kiqoz0x/gYjMBLZW83M9JJgidDEMik4Jzw9LoGQCf7bl02UFLSRz8kPPteyLeHpD2wCqTkdUGZSseFq9N6ZvCpIyPbMMQKvh2WNrbnaXCcoxwMZVnPDlu2ZAmZKEphzNp1hDlSQ/1IvuoMPpoj3HPZiee41kj X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(136003)(366004)(346002)(39860400002)(451199015)(478600001)(316002)(66476007)(66946007)(8936002)(6512007)(36756003)(66556008)(8676002)(41300700001)(53546011)(44832011)(2616005)(6506007)(5660300002)(26005)(186003)(83380400001)(31686004)(86362001)(38100700002)(966005)(31696002)(6666004)(6486002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7602 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c9ea5589-1b69-4165-6061-08dac3e2fedf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SU/qgiiFz1xw5A7hZXiTNoTplO2BCrytVY8O79YZ82PDPO6srsiYWHcVzxzS9njw6HuxL1+IhHpwSCp8R8IDHplMtcikTFsJH1GmWzrF68Kj2W8p7BZt/5yp5sRF+Q85nOe4kyNESMOglqGf9NeRpR1XGYEaxSlUdFFd0tx/izBQkg8353huUOqVTHjOhMbRoq9Dhms+zS5GbDZbV8t7fpsSI43j6DpNzikVhLIJcHV2ptSMhfYYTTwTHCQ0hcCDx/RzMjcDq73fU++mKUb7/D9yzhXCOXusTczdywNuR1nZPMwVh7Epc7ZMxHqE8paASJ2PuSCWXdJ5QKxVGtW5f0pl9+TL5UUS/YAno9TM4/LetPPdAKIc88ChP2hfPE5uO0B2Lo+tqQC3HZQ/Wi4ZMUQQyxglabECDpQL3BiokTcJpR99e7jbO51h0RNJ0dGJSPyz/D28HIru5ciZoRTQd9k+NC9UxEvD7Rs6T2zjZLAQjEMLRIvEFtrZGP4WIjVo7lyJef10PqzY3iJNH563Y8hglRl+lqaadzxRfa99TSJzbzQFVYhGY60PC6FstEna76CIdjnZjsZeLehzmbzXeFzWKtcg08QZ6GNtNOoO2af5/F642MyWbpAgt3QtBUZpM+yWiykaGTLXJ88BSM0dWYVjDbdJtKYy99slhGdsu2EKhIZuqdpp2fycfPwaDJKi0pRsVwe55wP7ndeHIt3wkDHzGEnvJxGeXx7JB4AtkmfjVfgbhbBnlEItWu+zk3BpEyacUXXmGy8nGDVp036fjQKmP05/FZptouPIcYxXIvJ7OFODlgEP9Zy38Qgtoc36Uz5NFL92TwA7qr5KJKcEBw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(136003)(346002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(44832011)(83380400001)(336012)(86362001)(70206006)(81166007)(31696002)(6512007)(356005)(26005)(2906002)(6506007)(186003)(36756003)(36860700001)(2616005)(40480700001)(5660300002)(6666004)(41300700001)(40460700003)(8936002)(70586007)(47076005)(316002)(53546011)(82740400003)(31686004)(82310400005)(8676002)(478600001)(6486002)(966005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 12:48:22.0898 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c371f38-5d65-41b3-6659-08dac3e30425 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9115 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/11/22 12:39, Simon Marchi wrote: > On 11/11/22 04:32, Luis Machado wrote: >> v2: Add try/catch block >> v3: Let it throw after all, and make the rollback cleaner. >> >> PR gdb/29272 >> >> Investigating PR29272, it was mentioned a particular test used to work on >> GDB 10, but it started failing with GDB 11 onwards. I tracked it down to >> some displaced stepping improvements on commit >> 187b041e2514827b9d86190ed2471c4c7a352874. >> >> In particular, one of the corner cases using copy_insn_closure_by_addr got >> silently broken. It is hard to spot because it doesn't have any good tests >> for it, and the situation is quite specific to the Arm target. >> >> Essentially, the change from the displaced stepping improvements made it so >> we could still invoke copy_insn_closure_by_addr correctly to return the >> pointer to a copy_insn_closure, but it always returned nullptr due to >> the order of the statements in displaced_step_buffer::prepare. >> >> The way it is now, we first write the address of the displaced step buffer >> to PC and then save the copy_insn_closure pointer. >> >> The problem is that writing to PC for the Arm target requires figuring >> out if the new PC is thumb mode or not. >> >> With no copy_insn_closure data, the logic to determine the thumb mode >> during displaced stepping doesn't work, and gives random results that >> are difficult to track (SIGILL, SIGSEGV etc). >> >> Fix this by reordering the PC write in displaced_step_buffer::prepare >> and, for safety, add an assertion to >> displaced_step_buffer::copy_insn_closure_by_addr so GDB stops right >> when it sees this invalid situation. If this gets broken again in the >> future, it will be easier to spot. >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29272 > > LGTM, thanks: > > Approved-By: Simon Marchi > > Simon Thanks. Pushed now.