From: Simon Marchi <simon.marchi@ericsson.com>
To: "Maciej W. Rozycki" <macro@mips.com>,
Simon Marchi <simon.marchi@polymtl.ca>,
<gdb-patches@sourceware.org>, <binutils@sourceware.org>
Cc: Joel Brobecker <brobecker@adacore.com>,
Fredrik Noring <noring@nocrew.org>
Subject: Re: [PATCH v4] GDB PR tdep/8282: MIPS: Wire in `set disassembler-options'
Date: Thu, 21 Jun 2018 17:52:00 -0000 [thread overview]
Message-ID: <3bd95a5f-e43e-2efe-e261-c2cf30d06d14@ericsson.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1806210753000.20622@tp.orcam.me.uk>
Hi Maciej,
This patch looks good from the GDB side (with one nit in the test below), but
somebody from binutils would need to review the bits in opcodes/include.
> Index: binutils/gdb/testsuite/gdb.arch/mips-disassembler-options.exp
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ binutils/gdb/testsuite/gdb.arch/mips-disassembler-options.exp 2018-06-20 15:58:24.888391112 +0100
> @@ -0,0 +1,58 @@
> +# Copyright 2018 Free Software Foundation, Inc.
> +
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program. If not, see <http://www.gnu.org/licenses/>.
> +
> +# Test MIPS disassembler options.
> +
> +if { ![istarget "mips*-*-*"] } then {
> + verbose "Skipping MIPS disassembler option tests."
> + return
> +}
> +
> +standard_testfile .s
> +set objfile [standard_output_file ${testfile}.o]
> +
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${objfile}" object {}] \
> + != "" } {
> + return
> +}
> +
> +clean_restart ${objfile}
> +
> +proc mips_disassemble_test { func insn mesg } {
> + gdb_test "disassemble $func" \
> + "Dump of assembler code for function\
> + $func:\r\n\[^:\]+:\t$insn\r\nEnd of assembler dump\." \
> + $mesg
> +}
> +
> +# Verify defaults.
> +mips_disassemble_test foo "move\tv0,v1" "disassemble default"
> +
> +# Verify option overrides.
> +gdb_test "set disassembler-options gpr-names=numeric"
> +mips_disassemble_test foo "move\t\\\$2,\\\$3" "disassemble numeric (gpr-names)"
> +# Check multiple options too.
> +gdb_test "set disassembler-options msa,reg-names=numeric,reg-names=r3000"
> +mips_disassemble_test foo "move\t\\\$2,\\\$3" "disassemble numeric (reg-names)"
> +
> +# Verify ABI overrides.
> +mips_disassemble_test bar "move\t\\\$2,\\\$8" "disassemble ABI (numeric)"
> +gdb_test "set disassembler-options"
> +gdb_test "set mips abi o32"
> +mips_disassemble_test bar "move\tv0,t0" "disassemble ABI (o32)"
> +gdb_test "set mips abi n32"
> +mips_disassemble_test bar "move\tv0,a4" "disassemble ABI (n32)"
> +gdb_test "set mips abi n64"
> +mips_disassemble_test bar "move\tv0,a4" "disassemble ABI (n64)"
Avoid parenthesis at the end of test names:
https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Do_not_use_.22tail_parentheses.22_on_test_messages
Simon
next prev parent reply other threads:[~2018-06-21 17:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 7:27 Maciej W. Rozycki
2018-06-21 17:52 ` Simon Marchi [this message]
2018-06-21 18:29 ` Maciej W. Rozycki
2018-06-21 19:19 ` Simon Marchi
2018-06-21 19:56 ` Maciej W. Rozycki
2018-06-21 20:06 ` Simon Marchi
2018-06-29 14:37 ` [PING][PATCH " Maciej W. Rozycki
2018-06-29 14:41 ` Maciej W. Rozycki
2018-07-02 15:57 ` Nick Clifton
2018-07-02 23:01 ` [committed v5] " Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bd95a5f-e43e-2efe-e261-c2cf30d06d14@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=binutils@sourceware.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@mips.com \
--cc=noring@nocrew.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).