From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-133644-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 99119 invoked by alias); 4 Oct 2016 18:06:25 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 99060 invoked by uid 89); 4 Oct 2016 18:06:25 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Oct 2016 18:06:23 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id C3FB632B0C4;	Tue,  4 Oct 2016 18:06:22 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u94I6LsH001356;	Tue, 4 Oct 2016 14:06:22 -0400
Subject: Re: [RFC/RFA] Add support for the --readnever command-line option (DWARF only)
To: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
References: <1467838463-15786-1-git-send-email-brobecker@adacore.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <3c15cb99-9a10-379a-ab80-0dc3ebc4f541@redhat.com>
Date: Tue, 04 Oct 2016 18:06:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1467838463-15786-1-git-send-email-brobecker@adacore.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-10/txt/msg00055.txt.bz2

On 07/06/2016 09:54 PM, Joel Brobecker wrote:

>  #include <fcntl.h>
>  #include <sys/types.h>
> @@ -2062,6 +2063,9 @@ int
>  dwarf2_has_info (struct objfile *objfile,
>                   const struct dwarf2_debug_sections *names)
>  {
> +  if (readnever_symbol_files)
> +    return 0;

Guess that means '--readnever --readnow' is the same as
--readnever in practice?


> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> +    untested "Couldn't compile ${srcfile}"
> +    return -1
> +}

Maybe use build_executable.

> +set saved_gdbflags $GDBFLAGS
> +set GDBFLAGS "$GDBFLAGS --readnever"
> +clean_restart ${binfile}
> +set GDBFLAGS $saved_gdbflags

Nowadays we have save_vars:

save_vars { GDBFLAGS } {
  append GDBFLAGS " --readnever"
  clean_restart ${binfile}
}

Thanks,
Pedro Alves