From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 99150385842E for ; Tue, 22 Mar 2022 03:27:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 99150385842E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.130.0.135] (unknown [113.200.148.30]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9Axasw3QjliZsANAA--.12859S3; Tue, 22 Mar 2022 11:27:52 +0800 (CST) Subject: Re: [PATCH v4 2/4] gdb: testsuite: add new gdb_attach to check "attach" command To: Simon Marchi , gdb-patches@sourceware.org References: <1647655887-13964-1-git-send-email-yangtiezhu@loongson.cn> <1647655887-13964-3-git-send-email-yangtiezhu@loongson.cn> <54270fdb-4067-4be9-7621-e12f2d2e2361@polymtl.ca> Cc: Pedro Alves From: Tiezhu Yang Message-ID: <3c7bcc78-ead1-7237-d642-c9e7dcc597d5@loongson.cn> Date: Tue, 22 Mar 2022 11:27:51 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <54270fdb-4067-4be9-7621-e12f2d2e2361@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID: AQAAf9Axasw3QjliZsANAA--.12859S3 X-Coremail-Antispam: 1UD129KBjvJXoW7uF47KFy3GF4DJF43GrWDXFb_yoW8GF18pa 1jqF1FkFykXr12g3W3t345Xr9ayrsYyry5C34xAw1Y9rs0gr10gry8Kw4j9r93XrZFv3W3 Aa10qF13ur1DCFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUv2b7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I 8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI 64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8Jw Am72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG8wCY 02Avz4vE14v_Gr4l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxV Aqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1Y 6r17MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6x kF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2jsIE 14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa 7IU5NJ57UUUUU== X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2022 03:28:02 -0000 On 03/21/2022 11:00 PM, Simon Marchi wrote: > On 2022-03-18 22:11, Tiezhu Yang wrote: >> This commit adds new gdb_attach to centralize the failure checking of >> "attach" command. Return 0 if attach failed, otherwise return 1. >> >> Signed-off-by: Tiezhu Yang >> --- >> gdb/testsuite/lib/gdb.exp | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp >> index 89dcd0a..149a1c3 100644 >> --- a/gdb/testsuite/lib/gdb.exp >> +++ b/gdb/testsuite/lib/gdb.exp >> @@ -5111,6 +5111,30 @@ proc can_spawn_for_attach { } { >> return 1 >> } >> >> +# Centralize the failure checking of "attach" command. >> +# Return 0 if attach failed, otherwise return 1. >> + >> +proc gdb_attach { testpid args } { >> + parse_args { >> + {pattern ""} >> + } >> + >> + if { [llength $args] != 0 } { >> + error "Unexpected arguments: $args" >> + } >> + >> + gdb_test_multiple "attach $testpid" "attach" { >> + -re -wrap "Attaching to.*ptrace: Operation not permitted\\." { >> + unsupported "$gdb_test_name (Operation not permitted)" >> + return 0 >> + } >> + -re -wrap "$pattern" { >> + pass $gdb_test_name >> + return 1 >> + } >> + } >> +} > > I guess we need a "return 0" at the end of the function, in case the test does fail? > > Simon > OK, let me do it and then I will send v5 soon. Thanks, Tiezhu