From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 49CDB3858D1E; Sat, 12 Aug 2023 00:47:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 49CDB3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4RN27R6BkCz3W72; Sat, 12 Aug 2023 00:47:31 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RN27R5DL2z4R1n; Sat, 12 Aug 2023 00:47:31 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691801251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WCMyop0QdtMco/NwHhnpNthmDiZdNTUCM+/MshqVuJQ=; b=krCX0l0idqYjFRGXka5SIL+X9rx0X2gH22bY9jvvOSQcmjcnq5XM3bdBUIO2fPKeT4W5p6 qXUl7Yuk2NrGhPDhxrZrz+2JpcmnrnoRRvuG1PecVueL9ZHpb/u5kMiOZCtvIQ2Vu1PKMW KBOjCDBTv0i8kCegx5gfArxk6exGPkjJcO4+W2I7ARl5RrjmX9vahW/iYvWxuKifzr/7j4 D5zckjqwm2zG8NmSdJt3dWsVjuBTwRtu2acbncXiEg5FQzTFEO+vXR1Aqpu52K2PifaiSx APOSLVnWxtrpJmqOFQffOPFbUnvTRnCz1U4KYW4DRPYJBAhAG/Gsg3OveYePNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691801251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WCMyop0QdtMco/NwHhnpNthmDiZdNTUCM+/MshqVuJQ=; b=CJlTW26iadHxK+7LpotJCw9pNH3lm30V3WE2Vs75kEol5tAwaVEcvo45peS4aTiFSttBpr EosISJZYBypqOSSn6q4h6NnuBa+cfMyqNhrZ+0t87lDbIkJ9QK3B+Lyav/ZgCuuz7LlYVy GnWAu80SGHW7LqVNlltAVxX1/QoxjFZ/rvavEWNLzGLuxk4OqSXxsjI3qlNd6/djZVH69e k9NlxC8fXoeBJGv0okg4+AYNvZtxp8AMH3lUoWoYhxBkuI7sHIHFTmQX2x0NUPcyjjztkj QkVfolloBSUCszTLuazC9s0FlW3qyU2NbdQVa2GML9EvCy2UJeu/dMcZmHsX1Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1691801251; a=rsa-sha256; cv=none; b=OmePdckZ7TkTTrLjQQVoc40pYQHbNEJsPGQTn5lKXijay57VZN6+aF5SBwSkJwje7jswy7 Hct9Pi1v6WXvLqEOy3fIOctrt8PHj5LkskD7McW3QOSs+VUpWxYOrZcugduCaSnSNJ8ZwU IqlwT9Z5MnJuyAkN3Y5w514EV4oEs5U/GjVm0gaClVsUsMwOD6MuyhWuGstzsqpuxodC/e vDKnc6EUGATuv76/tvVsDH0p3xD1m7vx/yU11v1Kc7SJnceLkpb/k4rgOP+bsvvxbQsspK I0oiuVtFt0lGwM4My285O2XGar44HQaqKcxniDslAfEVELwifSF74LkqP0CPsA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2601:648:8683:a9e0:ed9b:265f:978a:2ee8] (unknown [IPv6:2601:648:8683:a9e0:ed9b:265f:978a:2ee8]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RN27Q758vz1CPV; Sat, 12 Aug 2023 00:47:30 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <3c7ed690-2ab5-a71f-6302-8ba94ba39525@FreeBSD.org> Date: Fri, 11 Aug 2023 17:47:29 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 2/2] Propagate NT_RISCV_VECTOR from Linux kernel headers to binutils. The value is identical to pre-existing NT_RISCV_CSR but the note names different (NT_RISCV_CSR is "GDB" and NT_RISCV_VECTOR is "CORE") Content-Language: en-US To: Palmer Dabbelt , Andrew Burgess Cc: gdb-patches@sourceware.org, binutils@sourceware.org, greentime.hu@sifive.com, greg.savin@sifive.com References: From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/11/23 9:43 AM, Palmer Dabbelt wrote: > On Fri, 11 Aug 2023 05:51:45 PDT (-0700), Andrew Burgess wrote: >> Greg Savin via Gdb-patches writes: >> >>> --- >>> include/elf/common.h | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/include/elf/common.h b/include/elf/common.h >>> index e7eede23a07..d28f5c6ccf5 100644 >>> --- a/include/elf/common.h >>> +++ b/include/elf/common.h >>> @@ -715,6 +715,8 @@ >>> /* note name must be "CORE". */ >>> #define NT_RISCV_CSR 0x900 /* RISC-V Control and Status Registers */ >>> /* note name must be "GDB". */ >>> +#define NT_RISCV_VECTOR 0x900 /* RISC-V Vector Registers */ >>> + /* note name must be "CORE". */ >> >> I'm not a binutils maintainer, but do have an interest from the >> RISC-V/GDB side. >> >> Given the comments you made in an earlier mail, I guess we're going to >> have to restructure some of the core file support in order to handle >> NT_RISCV_CSR and NT_RISCV_VECTOR having the same values. But that >> should be doable. >> >> No objections to this patch from me. > > NT_RISCV_VECTOR isn't in a releasted kernel, so it's not a stable uABI > yet. So there's still time to change it. 0I've got a revert on the > kernel lists, it'd mean we miss 6.5 but we'd just end up in 6.6 which > isn't so bad. While it is possible to handle colliding NT_RISCV_* values, it will probably be simpler all-around if you are able to make NT_RISCV_VECTOR be 0x901 since you are going to revert and redo. -- John Baldwin