From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2088.outbound.protection.outlook.com [40.107.20.88]) by sourceware.org (Postfix) with ESMTPS id 571C23858D38 for ; Fri, 14 Oct 2022 17:13:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 571C23858D38 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=UOxPIGVYm+OgLmn3jYYYb6G60r/F87FO4mtKaHUKK4vz955RQss/sMPuPMrIns51w1tnj5eH+aw6b7sDFgOZqk18R/JI+/dAE4B1w6zS2CSlMssjGfpnKeGsr1gTLFDwtFMGhA2rkMS2c0wJiexUQkXcrcZrE0GzcEGzwk8bEEdLztk8kaGpcmLTHupTg26dwQhQFn8c/ci5pGuQiYeVljo345DbvLmk4Y5lCQrRfe7mZy9h8VSrLKHWumhOE/IrNU0QCEQ6cp4Gvr60CX9izSmwrNN67zFrLLs0QknzBJARPUh+rtpkDy2vRSo8+V4+ouqmpzLlcfSogy5nGwrbhw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vrmjxRv4SQjvLQiznhidlgIB3uodSXA+WtANptjjiY8=; b=i/qJSK8DWoHjnSvsv0yu7PtL6t0/yQifF7vTQsbhw+Fm1jPtKQpJ09bTnnzXkLmF+ZHs3gGrR1uS7grynQNY5WP2dYCFn7hCGuZphLirzCIc2hgKl8StIkAmxGGRgaVLbS/nl/dennZiKO7RM++2Gr8CKqZAE5SSK1tJil9U2ImXyknTRBgIMxPE4c9SB68ckJY6m5MY51oZXzs7vRGktc/nlxAguBvHl2OSwSnjUlhMAB0jZtoSxWgsvE/cDXOWsI/VmDLbMZTXCovtmUVs1svcAEyGULa0/EoCAABRu5khx1BICnAX1aQaL5VQdEbrCWeco0r2F+4XRQUZ0vPT9A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AS9PR01CA0019.eurprd01.prod.exchangelabs.com (2603:10a6:20b:540::21) by PA4PR08MB7460.eurprd08.prod.outlook.com (2603:10a6:102:2a7::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct 2022 17:13:47 +0000 Received: from AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:540:cafe::cb) by AS9PR01CA0019.outlook.office365.com (2603:10a6:20b:540::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend Transport; Fri, 14 Oct 2022 17:13:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT031.mail.protection.outlook.com (100.127.140.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.10 via Frontend Transport; Fri, 14 Oct 2022 17:13:46 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Fri, 14 Oct 2022 17:13:46 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2610c7065f6893b1 X-CR-MTA-TID: 64aa7808 Received: from 2e3585250d2a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 88B8A54C-F986-4722-B3FA-2CF38BA734DF.1; Fri, 14 Oct 2022 17:13:39 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2e3585250d2a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 14 Oct 2022 17:13:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oCAlXpqordttI/vkP8QW2LsWxUX+dpG36rqrpLyVgXKlz4qCz2pumrvmOm4D8hzWFedWZEiLh4u6VTK2PlVhUaepy6iCsU3NDcOqL+kuEQ+C0Bscf5n1jsktOtNjmGQnwPRRXmJKH30YbPLIgP5kVQc83iTs4WjbYXLRGMiWyheJeMXd44Ryi67nHZ4Xjw+090ircMNsX6ram5xIFpewh0EZKVzX4rTPEBZrMwaNlUuGDh0eLi9CgymQ+/eBcYS1sTF7PGhmqIuPppFIihigVQdlhmNgquoxXkY/IPZTPes97tdYoL4IkSRNClwtDIPtOauMxE37p+uEq5htrhSugQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vrmjxRv4SQjvLQiznhidlgIB3uodSXA+WtANptjjiY8=; b=GvQEXHVFXugvWCPMV1RurgBgmIYiFOFX0fbgFYkmbtgOa+35hdaiEKYjOBLAUJ2YRQah1z1RCZwmDbxj4BTz6Huxly22d1gQ8bkeqnnl9qUT7jceJpY5tx+mDn29Xn8DU2Ms3SfPt7nsGl+qm60JpXbK+rcgMSwvV3mrOHRaDuNQtWG42XIlWUrsM9MMkw/dnwOekhEBz8MQWPtF7UtfgBcHmHjgcWOGckQssSb9v4ho2KkvEGJUHm/RFJZPiEwIJ1Y2RjTZZkIeAIBNsDY7M4uMSmxnHfHRrdIFNA4Dy5PWIbUVCv5xWGHAKsIUCzTaR4/4ONpETsYWZmFkzo2tlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DB3PR08MB8843.eurprd08.prod.outlook.com (2603:10a6:10:438::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct 2022 17:13:37 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::bbeb:a49e:d969:5d2]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::bbeb:a49e:d969:5d2%6]) with mapi id 15.20.5709.021; Fri, 14 Oct 2022 17:13:37 +0000 Message-ID: <3c83c771-bdc5-8d05-dd32-01a11420cf1e@arm.com> Date: Fri, 14 Oct 2022 18:13:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] gdb/arm: Don't rely on loop detection to stop unwind Content-Language: en-US To: =?UTF-8?Q?Torbj=c3=b6rn_SVENSSON?= , gdb-patches@sourceware.org Cc: pedro@palves.net References: <20221014134559.721433-1-torbjorn.svensson@foss.st.com> From: Luis Machado In-Reply-To: <20221014134559.721433-1-torbjorn.svensson@foss.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0522.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::8) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|DB3PR08MB8843:EE_|AM7EUR03FT031:EE_|PA4PR08MB7460:EE_ X-MS-Office365-Filtering-Correlation-Id: 7807b5a4-2d73-4f6d-b116-08daae077487 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9dcHwKYJlK2BBJD0CcRWI/W5Q1nTlOJuxKbykdun6z7uq6P+irAuKBCdkfGbihWdWHFzvDnrEnYn7o1omotYF5U7TzyWAvp6TYLF2laG9WAH0mMUOz8aO+MMsENN23/hlDqQWCT/Gj8XZlwf7l7yMbaOdOMOA/SOXFY2kT344Q5L+x0w9ZrRPTwS30b/gc3e4g6XbHU2YFsxaS0zACsEOTyR4TB0J+jCBWZQbL4UzpKXZ90U2NlYX+tLE7xCMdBYJXS/Af5USOcEynozdtVdpKFBKQvtxpN53H5OXPvh2kGe2EPohQdpdm1GfnEtoYJjUhyRa3cRndTVK8bxKiU1bvGpDor5CRmEiqlwe4MsnBM5yvf1f+GdqrcD7zX5koxA8c3uLkSlvoltSdMgsjElwjeBX7RVVMdxhWFz+7b3SjL/PzMIHNhIVWGyJTxJ5HGcxmhfyoe12xfbhddLin2Km6jPFZLJ82ReLl502lcttOlIZaAtjDfVelFdSPgfsjdKXfR+jI7ICEguNjOgBw9E0axTWsvbyfKqmNEH3EVtXQ8nEAhde6kWo1Co4nVAWcIPMLuzEsL+YdkLHRomTYIuxp6WEGgo4zU5Vt6EV5X7+CSyEokNDszmfCSYhRO0JXbj9r0p2sN7EhsMMgLOjdAoC9/O3G1hbvKJPuYp/PL5K7AEFFZ2TOCo/ItW7V5ICi7PAp1bOu2rKdUx6WfCzUL83QQXa8j9XuFpTtFcIl4bFPFYQm6Tld2wYB2q3asU7FTaGvKuvSS0KX8sOFexwT7BilV8RviXMkc+R6rG+KDOHj0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(376002)(346002)(39860400002)(396003)(136003)(451199015)(31686004)(41300700001)(83380400001)(66574015)(8936002)(66476007)(31696002)(8676002)(66946007)(66556008)(86362001)(186003)(2616005)(36756003)(26005)(53546011)(6512007)(4326008)(2906002)(316002)(44832011)(6486002)(6666004)(6506007)(5660300002)(38100700002)(478600001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB8843 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c170418f-1823-41a1-0c8d-08daae076e93 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8PuLUDRyp+hiH77Vj8ux1JIjevPPhiuyJbQJ89UDAdOLVlPGlYDz6jihHlIzF0LY2PDzWKNsI2jmrKJYP3mTdhuE3sitl3hvLCAIW2+c3gj0SoMfUcSxzSIzqB0eIMQWLtF17hMNN91EreJgmKMYG8OE91sNgbd0DuWO/qRSdaHkFN818bqTwdH5i+jVEBpMG4rHvTpaPyPB3ByB3Jdzvr1Oo5VmxfptPmtKNZfy7b6Gw+K/JFIgBnekfNr9ADh4B+G+/NhHLTGktOMwKLRC3NQUgzqBl7t2Y/NiSyhrJ/M1uLHDmLZo82bMnYbmai81yQ2F0/JLFmTqixL6TyXcwWKsSL1fr0N+4bIKJeeheUVg57qU1rUGrm5xCXz7qHGQ7PUgQZVHMk+weLeYKQRwiGrL5Dr92gKYsN3/3Kc15xEZelUvOWZnGr3mmV9EVgMxHvYG1u+O2XOyEQEBd5cpfTjl8zVIfQYXqZIZgu8xRpHeWE4e6IFAuz1TeHA7OGV+g0rAkj/piLQXcrwRJapz0iAv6ciAa3mP0WtB4MxqTMAB0a8KiHZyOjyquEwu0mDyMwuSrI2YLfTFMDMDUiBbUWcsGuw1O971oyPcsCGczOq9ACXigKXgfIHJksasjjlwN4v3gDr7NTAalXJWpVW3ssUTuP9mNMz4eKcaN9445+YfbB8LphvkbGmY7zqEJkIsIO/g/MsbMtTQRV125oBPPbFoGuHBaBo+IxvjqM5A/QRJUZvORsDr83pSHYEi14PwrgyYzXtE2B+RwU6BGITaupT8IZvmbrtayYjX0uVWXyPiaNtXfPnITH9HHDmzwqcg X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(136003)(396003)(376002)(346002)(451199015)(40470700004)(46966006)(36840700001)(6506007)(336012)(5660300002)(186003)(44832011)(2906002)(2616005)(53546011)(41300700001)(6512007)(8936002)(26005)(356005)(82740400003)(82310400005)(40480700001)(86362001)(31696002)(40460700003)(36756003)(81166007)(83380400001)(66574015)(47076005)(36860700001)(316002)(478600001)(31686004)(6486002)(107886003)(6666004)(70206006)(70586007)(8676002)(4326008)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 17:13:46.8775 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7807b5a4-2d73-4f6d-b116-08daae077487 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7460 X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2022 17:14:07 -0000 On 10/14/22 14:46, Torbjörn SVENSSON wrote: > Setting SP of the next frame to the same address as the current frame > is an ugly way to stop the unwind. A cleaner way is to rely on the stop the unwind -> stop the unwinding. > frame_unwind_stop_reason function to return UNWIND_OUTERMOST. > > Signed-off-by: Torbjörn SVENSSON > --- > gdb/arm-tdep.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index fa6b08e4a54..b5facae8a5e 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -3356,7 +3356,6 @@ arm_m_exception_cache (frame_info_ptr this_frame) > to the exception and if FPU is used (causing extended stack frame). */ > > CORE_ADDR lr = get_frame_register_unsigned (this_frame, ARM_LR_REGNUM); > - CORE_ADDR sp = get_frame_register_unsigned (this_frame, ARM_SP_REGNUM); > > /* ARMv7-M Architecture Reference "A2.3.1 Arm core registers" > states that LR is set to 0xffffffff on reset. ARMv8-M Architecture > @@ -3364,8 +3363,8 @@ arm_m_exception_cache (frame_info_ptr this_frame) > reset if Main Extension is implemented, otherwise the value is unknown. */ > if (lr == 0xffffffff) > { > - /* Terminate any further stack unwinding by referring to self. */ > - arm_cache_set_active_sp_value (cache, tdep, sp); > + /* Terminate any further stack unwinding. */ > + arm_cache_set_active_sp_value (cache, tdep, 0); > return cache; > } > > @@ -3387,8 +3386,8 @@ arm_m_exception_cache (frame_info_ptr this_frame) > { > warning (_("Non-secure to secure stack unwinding disabled.")); > > - /* Terminate any further stack unwinding by referring to self. */ > - arm_cache_set_active_sp_value (cache, tdep, sp); > + /* Terminate any further stack unwinding. */ > + arm_cache_set_active_sp_value (cache, tdep, 0); > return cache; > } > > @@ -3452,8 +3451,8 @@ arm_m_exception_cache (frame_info_ptr this_frame) > { > warning (_("Non-secure to secure stack unwinding disabled.")); > > - /* Terminate any further stack unwinding by referring to self. */ > - arm_cache_set_active_sp_value (cache, tdep, sp); > + /* Terminate any further stack unwinding. */ > + arm_cache_set_active_sp_value (cache, tdep, 0); > return cache; > } > LGTM. Thanks.