From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 1389B386192A for ; Mon, 13 Nov 2023 07:14:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1389B386192A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1389B386192A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.220.28 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699859655; cv=none; b=mOcxTJtXg0ZbogxtBaohGVoiZBDinFmFp8d0815LMNMtEkREo9AWcL0ueEOPb3gP0RzoRboinx8DU6vyp58b9ovllmwVoq1kso88R+YIrgDAzoZxR2RbA0Go7LdwgzPn5OmK1j6/4Bb7rcme8zcHp8O57iGkyqGwYJbMwrdMrYg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699859655; c=relaxed/simple; bh=96pXE3E9TqcVaTRgLyAo2s+44WXVv19/YHxS0Rjt4+U=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=WP/QWeXZTuQfdj/OlpI5cOoHgLbGOtB7MFlKjz4jy/PKOI0FEHBBw/PWqxibqdxxCyNNwdETQ7LEDPlcdSVqi1sWsb5VsMre80wK2gVy/QCmstCJs9xPj9EUSWklq2F+8dBiFwwFGG92SYlGdb4oIbD0MKTaQslwlYl6MRzImfY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4190E2188F; Mon, 13 Nov 2023 07:14:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1699859653; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rp4OEJpMFLMotJT3QRRl8VyXwP3XNywBBkcTtgC7aUc=; b=08pj9S0UULZihoTGq7JNOX5qNRqjYxBr2IL98xUZnlTsND2z3rT15miaOg5cRbNQN9OgeK B4CaZz+Z4ENoW6QTTcImboK4RDFgHXXWhNYQiY0bwWk5U+5IH+TzIqcqGOrhPSTKbghf3+ 6o7r1+jnEko68hs1awrFKdZL6ZCTvxo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1699859653; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rp4OEJpMFLMotJT3QRRl8VyXwP3XNywBBkcTtgC7aUc=; b=gnhYcflfkuw2OvdNGBkl+ce2CNZT0zDxC/Nr0KyxScJoQrTRRRXrudZPdyOPYVV7s8119z YnXgi0QvuV9BbbDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2A9E613398; Mon, 13 Nov 2023 07:14:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eOQ+CcXMUWWVTQAAMHmgww (envelope-from ); Mon, 13 Nov 2023 07:14:13 +0000 Message-ID: <3c87a020-8921-4adf-8c9a-d0bd5af62b86@suse.de> Date: Mon, 13 Nov 2023 08:15:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 11/18] Do more DWARF reading in the background Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20231112-t-bg-dwarf-reading-v2-0-70fb170012ba@tromey.com> <20231112-t-bg-dwarf-reading-v2-11-70fb170012ba@tromey.com> From: Tom de Vries In-Reply-To: <20231112-t-bg-dwarf-reading-v2-11-70fb170012ba@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/12/23 21:25, Tom Tromey wrote: > + /* How much effort should be put into each worker. */ + const size_t > size_per_thread = total_size / n_worker_threads; I've tested the patch series on x86_64-linux, and ran into trouble in one test-case: ... (gdb) file /data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.dwarf2/dw2-dummy-cu/dw2-dummy-cu^M Reading symbols from /data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.dwarf2/dw2-dummy-cu/dw2-dummy-cu...^M /data/vries/gdb/src/gdb/dwarf2/read.c:5000: internal-error: do_reading: Assertion `iter != last' failed.^M A problem internal to GDB has been detected,^M further debugging may prove unreliable.^M ----- Backtrace -----^M ERROR: Couldn't load dw2-dummy-cu into GDB (GDB internal error). Resyncing due to internal error. (gdb) maint expand-symtab^M 0x5ac476 gdb_internal_backtrace_1^M /data/vries/gdb/src/gdb/bt-utils.c:122^M 0x5ac519 _Z22gdb_internal_backtracev^M /data/vries/gdb/src/gdb/bt-utils.c:168^M 0xd11a89 internal_vproblem^M /data/vries/gdb/src/gdb/utils.c:396^M 0xd11e58 _Z15internal_verrorPKciS0_P13__va_list_tag^M /data/vries/gdb/src/gdb/utils.c:476^M 0x14ca6f0 _Z18internal_error_locPKciS0_z^M /data/vries/gdb/src/gdbsupport/errors.cc:58^M 0x72b01b _ZN19cooked_index_worker10do_readingEv^M /data/vries/gdb/src/gdb/dwarf2/read.c:5000^M ... This fixes the test-case for me: ... diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 385160de0fd..191c2ad7f26 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -4974,7 +4974,8 @@ cooked_index_worker::do_reading () = std::max (gdb::thread_pool::g_thread_pool->thread_count (), (size_t) 1); /* How much effort should be put into each worker. */ - const size_t size_per_thread = total_size / n_worker_threads; + const size_t size_per_thread + = std::max (total_size / n_worker_threads, (size_t)1); /* Work is done in a task group. */ gdb::task_group workers ([this] () ... but I haven't done a full test-run. Thanks, - Tom