From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88358 invoked by alias); 8 Jul 2018 17:01:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88346 invoked by uid 89); 8 Jul 2018 17:01:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=pendant, letter X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Jul 2018 17:01:56 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 33A071E059; Sun, 8 Jul 2018 13:01:55 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531069315; bh=4OQZC7XLSLlh0LB1hlDTBp2aKeZDhcp7yJJ3/vprbPA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=flw+IgOarG8EsmeBGOL1UEuk6Kaeh2SKhs3FGlN3xaOpbKt6YNQWDeIqajqKQmVfN tYZrhOcKh+8EHBF5eh5AurYok5OGxo4KFqlKSJHV3GLL7hN5kbQmqLU7X+3fa34Fl3 JHdwOdmGmDiCP4zZNmK7oSZee5Ck+0UcgWpjyfsw= Subject: Re: [RFA 04/42] Move last_source file to buildsym_compunit To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-5-tom@tromey.com> <87a7r1662j.fsf@tromey.com> <87o9fh4qma.fsf@tromey.com> From: Simon Marchi Message-ID: <3c9a48f5-f1a1-c9e9-efa2-2293579121d8@simark.ca> Date: Sun, 08 Jul 2018 17:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87o9fh4qma.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00204.txt.bz2 On 2018-07-08 12:52 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> On 2018-07-08 12:33 PM, Tom Tromey wrote: >>> All the data members are private by the end of the series, but I didn't >>> generally try to do that at each step along the way. This is one of >>> those compromises I mentioned in the cover letter -- where a bigger >>> reordering of the series might have yielded a prettier series, but >>> didn't seem worth the effort. > > Simon> Ok, no problem then. You can ignore other similar comments I've > Simon> already sent. > > I already sent one other reply but you can likewise ignore that :) > > This series is a bit unwieldy. And I should probably have mentioned > earlier (before Keith went to the effort of applying it...) that it is > in my github as submit/buildsym-fixups, in case you wanted to check it > out or something. It's been mostly fine so far (just one or two trivial merge conflicts), but thanks for tip anyway. The patches are good on their own I think, so feel free to start pushing them as soon as they are approved, so the pendant part of the series gradually shrinks. Simon