From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2063.outbound.protection.outlook.com [40.107.115.63]) by sourceware.org (Postfix) with ESMTPS id 363DC3858D28 for ; Tue, 10 Oct 2023 14:56:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 363DC3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OpVuIb5KyOUuq9EKKl6reRQJ1bq+T1850egKapRHmuzhUwJRpY93tmQm/NB8qMlaGPCbRut5xSFjj7e/5K1rnxhXFNcGCqrk7oBOqyjBLc+pW0bPP74Yj79kUNjgGNdVnU6AdrNsrULhVxxOzCp7xVfx0u8G1rdBF15dIjMUY2CGpuQhpfjFMHvYpodcByMdV/dfxVDoBoABw9wxHV1SztL6cjr/SejV0Q0HKjbaOfReN9MrJt8kytutB9wZI0GAUw7B8o0yJqLf0Z5+NQEun6hSTqtD9Y0m5g4In6Jn78Qvg5qmnC2AOcQVo6z61YzIlweNnLHRc9sjOul8cHZ3Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PUW2vyamt76HqRcOrxE+3F96hEWAdE7DaN9U0X0fVPY=; b=SezBNec3TdfAgzA4O3LBikNhFc4z6s8uhWkaY7Cy5IwnZlDGuOuWZqOu8v9f/C6bMCFaFAl1JMfKzwLsSa6+U5JO/LW+mtZSPcFOlR+6YgxD/V1IOkeME1PkPIJWYQ372utGChBMXJJF1g+Yg3uD3bQ3KJrP9I+2ZtL90ve5EzrSynmFb1L4RWLLGt/BiVpKcl9Z0F4n+MQnUYTdFpIaheU1IzofW9L6J9dpR8MbvR9hB9Qo7M935Fu5Xh4CPqsyWQ2zrc02N0U129dGrDNnAQDKjFW8cDq+xJBDGi5m5rNAc2efOJP/wrbkJ5e1ytfpdTxUgaDt0I9CH0YdoIUugA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PUW2vyamt76HqRcOrxE+3F96hEWAdE7DaN9U0X0fVPY=; b=pwy2cUr1x89oLj3RYZDia/sEzp6mXIuHYXp0TESlx9RC4aqWEmyAh/TZiNcl6NnM9N65c4tZYG922JFUKSN9iEpE17w3dy4d3fZfG9kcSGkMSq3Mn/1q+W1jjAi2MdJalwaQx1UF9kJHwg0C+I2RpgNEJDuLQt+Bv0Z8eh6TDolWWcFPXEP8Frbpl1vkbwdWVdHXXhB4u6M64W7BXk252WtxN3Ez4pvrD31SkANiOy9bM3T6d54iZI4Q/HutmJn+yereyx5t3RJtvCmecUYh46atSoPp62T/LNgDs8ieeqIZmN3WbViBSFGBTbsGE9DUVjrozzrmF42ZlQRayn3RiQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT1PR01MB8554.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:c5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Tue, 10 Oct 2023 14:56:07 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a%6]) with mapi id 15.20.6863.032; Tue, 10 Oct 2023 14:56:07 +0000 Message-ID: <3cea024f-28df-4605-9301-ddf6a3027aea@efficios.com> Date: Tue, 10 Oct 2023 10:56:05 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] gdb: make remote_state's async token private Content-Language: fr To: Andrew Burgess , Simon Marchi , gdb-patches@sourceware.org References: <20231004020701.260411-1-simon.marchi@polymtl.ca> <20231004020701.260411-2-simon.marchi@polymtl.ca> <87fs2kduu0.fsf@redhat.com> From: Simon Marchi In-Reply-To: <87fs2kduu0.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR01CA0029.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01::37) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT1PR01MB8554:EE_ X-MS-Office365-Filtering-Correlation-Id: 7315582a-4e4b-40ea-bb7c-08dbc9a10835 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o8qcwr48y/mxraqOUoE6NyYHZNd7BqUXmIcnUL7JjKC1kbe5N9jlqsTM0WcLtqItRPMiqgTHMwlnXHc+AdKAheadgTShGDynKLucR/tBaZxVMhIR0gGlUB19ju02cj+9tQetVu76BoavPiylkHd4MrvZu3vf2zPfXT6vslsmdXiEADfSPcCMxv/Y8wHCNEg/DjVirWs8O5xQIQKCAkTFzOfhXRa5m+o2Rp7vJlA2Lqc5ha+dFMDFuWx4Ja/N44qJExqokEcWObnzNbtIvEagAEGKZ2e2yoYMMOpsOTlZmaNIgHPKbxYS/TnCsDL9omUwcRRBqtsZ4PouM+ep3koYBT7AngFYL693dz7LClV0eh7Ck6fwlhz5YNS2tQPgOuuu1LXOUYtf4dcGymjpoVD+TUs6VnruDQy1gnRfriWHSct0XT5QDEA45ahDwL1g0+Vd+Ho8JwY4CMpyeQAVC/IRaDWepyGNpGlo90J8iIOrvscZHgnTJB6Hq5JGEM8/uET9tgGs1Nd0QBEShUrwMJ0uQL98tezEb/FhDEHrTDe/osPBPGFqg8cv1kLUsIwsDNBElrJP3eAIpYqCFVK/UBdBcgVikAZUGkXvvC0wQZbuSma+GhEXCpYRSXy3clBw/Mufkn6cASaaWCcE52y8QlhUow== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(396003)(346002)(136003)(376002)(366004)(39830400003)(230922051799003)(186009)(451199024)(64100799003)(1800799009)(31686004)(2616005)(53546011)(26005)(38100700002)(36756003)(31696002)(478600001)(8676002)(2906002)(8936002)(83380400001)(6506007)(66556008)(6512007)(6486002)(5660300002)(41300700001)(44832011)(316002)(66476007)(66946007)(110136005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0phS3RUNnV3RUpaa3h4Ym9NTHcvQnJ1TStDQy9PNm5kVjhvb2s3ZGhFZ1hE?= =?utf-8?B?UUh0TGczcTdVT2FzUTdtT2FaQWVranNEdWR1SGEzQnpxWjVCVUFnbTBnNngx?= =?utf-8?B?bWt5SkxFU0QvbW03Y2J6M1BOY2p2MUZMWkxWV2I2QjdCd3lvbmo5Si9qNERk?= =?utf-8?B?bDFNNkhSR3JXU0VpcEpwWWsyUm84cWZzWlBxNVdJc1ovN2hoNXk2Tllrdm56?= =?utf-8?B?T0F5a0tTTXAyVmRzb2VaTURnbHY0UnczT1BuS3VQMVNUaUlQNmNyRXNVdk1p?= =?utf-8?B?dFZBMDZ5Yko1V015UXpNK05CTjRyeml6d3RPbitBVzVhaVBVbHFjd1g1UytR?= =?utf-8?B?WGhScUg4VzhzSXMxYS9aYXRhMUJTRlJGNll5MDNkUkRIemplcThsaU8rR3o2?= =?utf-8?B?aHhmL2plN1E1WDYvK01kckxSY0g3ZW5ISFMyQXVUYiszMEFYR1NDTG8vWDNW?= =?utf-8?B?eEwvT0ltdmJ5NS8vQm91L2VteGFkc1BvVWswLzNyMGE0eExDejk4aWg5aHNm?= =?utf-8?B?cjJLa3BTWTNIekNXVDJBZ1pBSnhNZXU4ZVFGVkpzZUgvcDN1VGkrMjM3amJu?= =?utf-8?B?SlF6QzlwZ1haNzZHTU1ROVVBcHIxcTRzSFByL2hnYW1sbHM2ZEdLd1ZPWVRI?= =?utf-8?B?ZGpWdlhIaStoemtSeTVNbnpaNFdBM08yem5LZXdrTjlhdUZnKys5YjM1VHJm?= =?utf-8?B?SitWWVB1a0tUZGhjZmxzSUViK0FGV2dmSlVVbHR6UlNON2FKVjhnUVd2OXY4?= =?utf-8?B?TXpQL2RJMkFWMkV3MXJrQU9zeXBEbVlCRHAwaEl4UXB4VjdYUi9VNTcyNEpS?= =?utf-8?B?d2JIS01aY1cvYk40S0Ezb2pRSWo2VFdsdWZLbDJxYXJBclVBVm9nZjlHOHZJ?= =?utf-8?B?b2dkdzVqYStxdWdlMlNySjZ3QXEzU3IyMkcyOEpQemQzdG1VeTZUUzlPRi9L?= =?utf-8?B?cnlGbGJYY1luTkFxaGtzd0pkRldFNUhWaGpjMUQrR1kxNVB4a2o2MVRoc2dt?= =?utf-8?B?MlR6NTUyTHM2OWxXQlRzRW14OHNaRWlNZGJSaDZUOUNhVEJmYVAxZ1J0eHdn?= =?utf-8?B?UU13dXFnT20wTmRsNDhrbXFlUm1PNlM5UGlhMmhlditPUUN6bWRYczJndVM1?= =?utf-8?B?bHlJR1lOcGhaaFlRQ1ZsNHhERmMwK2tsMm1xZ0w3RGh1YWZicjBTQzZJRTF4?= =?utf-8?B?RlRDdVdpbElHMzdZc0NSMEhKQmJpdHFNajNYN3ZFTnRRbU5yYnpQaEE0bzNZ?= =?utf-8?B?T2NsZGtqeC9Ob2tIL2YyaThwYWdBYVF3YlFrekhyanNxdDJHNGNBb3NvTE1x?= =?utf-8?B?UzBxTlpDaG91MWgyM2NnK3JNd3IyNkJsZnZvdXV0blcyN0lwTUpYN1dOVTFk?= =?utf-8?B?bG9aVmt4SGNqQ0VYdmZwVGcrcmdkL3VDdWFJY1pzaVF0NHRGYjVQam1YMTlF?= =?utf-8?B?Sk90cTVHcms5TTU3UWpsUVlRdzBTZXQvTVNWS2VBamtubVZLYkxPM0U5dmts?= =?utf-8?B?Y1RCSTZZcUFGQllHeml3MmtyZlk3cTRhck00dm8zSzlHN2FudjJiNzBkcnRj?= =?utf-8?B?OGV6a29TSk9ZYzFIell1Vm8wT0pEa0hqSkRTcFA3V1BmcktVa25YNFhKT3FW?= =?utf-8?B?UTY3WjlQTk9jK1V5R0FjdlYzOGdTTUlQazRTN0d4T1ltTG4zTk9yTC93N3RB?= =?utf-8?B?Q0k4MGtPSFNFNVc0ZFZzWVBNVmNMTFVEeHJUcWVWekJ0OEVyVUVWMVdtK3Nl?= =?utf-8?B?Q0tNVEVKWU92VTJDa1crRmRPZDRncE9IbVB2dVNadm1TL1B1YWU5a0prQVlP?= =?utf-8?B?c2JtaDY3SkljdU1pOXdXM0oyQXZnNEJJL1Y5aVBNMGxKbnBtdG5jTW8wUmtw?= =?utf-8?B?ckpQdE5nWVRoa2w0aUhydHNvbjVUM1JoSlFlL2hkdjg2OXlLWWdwQ3BqOUVW?= =?utf-8?B?SG5INnl3bUVkckJQS2xLcEkzSUdzVGdsaTBBdmVWQ3FLTjFuMkg2dTlNd1Qv?= =?utf-8?B?bGIxcjZEMFo0ZW9SRU8wc3pRTXZQTkxXN1F3UEJFNW9EOXFWMFQ1YWtQMzFl?= =?utf-8?B?NHZYYWtzVWxJL2hmNjIxa0JCWEh1YWZVZXJTa0VXaGMwRC9QK0dXSndOTmc4?= =?utf-8?Q?q/B/MpRz2xBndyoLdsa/uQNdh?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7315582a-4e4b-40ea-bb7c-08dbc9a10835 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 14:56:07.2074 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EvmCxfWNXk+J03NqjrqQfRAxQy7sd9sNTP9NZEkTD0ep5Uz+Lzv3ZiIqoBzQ6aFwyCWHD//ZpjhLufZnN5f9dw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB8554 X-Spam-Status: No, score=-3038.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/9/23 05:11, Andrew Burgess wrote: > Simon Marchi via Gdb-patches writes: > >> From: Simon Marchi >> >> Make remote_async_inferior_event_token private (rename to >> m_async_event_handler_token) and add methods for the various operations >> we do on it. This will help by: >> >> - allowing to break on those methods when debugging >> - allowing to add assertions in the methods > > Looks good. Couple of minor nits. > >> >> Change-Id: Ia3b8a2bc48ad4849dbbe83442c3f83920f03334d >> --- >> gdb/remote.c | 70 ++++++++++++++++++++++++++++++++-------------------- >> 1 file changed, 43 insertions(+), 27 deletions(-) >> >> diff --git a/gdb/remote.c b/gdb/remote.c >> index 9bb4f1de5982..2deba06d7d47 100644 >> --- a/gdb/remote.c >> +++ b/gdb/remote.c >> @@ -413,6 +413,31 @@ class remote_state >> /* Get the remote arch state for GDBARCH. */ >> struct remote_arch_state *get_remote_arch_state (struct gdbarch *gdbarch); >> >> + void create_async_event_handler () >> + { > > Maybe add: > > gdb_assert (m_async_event_handler_token == nullptr); > > If this was ever not true then we'd leak a token, right? Makes sense, added. >> + m_async_event_handler_token >> + = ::create_async_event_handler ([] (gdb_client_data data) >> + { > > Spaces before tabs here. Fixed. >> private: >> + /* Asynchronous signal handle registered as event loop source for >> + when we have pending events ready to be passed to the core. */ >> + async_event_handler *m_async_event_handler_token = nullptr; >> + > > Trailing white-space here. Fixed, thanks. Simon