From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 03/12] Update core-related help strings
Date: Fri, 04 May 2018 18:11:00 -0000 [thread overview]
Message-ID: <3cfb1618-6bf4-e92b-b841-b80bba1e553e@redhat.com> (raw)
In-Reply-To: <20180430143731.30007-4-tom@tromey.com>
On 04/30/2018 03:37 PM, Tom Tromey wrote:
> diff --git a/gdb/gcore.c b/gdb/gcore.c
> index 5ff4e6dc77..c53810049c 100644
> --- a/gdb/gcore.c
> +++ b/gdb/gcore.c
> @@ -611,7 +611,8 @@ _initialize_gcore (void)
> {
> add_com ("generate-core-file", class_files, gcore_command, _("\
> Save a core file with the current state of the debugged process.\n\
> -Argument is optional filename. Default filename is 'core.<process_id>'."));
> +Usage: generate-core-file [FILENAME]\n\
> +Argument is optional filename. Default filename is 'core.PROCESS_ID'."));
Do the guidelines say anything about this? I mean, PROCESS_ID is not
user input, so I'm wondering whether it should be all caps, or whether
it was better as it was.
Otherwise looks fine.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-05-04 18:11 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 14:37 [RFA 00/12] Small help text tweaks Tom Tromey
2018-04-30 14:37 ` [RFA 03/12] Update core-related help strings Tom Tromey
2018-05-04 18:11 ` Pedro Alves [this message]
2018-05-09 20:31 ` Tom Tromey
2018-05-24 21:28 ` Pedro Alves
2018-04-30 14:37 ` [RFA 05/12] Update help strings in TUI Tom Tromey
2018-05-04 18:26 ` Pedro Alves
2018-04-30 14:37 ` [RFA 07/12] Update help text for "jump" command Tom Tromey
2018-05-04 18:52 ` Pedro Alves
2018-04-30 14:37 ` [RFA 10/12] Update help text in record-btrace.c Tom Tromey
2018-05-04 18:55 ` Pedro Alves
2018-04-30 14:37 ` [RFA 04/12] Update memattr.c help strings Tom Tromey
2018-05-04 18:16 ` Pedro Alves
2018-05-09 20:35 ` Tom Tromey
2018-05-24 17:53 ` Pedro Alves
2018-04-30 14:37 ` [RFA 11/12] Update help text in linux-fork.c Tom Tromey
2018-05-04 18:56 ` Pedro Alves
2018-04-30 14:37 ` [RFA 01/12] Fix help and documentation for inferior commands Tom Tromey
2018-04-30 15:26 ` Eli Zaretskii
2018-05-04 18:07 ` Pedro Alves
2018-05-09 20:29 ` Tom Tromey
2018-05-10 9:17 ` Eli Zaretskii
2018-04-30 14:37 ` [RFA 08/12] Update help text in disasm.c Tom Tromey
2018-05-04 18:54 ` Pedro Alves
2018-04-30 14:37 ` [RFA 02/12] Update help strings in skip.c Tom Tromey
2018-05-04 18:09 ` Pedro Alves
2018-04-30 14:37 ` [RFA 12/12] Update help text in record.c Tom Tromey
2018-05-04 18:57 ` Pedro Alves
2018-04-30 14:37 ` [RFA 06/12] Update help text in dcache.c Tom Tromey
2018-05-04 18:27 ` Pedro Alves
2018-04-30 14:37 ` [RFA 09/12] Update help text in tracepoint.c Tom Tromey
2018-05-04 18:54 ` Pedro Alves
2018-04-30 14:40 ` [RFA 00/12] Small help text tweaks Eli Zaretskii
2018-04-30 15:13 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cfb1618-6bf4-e92b-b841-b80bba1e553e@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).