From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106977 invoked by alias); 19 Jun 2017 18:36:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106851 invoked by uid 89); 19 Jun 2017 18:36:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Missed X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Jun 2017 18:36:44 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0F7F3B170; Mon, 19 Jun 2017 18:36:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0F7F3B170 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0F7F3B170 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1C68B17CED; Mon, 19 Jun 2017 18:36:42 +0000 (UTC) Subject: Re: [PATCH v6] C++ify gdb/common/environ.c To: Sergio Durigan Junior References: <20170413040455.23996-1-sergiodj@redhat.com> <20170619043531.32394-1-sergiodj@redhat.com> <87k248y3zp.fsf@redhat.com> <8aabc6fabb04f4e3e8b08e6fa1b0eacc@polymtl.ca> <816a5744-b3b4-855c-5f2e-4c9f0d255512@redhat.com> <1cff1a8055c0d770fef7171b8394e86d@polymtl.ca> <7cf7b53f-600a-32f5-c9d0-2f45a8bb2b46@redhat.com> <50ea9e5c05e31e1e459f22901ee86527@polymtl.ca> <9be4fd14-279e-3dde-656d-3ea6b9aab148@redhat.com> <87tw3bx3i4.fsf@redhat.com> <1e62abc1-ab02-65dd-f520-27120be033b8@redhat.com> <87lgonx2dg.fsf@redhat.com> Cc: Simon Marchi , GDB Patches From: Pedro Alves Message-ID: <3d0dca3f-2b00-54a4-6ed7-a8af32729721@redhat.com> Date: Mon, 19 Jun 2017 18:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87lgonx2dg.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00535.txt.bz2 On 06/19/2017 07:23 PM, Sergio Durigan Junior wrote: > On Monday, June 19 2017, Pedro Alves wrote: >> Missed fixing move ctor? >> >> + /* Move constructor. */ >> + gdb_environ (gdb_environ &&e) >> + : m_environ_vector (std::move (e.m_environ_vector)) >> + {} > > Indeed. Fixed now. I'll submit v7. Make sure to add unit tests for the move ctor. E.g., reuse the move assign tests. Thanks, Pedro Alves