From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 1625A3858284; Mon, 26 Sep 2022 14:08:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1625A3858284 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 28QE8Vsx001582 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Sep 2022 10:08:35 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 28QE8Vsx001582 Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id EE7F21E0D5; Mon, 26 Sep 2022 10:08:30 -0400 (EDT) Message-ID: <3d0e846b-b8bd-d0f2-953b-7a8d5cd3bbd6@polymtl.ca> Date: Mon, 26 Sep 2022 10:08:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3] binutils, gdb: support zstd compressed debug sections Content-Language: en-US To: Alan Modra Cc: Fangrui Song , Jan Beulich , Nick Clifton , binutils@sourceware.org, gdb-patches@sourceware.org References: <20220923040837.550160-1-maskray@google.com> <7eadf897-9370-5a00-ae57-8e07251b8702@polymtl.ca> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 26 Sep 2022 14:08:31 +0000 X-Spam-Status: No, score=-3033.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Sep 2022 14:08:46 -0000 >> But what about the other configure.ac files, don't >> they need PKG_PROG_PKG_CONFIG too? gdb/configure.ac, for instance, uses >> pkg-config for debuginfod. So if the user passes --without-debuginfod >> --with-zstd, I expect things to fail, as the pkg-config will be skipped. > > No, that will be fine, I think The reason being that > PKG_CHECK_MODULES AC_REQUIREs PKG_PROG_PKG_CONFIG. So the expansion > of AC_DEBUGINFOD will emit an expansion of PKG_PROG_PKG_CONFIG if that > has not already occurred, before the entire AC_DEBUGINFOD expansion. Ah, makes sense. Thanks for the explanation Alan. > >> binutils/configure.ac probably has the same problem, since it uses >> PKG_CHECK_MODULES for msgpack. > > I'll fix this one even though it isn't a problem now because > AC_DEBUGINFOD and AM_ZSTD preceed it. We should use AS_IF more often, > particularly when autoconf macros are invoked. Silly question but... AM_ZSTD was clearly named after AM_ZLIB. But why does AM_ZLIB have the "AM" (automake, I suppose) prefix? It doesn't seem to have anything to do with automake. Ack about AS_IF, I will try to remember this for top-level configure code. Simon