From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 733CA3858C52 for ; Mon, 28 Nov 2022 21:31:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 733CA3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9EC1A1FDC1; Mon, 28 Nov 2022 21:31:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1669671061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eOCco7B75t3I0tz3lEKtSxwnoTUnyZ+U+swbvTqWt2Y=; b=2Rh9+QUtuQ8L1aPucdSEFFIC+BvCN62b9lOIqYR8cITQtaxoksYUA09mrGSUEH+xsGDSH7 xsw1HePvzXZUlIZcD8ssFTaABnRJmSMHe6kfdGVMD9zY4G5o8HFkwxR5Cre1A6X7TAFhxa OWxWT94hZ4YQ0gvMx+5ZGoeJCHK6b+E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1669671061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eOCco7B75t3I0tz3lEKtSxwnoTUnyZ+U+swbvTqWt2Y=; b=kqeSpRNbwWAcGd0J9Egt1IZ83U3n2SMhY05OrCCNfEYsV+qicnaRzc5ZsGRHTmIQEMRKjH BhOdIC9QR0M54+AQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 722671326E; Mon, 28 Nov 2022 21:31:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UuR9GpUohWOccwAAMHmgww (envelope-from ); Mon, 28 Nov 2022 21:31:01 +0000 Message-ID: <3d15ada9-ea26-e77a-26ed-5860bb83c113@suse.de> Date: Mon, 28 Nov 2022 22:31:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [pushed] [gdb/testsuite] Fix gdb.ada/out_of_line_in_inlined.exp for ppc64le Content-Language: en-US To: Carl Love , gdb-patches@sourceware.org Cc: Ulrich Weigand , Tom Tromey , Will Schmidt References: <20221128162134.20424-1-tdevries@suse.de> From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/28/22 22:07, Carl Love wrote: > Tom: > > On Mon, 2022-11-28 at 21:46 +0100, Tom de Vries wrote: >>> I made the change $decimal\\.$decimal? and that seemed >>> to work on my system. I tried the test on my X86 box but it is not >>> supported. Looks like the system doesn't have the ada compiler >>> installed. >>> >>> Can you verify that the change works on your system and if the >>> patch >>> looks ok. Thanks. >>> >> >> It doesn't work, as expected, because the output is: >> ... >> Breakpoint 1, foo_o224_021.child1.child2 (s=...) at >> /home/vries/gdb_versions/devel/binutils- >> gdb.git/gdb/testsuite/gdb.ada/out_of_line_in_inlined/foo_o224_021.adb >> :24^M >> ... >> and $decimal\\.$decimal? does not match "1". > > If I use the original suggestion, here is the patch I ran: > > diff --git a/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp b/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp > index 621b04e179b..54c55bc6f7e 100644 > --- a/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp > +++ b/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp > @@ -34,7 +34,7 @@ foreach_with_prefix scenario {all minimal} { > > gdb_run_cmd > gdb_test "" \ > - "Breakpoint $decimal, ($hex in )?foo_o224_021\\.child1\\.child2 \\(s=\\.\\.\\.\\).*" \ > + "Breakpoint $decimal(\\.$decimal)?, ($hex in )?foo_o224_021\\.child1\\.child2 \\(s=\\.\\.\\.\\).*" \ > "run to foo_o224_021.child1.child2" > > set opt_addr_in "($hex in)?" > > then I run the test I get: > > make check RUNTESTFLAGS='GDB=/home/carll/bin/gdb gdb.ada/out_of_line_in_inlined.exp ' > out > WARNING: Couldn't find the global config file. > WARNING: Couldn't find tool init file > WARNING: Couldn't find the global config file. > WARNING: Couldn't find tool init file > WARNING: Couldn't find the global config file. > WARNING: Couldn't find tool init file > WARNING: Couldn't find the global config file. > WARNING: No tool specified > WARNING: Couldn't find the global config file. > ERROR: tcl error sourcing /home/carll/GDB/build-test/gdb/testsuite/../../../binutils-gdb-test/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp. > ERROR: tcl error code TCL LOOKUP VARNAME decimal > ERROR: can't read "decimal(\.[0-9]+)": variable isn't array Ah I see, yes the $var($index) is tcl syntax for accessing an array element. So, this should work: ${decimal}(\\.$decimal)? Thanks, - Tom