From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 3D2713858C54 for ; Mon, 27 Mar 2023 21:13:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D2713858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.170] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id DE9A91E0D3; Mon, 27 Mar 2023 17:13:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1679951618; bh=4DgY8wS9K9ZAdbQuPjIfyfI9YV1MOwDGi5IS9m8cuFA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZLztEQKsgsNSkDUbYpISRUL/+TGfrOHHjJplfTwNoTNMP702awylm/ZyajteEX+DQ PZ9BO/pulMJYZAXcSUEx6pqLOd1lPTQiKBS+93LgEgfy5rk/io6XgA1MRpxIcz8ftt NC8b8W7hiQMiQ30WwR1+KhLE/mjJWYj1G1VNYKG0= Message-ID: <3d16dc5d-d034-8589-785e-9d994c4f77a5@simark.ca> Date: Mon, 27 Mar 2023 17:13:37 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/2] gdb/doc: MPFR is now a necessary requirement Content-Language: fr To: Philippe Blain , gdb-patches@sourceware.org Cc: Andrew Pinski References: <20230306-doc-require-mpfr-fix-v1-0-8f207504dd3e@gmail.com> <20230306-doc-require-mpfr-fix-v1-1-8f207504dd3e@gmail.com> From: Simon Marchi In-Reply-To: <20230306-doc-require-mpfr-fix-v1-1-8f207504dd3e@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/10/23 12:46, Philippe Blain via Gdb-patches wrote: > Since 99118062785 (Use toplevel configure for GMP and MPFR for gdb, > 2022-11-08), MPFR is mandatory for building GDB. That commit adjusted > the "Requirements for Building GDB" section of the documentation so that > the MPFR entry mentions "now uses" instead of "can use", but left the > whole entry under the "Tools/Packages Optional for Building GDB" > heading. > > Move the MPFR entry to the "Tools/Packages Necessary for Building GDB" > heading. > --- > gdb/doc/gdb.texinfo | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 2a2077c29d1..218c2da9c86 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -39781,6 +39781,21 @@ you can use the @option{--with-gmp} option or options > @option{--with-gmp-include} and @option{--with-gmp-lib} to specify > its location. > > +@item MPFR > +@anchor{MPFR} > +@value{GDBN} now uses the GNU MPFR multiple-precision floating-point Unlike in the NEWS file, where we describe the changes from one version to another, the documentation is meant to describe the GDB version is comes with. Therefore, I find it odd to use "now" in the documentation. I would just say "GDB uses the GNU MPFR...". I know it's pre-existing text and it's the same in the GMP paragraph, but it sounds weird there too. Imagine reading the doc 20 years down the road, and it says "GDB now uses the GNU GMP...", as if it's a new thing. Simon