From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98275 invoked by alias); 26 Jan 2018 15:37:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97218 invoked by uid 89); 26 Jan 2018 15:37:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-12.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 Jan 2018 15:37:11 +0000 Received: from ESESSHC016.ericsson.se (Unknown_Domain [153.88.183.66]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 66.BC.31026.42B4B6A5; Fri, 26 Jan 2018 16:37:09 +0100 (CET) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.66) with Microsoft SMTP Server (TLS) id 14.3.352.0; Fri, 26 Jan 2018 16:37:08 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.62.3] (192.75.88.130) by DM5PR1501MB2005.namprd15.prod.outlook.com (2603:10b6:4:a1::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Fri, 26 Jan 2018 15:37:05 +0000 Subject: Re: [ANNOUNCEMENT] GDB 8.1 release branch created! To: Eli Zaretskii , References: <83h8rlyakm.fsf@gnu.org> <83lggvupt6.fsf@gnu.org> <83lgglnadl.fsf@gnu.org> <83fu6sln4o.fsf@gnu.org> From: Simon Marchi Message-ID: <3d75778f-5c91-5680-b9fa-c2f2c902ff67@ericsson.com> Date: Fri, 26 Jan 2018 15:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <83fu6sln4o.fsf@gnu.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM5PR16CA0006.namprd16.prod.outlook.com (2603:10b6:3:c0::16) To DM5PR1501MB2005.namprd15.prod.outlook.com (2603:10b6:4:a1::35) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 99a51b3f-44fe-4e95-7a3c-08d564d2a73e X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:DM5PR1501MB2005; X-Microsoft-Exchange-Diagnostics: 1;DM5PR1501MB2005;3:ii10rZuohKiK8zoSsT+WybVEVRPE6wei0ClMdyyhZEfHsf3/zRZqEaXy23Nw7lzu3PGOsUqrFdeaUk9JoANvHmbvbAm0lKtzx0wESjkIEfauebAthlM7lLbAOPUhydOWzLLJfKSp52g88etMV2zOs5nEG76SSsPtnDFTaBAkfwvShsPZV8NxmoqtbqwjZ/pC6S8Wziygyf1OsRpbwlaEPvVpV0/dqK4EDVJHQ+HDKQP4TPUT+g3vV1X03+BaLWZn;25:d43lxwMio8lDyIKheZylSboYbxMtdlIkYcr48x1G9mo3qddexaWxw/VF0CTVAD9/hOg2Frba6/kb6D+Kc+3ZDvbXUS8fLYkG9o1rs/bYsWHmA9kinU9yFyYYpxxq1VzhUM7F21w9pNj71heUI4jsOqWGr66dDaIQrl+ZXS0wzM/gfOyDe+YAsiT9vmm4721XX3mnZoDi9T+DvXF1lW1dgxnpPhk7Ue0upwXUXkw/cjsj1dE1VgdptzDqp7qnp6Kaay/+iFLnI6GF3PtDK1y0Z9Uz/OItChbr4Cs569OU+pQU7C7552CJb6gMCqp+GrYlfNC07qPOgIF6YZH95j1X1g==;31:yLw7yzcjjvFqIydqOkrnpzmJAKLrNLpgZntFvbKag/Z/FyBLe4Dt1jbxwtrR2rW2cachGix/co4dxjiR+ia3X05upFB00xfpd/MNk6WZCMdfFxhWvQi9qEYOY4cOsR8yjAStOoDlI4otLz8mHZvzgx0nQTTlqYfBnx1s+NN4m0ZzglINWHHRmr3l7Jn7Oo9OJw+tIJ3fLtcny/FVyeE7VlidXtqGuy/yy/BWK4so/I4= X-MS-TrafficTypeDiagnostic: DM5PR1501MB2005: X-Microsoft-Exchange-Diagnostics: 1;DM5PR1501MB2005;20:Kv1QgClIM4QekgFQq1v6gQP6udimGsFJs9E8Yl04gC6DMNdJnG/P9AB5ewyVS7lH33Gw/X+k/iZjrnsE6ua5I1DkZXq3gBdnUwubllynVwUWdYJVCsWlwTr6YkFeNfJ0mixeQA+U5disR3PZFjV31vpyAuMtkcxx8BQ8HuTnMIMz3CVeM4cDsTxQkob1eQiuJphos1N20Ycl8pZFBGD61+Js3gZ70YG40uZzUK6a9zrSNf8q/7ByVKU+pYgTMKZKv9Cj2iMdvQXvXa4Rr6WQeMOIN5uOb0lgyy+x23sEBIqjH69da0UlKeY//jgZXgUnfeBjJYNIIMmCO73Vvzl2hv5K50yW6oEe+UsDXHEYzbd2D+SkYgoj6jEtnXgPDyRvVQUiMPewPZBvCzUGtasZX8yyZMOz9NRCwwBliOAdG13+52IqkKiY7goXDpQmmRNjZBasVcQEEVeQ07D7fjnmS+nlH/C/ZD7oshENijIbLfQ3uyiYVH3Peoqxls/ZYzFa;4:/JY1tO3Uy6NXTM3yOIwx4xcxgO8x17ZqFcnxRWYxtr2l9X0InN/64Z8gOYsqJfCvCaf/xse6FsHvb808r87JlXRnl5RKiT7u+MMRlMhIiBMchToyht37I8asii61N9Ff4v+BlmPmLCkz10Z1Cerc/Sz0vPAxo9MQBJntVm/TFakM9xKS1Cpe5HBwqyGocc8k3C9pATkgncwqtDoTrVdqWrRX+yP1YXDyZoF7UYqyj8PKYt9VTxnWEtysmEnduxohuiDtCDirOjAu+loXfRfcGHDd7TtOLMtgSZkuB4GvigtwR7ZT3jzCtwaK8+ohuPTF X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(22074186197030); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231023)(2400081)(944501161)(10201501046)(6041288)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:DM5PR1501MB2005;BCL:0;PCL:0;RULEID:;SRVR:DM5PR1501MB2005; X-Forefront-PRVS: 05641FD966 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(39860400002)(396003)(376002)(346002)(39380400002)(366004)(199004)(189003)(57704003)(377424004)(65806001)(65956001)(66066001)(8936002)(81156014)(81166006)(8676002)(50466002)(6246003)(26005)(49976009)(106356001)(25786009)(230700001)(226693001)(64126003)(31696002)(76176011)(36756003)(6486002)(2486003)(5660300001)(52146003)(52116002)(23676004)(97736004)(386003)(53546011)(53936002)(6116002)(229853002)(65826007)(3846002)(83506002)(305945005)(93886005)(31686004)(7736002)(86362001)(316002)(2950100002)(6666003)(105586002)(16576012)(186003)(16526019)(2906002)(47776003)(478600001)(58126008)(68736007)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR1501MB2005;H:[142.133.62.3];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjE1MDFNQjIwMDU7MjM6WHEzRGJWMlRVdVZiVmJtUzFONG94MXRn?= =?utf-8?B?ZzlOakI5bVhWVVgxc294bkFjY2Z1M2VnRE91ODh1L3lxM1A0ejdsOEtjaHNB?= =?utf-8?B?WkFCOENFblFMRC94dTkrbXV3K0k1RlBDTExpMEpEZWMvcEhqY1Q4V3lnaFh2?= =?utf-8?B?SmRkNDJYdDlmelFCNjZIZEhzUW1DN1ZseVFqb0dKelN2L1hpTi90MGNvcUVv?= =?utf-8?B?SjFmTG04UW9YalFyb0x6UGQrbnYvSFppL1ZseERMQ2MrNU5RRGdaOU83cXFB?= =?utf-8?B?eVFSVzdXQUJEWG95Nlg0ckFBM2dJREI3bmp0UXJqY09DcTlLVFlwdDZTODBF?= =?utf-8?B?RUVOengvSnc3QWhQY1N2eVZGSHBYWEY2THZkd3lOQ1EwVkdaQ2tlOVRLV3N3?= =?utf-8?B?V3luK2VuRjVPSm1peHUwbEc3dEJuOGVZVmRjMC8vbkpwOGlkWmQwYW9MZTIv?= =?utf-8?B?aEk0Q25rakdpNUwyUm1udk9GWE1NUHBMYVIyU0lWeUtQL0Z5OXhJWVkrVk5t?= =?utf-8?B?NW1YRGExOXZ6eDFhdE5aVlJ0c0oxTm9sUUZpa1FCRnhOZGlWSFMxSkU0QWNj?= =?utf-8?B?RkJHYlhDRE5pdlRxODJtODZaRlJycWRHcVBpMUI5bUh6cjJ1UksyYXJxdzli?= =?utf-8?B?SDNFSnlNNFgvWXE2cXJIWTZjd1dJN2s4eTY0WUQxSis3R2Q0bVdqLzdzbW8v?= =?utf-8?B?T2gwcjVWZjdJS1JZQ2RsanpwbjVEZlg3RzNWT1RFSDVHWTJVcHJHemNXKytw?= =?utf-8?B?Vk1sdHUvVGRrdmJOTzA1RDYvdXdZM016b1R3cXE5eWkrSVlhdDdkbTV6bDJj?= =?utf-8?B?Mmdoc1lWYW05aXllcGdpSVZzamROMnlSRkN5eUF5dEUwMTI2RkpYeE9TbGI0?= =?utf-8?B?ZjcwZERpdGViSnkvNDZJNURGenJuU2M2SUVaOFZTdkRYSEJUVmdOZjhVemdU?= =?utf-8?B?SzBWcnR5THlpNFE0K1o3OFVQQnJ4a1ZCcEpPWHg3L2F2UkFBVlRoTGtUdEtZ?= =?utf-8?B?b0c2bVhxcExHemZRTXBiWTJJTGZlbFVMREVWS1pKUmcvNUFoZitTZzA4UzlF?= =?utf-8?B?V055cmVablluM0JmQmFPZUlxaGVGeVdpUWtGNlZPWldUQlJ4U3daQ2tjbnpj?= =?utf-8?B?ejNMbFdRQmxuVDVBVDN4Z253K3Z3OXMvN3hOanJzWCs3OG0vWkhBQ2JyZnNk?= =?utf-8?B?TEZsMWx2aEI0MnZqUys4YVlDZFJDNWRrcjRnNmFlS3dKc3E4MjJ2Z1N0R1I0?= =?utf-8?B?YnFrLzRYa1ZkNXA5dEFpclQ3VVlaOEhzcjNmSFAxR2F3K1NWY2hWb0NwVnN1?= =?utf-8?B?bnhzOGZYM1REOXFuQzVJUG8razQzb3VMWVFTM0h4ZjRqRmFqcFFINktCbFFY?= =?utf-8?B?dlN1SDJFMEVDMkVVU25CWkxJZTBVMjlCeDNUZm1VYlhLNG4remRwOW9Tc2lB?= =?utf-8?B?STcyMkk1L28vTFd5SU1HUHoyTHM2Q3piSFRmYi9NWkdiM1NFRW1OelNEY2Js?= =?utf-8?B?SnBHR3FlQmtKWDJqSGFYbFdlWS9RVVZOZTh3a1dKemRCSzZoMGJsNTZhSjFT?= =?utf-8?B?eDFPenlTelhKNDBSdTgzL1dRazFaT3ZUa3lXeXl4QklUbTJMT3JGQ0FQMmE4?= =?utf-8?B?cEFmMUhLakJ6MjdmSk9UZk9xNGJtV2tkVFZ5cWdkNXFpTEZKdmtUZmdJWmlh?= =?utf-8?B?cnBNTkEvb0xFblphTzhTOXBSbkNuWTRXTnF3Z1RhQXNvZDA2SlkydWhOQURp?= =?utf-8?B?ekRsYjdTWWI2d1pBK29rZ2QwUzU1aFVxWHdLWnF0TVBIV2cwV1ZMejZyTks5?= =?utf-8?B?N1dFaVFvSW1pNGlDeFBNRXU1UHVyZjZYampaaVhPdjBuREJ2ZVZMOEhZeWxT?= =?utf-8?B?Y2VTRGtGd3Mwalp2Z2puZkZzVjJCd1hCRkVGZ0ZjN1E3dVNaYWdzbzRFMTAv?= =?utf-8?B?V0tNenhpM2R6N0E9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR1501MB2005;6:bZWLdVJA2cSko6ODAlIE7wEjX3FjpBlJxbIMMUIC/PZstc2IUjc9Ub2bMiJiN+H8Xqcfb6zwhaHbnRquYDudnTAi3rnC3AH7c0qpo/Fj/BdSkkxwoxQVvNpmpgvMmHQcRLz3GOqMCR+kR2AQS8J8SwLecsW5tSPa4B2jZohAioCxflncaalMCt3TnR92/rpIGXjZI4QcSjjSmFGDiHzyYEB41/WEEJkMqFuH8qnNRvKkvDXwbitcZN6K38JOLei3q5ZoBQVo/O1XUy5w3JkBFOeCsbSjIh7Jh0SXA+lxVEqvy2FoHhN/tfFhZvmSZpNNx8GXDlj5i+AcljldpAzOI3dFH8uUc4KaXiaTid/GqJw=;5:mvsnlgqCmyC7LNZmAvRfLGOuFZGvwdyQ4aw62kCeG1Vfw5WFJqmX26SAT2w2v/Sw8IvzkQpgo3sZO2bHHYCenynWSYlUMOsS841pj7axKDXsjQPCcnCPnVJa7Q4FL6TQd5yIMr1+uir34E3VcEMKffsxoDfirorQMrLa53YCQVo=;24:IeF9R1aPWd6N0ZO90GBEs1VUhSwaJwLSkhrIHAYWYWfGGq/4xc/u+9K1eWrAdTnQhNPyV5sifeJ/Sw9y9HIAnJ3A4QCfVX7tQm56EpOJh3Q=;7:fQWdukxB1RP9JA1Rm+1LMYg9ewHYZkDolJGCvWZVbMn+G05p3ZH8QOMj77zUFXLFG94jp2+gQ3aEvhltEV/oSF6FpK3srbXnUf2sXpOvi/HUFzMfKBuMaw4Tz07ePuaFRRkWOSq/NN9wJF/qJggvFO0fSKZHOi+fPLCG1INbAj4IyExT52PEq2GJ7LXUQC0+EEydyHDCALUE5bks+vlE4cR7vLQ44KYE6g7x/0a+iQGg8I2al2ekttxsQN6F3tb1 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2018 15:37:05.3030 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 99a51b3f-44fe-4e95-7a3c-08d564d2a73e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1501MB2005 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00562.txt.bz2 On 2018-01-26 09:18 AM, Eli Zaretskii wrote: > Ping! Ping! Ping! This is delaying the release of GDB 8.1. > > Should I just stop waiting for approval and push this? Hi Eli, I didn't reply to your pings because I don't feel qualified to review changes related to mingw (you are probably the most qualified person here, since you use it). Given the lack of response, I'd say you can go ahead with the change, tt seems relatively safe. I have one question below. >> Date: Thu, 25 Jan 2018 18:58:30 +0200 >> From: Eli Zaretskii >> >>> Date: Thu, 18 Jan 2018 17:52:53 +0200 >>> From: Eli Zaretskii >> >> Ping! Ping! OK to push this? >> >>> Ping! Is it OK to install the patch proposed below? >>> >>>> Date: Tue, 16 Jan 2018 19:31:37 +0200 >>>> From: Eli Zaretskii >>>> >>>> g++ -x c++ -O2 -gdwarf-4 -g3 -I. -I. -I./common -I./config -DLOCALEDIR="\"d:/usr/share/locale\"" -DHAVE_CONFIG_H -I./../include/opcode -I./../opcodes/.. -I./../readline/.. -I../bfd -I./../bfd -I./../include -I../libdecnumber -I./../libdecnumber -I./gnulib/import -Ibuild-gnulib/import -DTUI=1 -Id:/usr/include -Id:/usr/include/guile/2.0 -Id:/usr/include -Id:/usr/Python26/include -Id:/usr/Python26/include -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized -Wno-format -fno-strict-aliasing -DNDEBUG -fwrapv -c -o python/py-arch.o -MT python/py-arch.o -MMD -MP -MF python/.deps/py-arch.Tpo python/py-arch.c >>>> In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0, >>>> from build-gnulib/import/math.h:27, >>>> from d:/usr/Python26/include/pyport.h:235, >>>> from d:/usr/Python26/include/Python.h:58, >>>> from python/python-internal.h:94, >>>> from python/py-arch.c:24: >>>> d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared >>>> using ::hypot; >>>> ^~~~~ >>>> Makefile:1618: recipe for target `python/py-arch.o' failed >>>> >>>> Googling suggests the following solution; is it okay to push this >>>> (with the necessary logs and after doing the "paperwork" required for >>>> branch changes)? Or does someone have better ideas? (Does this work >>>> in MinGW64?) >>>> >>>> --- gdb/python/python-internal.h~0 2018-01-12 05:31:04.000000000 +0200 >>>> +++ gdb/python/python-internal.h 2018-01-16 08:56:10.717759900 +0200 >>>> @@ -85,6 +85,12 @@ >>>> #define HAVE_SNPRINTF 1 >>>> #endif >>>> >>>> +/* Another kludge to avoid compilation errors because MinGW defines >>>> + 'hypot' to '_hypot', but the C++ headers says "using ::hypot". */ >>>> +#if defined(__MINGW32__) && defined(__cplusplus) Do we need "defined(__cplusplus)", since we are always building GDB as a C++ program? Thanks, Simon