From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id C9241385B835 for ; Thu, 16 Apr 2020 19:24:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C9241385B835 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-65-2KqqBY7tMdO0dJ29UQCJwQ-1; Thu, 16 Apr 2020 15:24:02 -0400 X-MC-Unique: 2KqqBY7tMdO0dJ29UQCJwQ-1 Received: by mail-ed1-f71.google.com with SMTP id j10so5628919edy.21 for ; Thu, 16 Apr 2020 12:24:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4pzM926E/VD9/WnP5QD+u1oWA3zM9oO4vUMgrTZ/7co=; b=W9QuzxPKxHmwJ3QLgD/pP3jYNCULHBkpWZJHBl0WhhIvA1am3Op8rws5+0cHub67am +/6fKEPzpeTLWMFkKTfen6rP7NkC4jD8CyEQBKszW+rLLuGh/FGcZRUerJ1m7+L90rPJ AE9RPw+GtWqnGt3Aa4VJkZJjBQ9grumM6K5nQASPqMhwudh0jANWwytSrA1m95BNcpcs +5VHqHBT+3MTPFjokoBboH4IcKAW2qootejY6hiG4kS45OZ55bS38i7ceStFfkus2ela RnFvD1Sj6OJSB5Jgji+LXyGiVsFITGHNtmTQIs3JkAN64agMBKNbLLPu+ua0xZBrY3c1 aZcw== X-Gm-Message-State: AGi0PuYP03xF1M0jacWUrEuQeI4IJkHwrHjX9ikIonrONJgFdkBgjcqT WqmSMUSREh8nKwZuGEXVIN8f+ATv3j5CEqENJJh6Q9lkk0o8MPaaGTAmeQi36aUypCH3EdaF2V8 Mz/0CnFrGHlozJOS5OW1uUQ== X-Received: by 2002:aa7:db47:: with SMTP id n7mr3524748edt.195.1587065040116; Thu, 16 Apr 2020 12:24:00 -0700 (PDT) X-Google-Smtp-Source: APiQypLn0G3JPbAKTv+3sFS1HW5qdv6MYM0C2oNWjUbEbG8JO/kCWBgRahmHMpPa3TN7bsnsO7/wOg== X-Received: by 2002:aa7:db47:: with SMTP id n7mr3524742edt.195.1587065039959; Thu, 16 Apr 2020 12:23:59 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id l16sm2661135edv.71.2020.04.16.12.23.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Apr 2020 12:23:59 -0700 (PDT) Subject: Re: [PATCH 16/28] Don't write to inferior_ptid in darwin-nat.c To: Simon Marchi , gdb-patches@sourceware.org References: <20200414175434.8047-1-palves@redhat.com> <20200414175434.8047-17-palves@redhat.com> From: Pedro Alves Message-ID: <3dce5d8e-1c26-2bc6-3e3e-501bf30f772f@redhat.com> Date: Thu, 16 Apr 2020 20:23:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_2, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2020 19:24:05 -0000 On 4/16/20 2:33 AM, Simon Marchi wrote: > On 2020-04-14 1:54 p.m., Pedro Alves via Gdb-patches wrote: >> Untested. >> >> gdb/ChangeLog: >> yyyy-mm-dd Pedro Alves >> >> * darwin-nat.c (darwin_nat_target::decode_message): Don't write to >> inferior_ptid. >> (darwin_nat_target::stop_inferior, darwin_nat_target::kill): Avoid >> inferior_ptid. >> (darwin_attach_pid): Use switch_to_no_thread instead of writing to >> inferior_ptid directly. >> (darwin_nat_target::init_thread_list): Switch to thread, instead >> of writing to inferior_ptid. >> (darwin_nat_target::attach): Don't write to inferior_ptid. >> (darwin_nat_target::get_ada_task_ptid): Avoid inferior_ptid. >> --- >> gdb/darwin-nat.c | 16 +++++++--------- >> 1 file changed, 7 insertions(+), 9 deletions(-) > > I tried to build it, here's a small patch to fix some typos. It would be good to > check the other patches that you were not able to build for that pid_t/ptid_t typo. Thanks, I merged that fix locally. I diffed the whole series and didn't find any other case. Pedro Alves