* Breakage on builder Solaris11-sparcv9-m64, revision 080363310650c93ad8e93018bcb6760ba5d32d1c
2018-11-22 16:39 Oh dear. I regret to inform you that commit 080363310650c93ad8e93018bcb6760ba5d32d1c might be unfortunate gdb-buildbot
@ 2018-11-22 16:39 ` gdb-buildbot
2018-11-22 16:49 ` Breakage on builder Solaris11-amd64-m64, " gdb-buildbot
1 sibling, 0 replies; 10+ messages in thread
From: gdb-buildbot @ 2018-11-22 16:39 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
Unfortunately it seems that there is a breakage on GDB.
Commit title: 'Per-inferior thread list, thread ranges/iterators, down with ALL_THREADS, etc.'
Revision: 080363310650c93ad8e93018bcb6760ba5d32d1c
You can find more details below:
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Buildslave:
solaris11-sparcv9
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Solaris11-sparcv9-m64/builds/406>
Commit(s) tested:
080363310650c93ad8e93018bcb6760ba5d32d1c
Author(s) (in the same order as the commits):
Pedro Alves <palves@redhat.com>
Subject:
Per-inferior thread list, thread ranges/iterators, down with ALL_THREADS, etc.
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Solaris11-sparcv9-m64/08/080363310650c93ad8e93018bcb6760ba5d32d1c/>
*** Failed to compiled GDB. ***
============================
+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.
set_language (m_lang);
~~~~~~~~~~~~~^~~~~~~~
../../binutils-gdb/gdb/symtab.c:4600:41: note: *((void*)& l +4) was declared here
scoped_switch_to_sym_language_if_auto l (sym);
^
In file included from ../../binutils-gdb/gdb/frame.h:72:0,
from ../../binutils-gdb/gdb/gdbarch.h:39,
from ../../binutils-gdb/gdb/defs.h:526,
from ../../binutils-gdb/gdb/symtab.c:20:
../../binutils-gdb/gdb/language.h: In function bool treg_matches_sym_type_name(const compiled_regex&, const symbol*):
../../binutils-gdb/gdb/language.h:735:20: warning: *((void*)& l +4) may be used uninitialized in this function [-Wmaybe-uninitialized]
set_language (m_lang);
~~~~~~~~~~~~~^~~~~~~~
../../binutils-gdb/gdb/symtab.c:4292:43: note: *((void*)& l +4) was declared here
scoped_switch_to_sym_language_if_auto l (sym);
^
CXX target-memory.o
CXX target.o
CXX target/waitstatus.o
CXX thread-fsm.o
CXX thread-iter.o
CXX thread.o
CXX tid-parse.o
CXX top.o
CXX tracefile-tfile.o
CXX tracefile.o
CXX tracepoint.o
CXX trad-frame.o
CXX tramp-frame.o
CXX tui/tui-command.o
CXX tui/tui-data.o
CXX tui/tui-disasm.o
CXX tui/tui-file.o
CXX tui/tui-hooks.o
CXX tui/tui-interp.o
CXX tui/tui-io.o
CXX tui/tui-layout.o
CXX tui/tui-out.o
CXX tui/tui-regs.o
CXX tui/tui-source.o
CXX tui/tui-stack.o
CXX tui/tui-win.o
CXX tui/tui-windata.o
CXX tui/tui-wingeneral.o
CXX tui/tui-winsource.o
CXX tui/tui.o
CXX typeprint.o
CXX ui-file.o
CXX ui-out.o
CXX unittests/array-view-selftests.o
CXX unittests/cli-utils-selftests.o
CXX unittests/common-utils-selftests.o
CXX unittests/copy_bitwise-selftests.o
CXX unittests/environ-selftests.o
CXX unittests/format_pieces-selftests.o
CXX unittests/function-view-selftests.o
CXX unittests/lookup_name_info-selftests.o
CXX unittests/memory-map-selftests.o
CXX unittests/memrange-selftests.o
CXX unittests/mkdir-recursive-selftests.o
CXX unittests/observable-selftests.o
CXX unittests/offset-type-selftests.o
CXX unittests/optional-selftests.o
CXX unittests/parse-connection-spec-selftests.o
CXX unittests/ptid-selftests.o
CXX unittests/rsp-low-selftests.o
CXX unittests/scoped_fd-selftests.o
CXX unittests/scoped_mmap-selftests.o
CXX unittests/scoped_restore-selftests.o
CXX unittests/string_view-selftests.o
CXX unittests/tracepoint-selftests.o
CXX unittests/unpack-selftests.o
CXX unittests/utils-selftests.o
CXX unittests/xml-utils-selftests.o
CXX user-regs.o
CXX utils.o
CXX valarith.o
CXX valops.o
CXX valprint.o
CXX value.o
CXX varobj.o
CXX version.o
CXX xml-builtin.o
CXX xml-support.o
CXX xml-syscall.o
CXX xml-tdesc.o
GEN init.c
CXX init.o
CXXLD gdb
Undefined first referenced
symbol in file
is_exited(ptid_t) procfs.o
ld: fatal: symbol referencing errors
collect2: error: ld returned 1 exit status
gmake[2]: *** [Makefile:1912: gdb] Error 1
gmake[2]: Leaving directory '/opt/gdb-buildbot/home/solaris11-sparcv9/solaris11-sparcv9-m64/build/gdb'
gmake[1]: *** [Makefile:8792: all-gdb] Error 2
gmake[1]: Leaving directory '/opt/gdb-buildbot/home/solaris11-sparcv9/solaris11-sparcv9-m64/build'
gmake: *** [Makefile:849: all] Error 2
============================
^ permalink raw reply [flat|nested] 10+ messages in thread
* Oh dear. I regret to inform you that commit 080363310650c93ad8e93018bcb6760ba5d32d1c might be unfortunate
@ 2018-11-22 16:39 gdb-buildbot
2018-11-22 16:39 ` Breakage on builder Solaris11-sparcv9-m64, revision 080363310650c93ad8e93018bcb6760ba5d32d1c gdb-buildbot
2018-11-22 16:49 ` Breakage on builder Solaris11-amd64-m64, " gdb-buildbot
0 siblings, 2 replies; 10+ messages in thread
From: gdb-buildbot @ 2018-11-22 16:39 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
My lords, ladies, gentlemen, members of the public.
It is a matter of great regret and sadness to inform you that commit:
Per-inferior thread list, thread ranges/iterators, down with ALL_THREADS, etc.
080363310650c93ad8e93018bcb6760ba5d32d1c
might have made GDB unwell. Since I am just your Butler BuildBot,
I kindly ask that a human superior officer double-check this.
Please note that if you are reading this message on gdb-patches, there might
be other builders broken.
You can find more details about the unfortunate breakage in the next messages.
Cheers,
Your GDB BuildBot.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Breakage on builder Solaris11-amd64-m64, revision 080363310650c93ad8e93018bcb6760ba5d32d1c
2018-11-22 16:39 Oh dear. I regret to inform you that commit 080363310650c93ad8e93018bcb6760ba5d32d1c might be unfortunate gdb-buildbot
2018-11-22 16:39 ` Breakage on builder Solaris11-sparcv9-m64, revision 080363310650c93ad8e93018bcb6760ba5d32d1c gdb-buildbot
@ 2018-11-22 16:49 ` gdb-buildbot
2018-11-23 13:34 ` Pedro Alves
1 sibling, 1 reply; 10+ messages in thread
From: gdb-buildbot @ 2018-11-22 16:49 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
Unfortunately it seems that there is a breakage on GDB.
Commit title: 'Per-inferior thread list, thread ranges/iterators, down with ALL_THREADS, etc.'
Revision: 080363310650c93ad8e93018bcb6760ba5d32d1c
You can find more details below:
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Buildslave:
solaris11-amd64
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Solaris11-amd64-m64/builds/408>
Commit(s) tested:
080363310650c93ad8e93018bcb6760ba5d32d1c
Author(s) (in the same order as the commits):
Pedro Alves <palves@redhat.com>
Subject:
Per-inferior thread list, thread ranges/iterators, down with ALL_THREADS, etc.
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Solaris11-amd64-m64/08/080363310650c93ad8e93018bcb6760ba5d32d1c/>
*** Failed to compiled GDB. ***
============================
+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.
~~~~~~~~~~~~~^~~~~~~~
../../binutils-gdb/gdb/symtab.c:4600:41: note: *((void*)& l +4) was declared here
scoped_switch_to_sym_language_if_auto l (sym);
^
In file included from ../../binutils-gdb/gdb/frame.h:72:0,
from ../../binutils-gdb/gdb/gdbarch.h:39,
from ../../binutils-gdb/gdb/defs.h:526,
from ../../binutils-gdb/gdb/symtab.c:20:
../../binutils-gdb/gdb/language.h: In function bool treg_matches_sym_type_name(const compiled_regex&, const symbol*):
../../binutils-gdb/gdb/language.h:735:20: warning: *((void*)& l +4) may be used uninitialized in this function [-Wmaybe-uninitialized]
set_language (m_lang);
~~~~~~~~~~~~~^~~~~~~~
../../binutils-gdb/gdb/symtab.c:4292:43: note: *((void*)& l +4) was declared here
scoped_switch_to_sym_language_if_auto l (sym);
^
CXX target-memory.o
CXX target.o
CXX target/waitstatus.o
CXX thread-fsm.o
CXX thread-iter.o
CXX thread.o
CXX tid-parse.o
CXX top.o
CXX tracefile-tfile.o
CXX tracefile.o
CXX tracepoint.o
CXX trad-frame.o
CXX tramp-frame.o
CXX tui/tui-command.o
CXX tui/tui-data.o
CXX tui/tui-disasm.o
CXX tui/tui-file.o
CXX tui/tui-hooks.o
CXX tui/tui-interp.o
CXX tui/tui-io.o
CXX tui/tui-layout.o
CXX tui/tui-out.o
CXX tui/tui-regs.o
CXX tui/tui-source.o
CXX tui/tui-stack.o
CXX tui/tui-win.o
CXX tui/tui-windata.o
CXX tui/tui-wingeneral.o
CXX tui/tui-winsource.o
CXX tui/tui.o
CXX typeprint.o
CXX ui-file.o
CXX ui-out.o
CXX unittests/array-view-selftests.o
CXX unittests/cli-utils-selftests.o
CXX unittests/common-utils-selftests.o
CXX unittests/copy_bitwise-selftests.o
CXX unittests/environ-selftests.o
CXX unittests/format_pieces-selftests.o
CXX unittests/function-view-selftests.o
CXX unittests/lookup_name_info-selftests.o
CXX unittests/memory-map-selftests.o
CXX unittests/memrange-selftests.o
CXX unittests/mkdir-recursive-selftests.o
CXX unittests/observable-selftests.o
CXX unittests/offset-type-selftests.o
CXX unittests/optional-selftests.o
CXX unittests/parse-connection-spec-selftests.o
CXX unittests/ptid-selftests.o
CXX unittests/rsp-low-selftests.o
CXX unittests/scoped_fd-selftests.o
CXX unittests/scoped_mmap-selftests.o
CXX unittests/scoped_restore-selftests.o
CXX unittests/string_view-selftests.o
CXX unittests/tracepoint-selftests.o
CXX unittests/unpack-selftests.o
CXX unittests/utils-selftests.o
CXX unittests/xml-utils-selftests.o
CXX user-regs.o
CXX utils.o
CXX valarith.o
CXX valops.o
CXX valprint.o
CXX value.o
CXX varobj.o
CXX version.o
CXX x86-tdep.o
CXX xml-builtin.o
CXX xml-support.o
CXX xml-syscall.o
CXX xml-tdesc.o
GEN init.c
CXX init.o
CXXLD gdb
Undefined first referenced
symbol in file
is_exited(ptid_t) procfs.o
ld: fatal: symbol referencing errors
collect2: error: ld returned 1 exit status
gmake[2]: *** [Makefile:1912: gdb] Error 1
gmake[2]: Leaving directory '/opt/gdb-buildbot/home/solaris11-amd64/solaris11-amd64-m64/build/gdb'
gmake[1]: *** [Makefile:8792: all-gdb] Error 2
gmake[1]: Leaving directory '/opt/gdb-buildbot/home/solaris11-amd64/solaris11-amd64-m64/build'
gmake: *** [Makefile:849: all] Error 2
============================
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Breakage on builder Solaris11-amd64-m64, revision 080363310650c93ad8e93018bcb6760ba5d32d1c
2018-11-22 16:49 ` Breakage on builder Solaris11-amd64-m64, " gdb-buildbot
@ 2018-11-23 13:34 ` Pedro Alves
2018-11-23 14:06 ` Sergio Durigan Junior
0 siblings, 1 reply; 10+ messages in thread
From: Pedro Alves @ 2018-11-23 13:34 UTC (permalink / raw)
To: gdb-buildbot, gdb-patches, Rainer Orth
On 11/22/2018 04:49 PM, gdb-buildbot@sergiodj.net wrote:
> Undefined first referenced
> symbol in file
> is_exited(ptid_t) procfs.o
> ld: fatal: symbol referencing errors
> collect2: error: ld returned 1 exit status
> gmake[2]: *** [Makefile:1912: gdb] Error 1
> gmake[2]: Leaving directory '/opt/gdb-buildbot/home/solaris11-amd64/solaris11-amd64-m64/build/gdb'
> gmake[1]: *** [Makefile:8792: all-gdb] Error 2
> gmake[1]: Leaving directory '/opt/gdb-buildbot/home/solaris11-amd64/solaris11-amd64-m64/build'
> gmake: *** [Makefile:849: all] Error 2
> ============================
Whoops, sorry about that. I assume this works, but I haven't tried it.
From a48ec78677f732cc78eeefecc149742eb4ca0624 Mon Sep 17 00:00:00 2001
From: Pedro Alves <palves@redhat.com>
Date: Fri, 23 Nov 2018 13:13:35 +0000
Subject: [PATCH] Fix Solaris build
The recent commit 080363310650 ("Per-inferior thread list, thread
ranges/iterators, down with ALL_THREADS, etc.") removed the
definitions of is_running/is_stopped/is_exited but missed updating a
couple uses of is_exited in Solaris-specific code.
gdb/ChangeLog:
2018-11-23 Pedro Alves <palves@redhat.com>
* procfs.c (procfs_notice_thread): Replace uses of
in_thread_list/is_exited with find_thread_ptid/THREAD_EXITED.
* sol-thread.c (sol_thread_target::wait)
(sol_update_thread_list_callback): Likewise.
---
gdb/procfs.c | 3 ++-
gdb/sol-thread.c | 14 ++++++++------
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/gdb/procfs.c b/gdb/procfs.c
index 0d8f9df966..f82fc83987 100644
--- a/gdb/procfs.c
+++ b/gdb/procfs.c
@@ -3133,7 +3133,8 @@ procfs_notice_thread (procinfo *pi, procinfo *thread, void *ptr)
{
ptid_t gdb_threadid = ptid_t (pi->pid, thread->tid, 0);
- if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid))
+ thread_info *thr = find_thread_ptid (gdb_threadid);
+ if (thr == NULL || thr->state == THREAD_EXITED)
add_thread (gdb_threadid);
return 0;
diff --git a/gdb/sol-thread.c b/gdb/sol-thread.c
index 682302a40b..0a57c4d1a6 100644
--- a/gdb/sol-thread.c
+++ b/gdb/sol-thread.c
@@ -462,9 +462,11 @@ sol_thread_target::wait (ptid_t ptid, struct target_waitstatus *ourstatus,
/* See if we have a new thread. */
if (rtnval.tid_p ()
&& rtnval != save_ptid
- && (!in_thread_list (rtnval)
- || is_exited (rtnval)))
- add_thread (rtnval);
+ {
+ thread_info *thr = find_thread_ptid (rtnval);
+ if (thr == NULL || thr->state == THREAD_EXITED)
+ add_thread (rtnval);
+ }
}
/* During process initialization, we may get here without the thread
@@ -1035,14 +1037,14 @@ sol_update_thread_list_callback (const td_thrhandle_t *th, void *ignored)
{
td_err_e retval;
td_thrinfo_t ti;
- ptid_t ptid;
retval = p_td_thr_get_info (th, &ti);
if (retval != TD_OK)
return -1;
- ptid = ptid_t (inferior_ptid.pid (), 0, ti.ti_tid);
- if (!in_thread_list (ptid) || is_exited (ptid))
+ ptid_t ptid = ptid_t (inferior_ptid.pid (), 0, ti.ti_tid);
+ thread_info *thr = find_thread_ptid (ptid);
+ if (thr == NULL || thr->state == THREAD_EXITED)
add_thread (ptid);
return 0;
--
2.14.4
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Breakage on builder Solaris11-amd64-m64, revision 080363310650c93ad8e93018bcb6760ba5d32d1c
2018-11-23 13:34 ` Pedro Alves
@ 2018-11-23 14:06 ` Sergio Durigan Junior
2018-11-23 14:12 ` Sergio Durigan Junior
0 siblings, 1 reply; 10+ messages in thread
From: Sergio Durigan Junior @ 2018-11-23 14:06 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches, Rainer Orth
On Friday, November 23 2018, Pedro Alves wrote:
> On 11/22/2018 04:49 PM, gdb-buildbot@sergiodj.net wrote:
>> Undefined first referenced
>> symbol in file
>> is_exited(ptid_t) procfs.o
>> ld: fatal: symbol referencing errors
>> collect2: error: ld returned 1 exit status
>> gmake[2]: *** [Makefile:1912: gdb] Error 1
>> gmake[2]: Leaving directory '/opt/gdb-buildbot/home/solaris11-amd64/solaris11-amd64-m64/build/gdb'
>> gmake[1]: *** [Makefile:8792: all-gdb] Error 2
>> gmake[1]: Leaving directory '/opt/gdb-buildbot/home/solaris11-amd64/solaris11-amd64-m64/build'
>> gmake: *** [Makefile:849: all] Error 2
>> ============================
>
> Whoops, sorry about that. I assume this works, but I haven't tried it.
I took the liberty of running try builds with your patch on the Solaris
builders:
https://gdb-build.sergiodj.net/builders/Solaris11-amd64-m64/builds/410
https://gdb-build.sergiodj.net/builders/Solaris11-sparcv9-m64/builds/408
Unfortunately the build still fails with:
../../binutils-gdb/gdb/sol-thread.c: In member function ‘virtual ptid_t sol_thread_target::wait(ptid_t, target_waitstatus*, int)’:
../../binutils-gdb/gdb/sol-thread.c:465:2: error: expected ‘)’ before ‘{’ token
{
^
../../binutils-gdb/gdb/sol-thread.c:470:5: error: expected primary-expression before ‘}’ token
}
^
BTW, it's possible to run try builds on specific builders by using the
"-b" option with "buildbot try". E.g.:
buildbot try -b Solaris11-amd64-m64 -b Solaris11-sparcv9-m64
Thanks,
> From a48ec78677f732cc78eeefecc149742eb4ca0624 Mon Sep 17 00:00:00 2001
> From: Pedro Alves <palves@redhat.com>
> Date: Fri, 23 Nov 2018 13:13:35 +0000
> Subject: [PATCH] Fix Solaris build
>
> The recent commit 080363310650 ("Per-inferior thread list, thread
> ranges/iterators, down with ALL_THREADS, etc.") removed the
> definitions of is_running/is_stopped/is_exited but missed updating a
> couple uses of is_exited in Solaris-specific code.
>
> gdb/ChangeLog:
> 2018-11-23 Pedro Alves <palves@redhat.com>
>
> * procfs.c (procfs_notice_thread): Replace uses of
> in_thread_list/is_exited with find_thread_ptid/THREAD_EXITED.
> * sol-thread.c (sol_thread_target::wait)
> (sol_update_thread_list_callback): Likewise.
> ---
> gdb/procfs.c | 3 ++-
> gdb/sol-thread.c | 14 ++++++++------
> 2 files changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/gdb/procfs.c b/gdb/procfs.c
> index 0d8f9df966..f82fc83987 100644
> --- a/gdb/procfs.c
> +++ b/gdb/procfs.c
> @@ -3133,7 +3133,8 @@ procfs_notice_thread (procinfo *pi, procinfo *thread, void *ptr)
> {
> ptid_t gdb_threadid = ptid_t (pi->pid, thread->tid, 0);
>
> - if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid))
> + thread_info *thr = find_thread_ptid (gdb_threadid);
> + if (thr == NULL || thr->state == THREAD_EXITED)
> add_thread (gdb_threadid);
>
> return 0;
> diff --git a/gdb/sol-thread.c b/gdb/sol-thread.c
> index 682302a40b..0a57c4d1a6 100644
> --- a/gdb/sol-thread.c
> +++ b/gdb/sol-thread.c
> @@ -462,9 +462,11 @@ sol_thread_target::wait (ptid_t ptid, struct target_waitstatus *ourstatus,
> /* See if we have a new thread. */
> if (rtnval.tid_p ()
> && rtnval != save_ptid
> - && (!in_thread_list (rtnval)
> - || is_exited (rtnval)))
> - add_thread (rtnval);
> + {
> + thread_info *thr = find_thread_ptid (rtnval);
> + if (thr == NULL || thr->state == THREAD_EXITED)
> + add_thread (rtnval);
> + }
> }
>
> /* During process initialization, we may get here without the thread
> @@ -1035,14 +1037,14 @@ sol_update_thread_list_callback (const td_thrhandle_t *th, void *ignored)
> {
> td_err_e retval;
> td_thrinfo_t ti;
> - ptid_t ptid;
>
> retval = p_td_thr_get_info (th, &ti);
> if (retval != TD_OK)
> return -1;
>
> - ptid = ptid_t (inferior_ptid.pid (), 0, ti.ti_tid);
> - if (!in_thread_list (ptid) || is_exited (ptid))
> + ptid_t ptid = ptid_t (inferior_ptid.pid (), 0, ti.ti_tid);
> + thread_info *thr = find_thread_ptid (ptid);
> + if (thr == NULL || thr->state == THREAD_EXITED)
> add_thread (ptid);
>
> return 0;
> --
> 2.14.4
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Breakage on builder Solaris11-amd64-m64, revision 080363310650c93ad8e93018bcb6760ba5d32d1c
2018-11-23 14:06 ` Sergio Durigan Junior
@ 2018-11-23 14:12 ` Sergio Durigan Junior
2018-11-23 14:16 ` Rainer Orth
0 siblings, 1 reply; 10+ messages in thread
From: Sergio Durigan Junior @ 2018-11-23 14:12 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches, Rainer Orth
On Friday, November 23 2018, I wrote:
> On Friday, November 23 2018, Pedro Alves wrote:
>
>> On 11/22/2018 04:49 PM, gdb-buildbot@sergiodj.net wrote:
>>> Undefined first referenced
>>> symbol in file
>>> is_exited(ptid_t) procfs.o
>>> ld: fatal: symbol referencing errors
>>> collect2: error: ld returned 1 exit status
>>> gmake[2]: *** [Makefile:1912: gdb] Error 1
>>> gmake[2]: Leaving directory '/opt/gdb-buildbot/home/solaris11-amd64/solaris11-amd64-m64/build/gdb'
>>> gmake[1]: *** [Makefile:8792: all-gdb] Error 2
>>> gmake[1]: Leaving directory '/opt/gdb-buildbot/home/solaris11-amd64/solaris11-amd64-m64/build'
>>> gmake: *** [Makefile:849: all] Error 2
>>> ============================
>>
>> Whoops, sorry about that. I assume this works, but I haven't tried it.
>
> I took the liberty of running try builds with your patch on the Solaris
> builders:
>
> https://gdb-build.sergiodj.net/builders/Solaris11-amd64-m64/builds/410
> https://gdb-build.sergiodj.net/builders/Solaris11-sparcv9-m64/builds/408
>
> Unfortunately the build still fails with:
>
> ../../binutils-gdb/gdb/sol-thread.c: In member function ‘virtual ptid_t sol_thread_target::wait(ptid_t, target_waitstatus*, int)’:
> ../../binutils-gdb/gdb/sol-thread.c:465:2: error: expected ‘)’ before ‘{’ token
> {
> ^
> ../../binutils-gdb/gdb/sol-thread.c:470:5: error: expected primary-expression before ‘}’ token
> }
> ^
>
> BTW, it's possible to run try builds on specific builders by using the
> "-b" option with "buildbot try". E.g.:
>
> buildbot try -b Solaris11-amd64-m64 -b Solaris11-sparcv9-m64
And the actual commit failed with another reason:
https://gdb-build.sergiodj.net/builders/Solaris11-amd64-m64/builds/411/steps/compile%20gdb/logs/stdio
../../binutils-gdb/gdb/procfs.c: In function ‘int procfs_notice_thread(procinfo*, procinfo*, void*)’:
../../binutils-gdb/gdb/procfs.c:3136:41: error: ‘is_exited’ was not declared in this scope
if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid))
^~~~~~~~~
../../binutils-gdb/gdb/procfs.c:3136:41: note: suggested alternative: ‘inf_exited’
if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid))
^~~~~~~~~
inf_exited
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Breakage on builder Solaris11-amd64-m64, revision 080363310650c93ad8e93018bcb6760ba5d32d1c
2018-11-23 14:12 ` Sergio Durigan Junior
@ 2018-11-23 14:16 ` Rainer Orth
2018-11-23 16:39 ` Pedro Alves
0 siblings, 1 reply; 10+ messages in thread
From: Rainer Orth @ 2018-11-23 14:16 UTC (permalink / raw)
To: Sergio Durigan Junior; +Cc: Pedro Alves, gdb-patches
Hi Sergio,
> On Friday, November 23 2018, I wrote:
>
>> On Friday, November 23 2018, Pedro Alves wrote:
>>
>>> On 11/22/2018 04:49 PM, gdb-buildbot@sergiodj.net wrote:
>>>> Undefined first referenced
>>>> symbol in file
>>>> is_exited(ptid_t) procfs.o
>>>> ld: fatal: symbol referencing errors
>>>> collect2: error: ld returned 1 exit status
>>>> gmake[2]: *** [Makefile:1912: gdb] Error 1
>>>> gmake[2]: Leaving directory
>>>> '/opt/gdb-buildbot/home/solaris11-amd64/solaris11-amd64-m64/build/gdb'
>>>> gmake[1]: *** [Makefile:8792: all-gdb] Error 2
>>>> gmake[1]: Leaving directory
>>>> '/opt/gdb-buildbot/home/solaris11-amd64/solaris11-amd64-m64/build'
>>>> gmake: *** [Makefile:849: all] Error 2
>>>> ============================
>>>
>>> Whoops, sorry about that. I assume this works, but I haven't tried it.
>>
>> I took the liberty of running try builds with your patch on the Solaris
>> builders:
>>
>> https://gdb-build.sergiodj.net/builders/Solaris11-amd64-m64/builds/410
>> https://gdb-build.sergiodj.net/builders/Solaris11-sparcv9-m64/builds/408
>>
>> Unfortunately the build still fails with:
>>
>> ../../binutils-gdb/gdb/sol-thread.c: In member function ‘virtual ptid_t sol_thread_target::wait(ptid_t, target_waitstatus*, int)’:
>> ../../binutils-gdb/gdb/sol-thread.c:465:2: error: expected ‘)’ before ‘{’ token
>> {
>> ^
>> ../../binutils-gdb/gdb/sol-thread.c:470:5: error: expected primary-expression before ‘}’ token
>> }
>> ^
>>
>> BTW, it's possible to run try builds on specific builders by using the
>> "-b" option with "buildbot try". E.g.:
>>
>> buildbot try -b Solaris11-amd64-m64 -b Solaris11-sparcv9-m64
>
> And the actual commit failed with another reason:
>
> https://gdb-build.sergiodj.net/builders/Solaris11-amd64-m64/builds/411/steps/compile%20gdb/logs/stdio
>
> ../../binutils-gdb/gdb/procfs.c: In function ‘int procfs_notice_thread(procinfo*, procinfo*, void*)’:
> ../../binutils-gdb/gdb/procfs.c:3136:41: error: ‘is_exited’ was not declared in this scope
> if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid))
> ^~~~~~~~~
> ../../binutils-gdb/gdb/procfs.c:3136:41: note: suggested alternative: ‘inf_exited’
> if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid))
> ^~~~~~~~~
> inf_exited
this is weird: I still see a declaration in gdbthread.h (and also
is_running and is_stopped), which should go as well.
With just the typo above fixed, a local build on amd64-pc-solaris2.11
has just finished; make check running...
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Breakage on builder Solaris11-amd64-m64, revision 080363310650c93ad8e93018bcb6760ba5d32d1c
2018-11-23 14:16 ` Rainer Orth
@ 2018-11-23 16:39 ` Pedro Alves
2018-11-25 14:55 ` Rainer Orth
0 siblings, 1 reply; 10+ messages in thread
From: Pedro Alves @ 2018-11-23 16:39 UTC (permalink / raw)
To: Rainer Orth, Sergio Durigan Junior; +Cc: gdb-patches
--
Thanks,
Pedro Alves
On 11/23/2018 02:16 PM, Rainer Orth wrote:
> Hi Sergio,
>
>> On Friday, November 23 2018, I wrote:
>>
>>> On Friday, November 23 2018, Pedro Alves wrote:
>>>
>>>> On 11/22/2018 04:49 PM, gdb-buildbot@sergiodj.net wrote:
>>>>> Undefined first referenced
>>>>> symbol in file
>>>>> is_exited(ptid_t) procfs.o
>>>>> ld: fatal: symbol referencing errors
>>>>> collect2: error: ld returned 1 exit status
>>>>> gmake[2]: *** [Makefile:1912: gdb] Error 1
>>>>> gmake[2]: Leaving directory
>>>>> '/opt/gdb-buildbot/home/solaris11-amd64/solaris11-amd64-m64/build/gdb'
>>>>> gmake[1]: *** [Makefile:8792: all-gdb] Error 2
>>>>> gmake[1]: Leaving directory
>>>>> '/opt/gdb-buildbot/home/solaris11-amd64/solaris11-amd64-m64/build'
>>>>> gmake: *** [Makefile:849: all] Error 2
>>>>> ============================
>>>>
>>>> Whoops, sorry about that. I assume this works, but I haven't tried it.
>>>
>>> I took the liberty of running try builds with your patch on the Solaris
>>> builders:
>>>
>>> https://gdb-build.sergiodj.net/builders/Solaris11-amd64-m64/builds/410
>>> https://gdb-build.sergiodj.net/builders/Solaris11-sparcv9-m64/builds/408
>>>
>>> Unfortunately the build still fails with:
>>>
>>> ../../binutils-gdb/gdb/sol-thread.c: In member function ‘virtual ptid_t sol_thread_target::wait(ptid_t, target_waitstatus*, int)’:
>>> ../../binutils-gdb/gdb/sol-thread.c:465:2: error: expected ‘)’ before ‘{’ token
>>> {
>>> ^
>>> ../../binutils-gdb/gdb/sol-thread.c:470:5: error: expected primary-expression before ‘}’ token
>>> }
>>> ^
>>>
>>> BTW, it's possible to run try builds on specific builders by using the
>>> "-b" option with "buildbot try". E.g.:
>>>
>>> buildbot try -b Solaris11-amd64-m64 -b Solaris11-sparcv9-m64
>>
Thanks.
>> And the actual commit failed with another reason:
>>
>> https://gdb-build.sergiodj.net/builders/Solaris11-amd64-m64/builds/411/steps/compile%20gdb/logs/stdio
>>
>> ../../binutils-gdb/gdb/procfs.c: In function ‘int procfs_notice_thread(procinfo*, procinfo*, void*)’:
>> ../../binutils-gdb/gdb/procfs.c:3136:41: error: ‘is_exited’ was not declared in this scope
>> if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid))
>> ^~~~~~~~~
>> ../../binutils-gdb/gdb/procfs.c:3136:41: note: suggested alternative: ‘inf_exited’
>> if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid))
>> ^~~~~~~~~
>> inf_exited
>
> this is weird: I still see a declaration in gdbthread.h (and also
> is_running and is_stopped), which should go as well.
That's because I meanwhile pushed this:
https://sourceware.org/ml/gdb-patches/2018-11/msg00380.html
So before that we got a link error, and now we get a compile
error, which is expected.
>
> With just the typo above fixed, a local build on amd64-pc-solaris2.11
> has just finished; make check running...
Great, thanks.
Pedro Alves
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Breakage on builder Solaris11-amd64-m64, revision 080363310650c93ad8e93018bcb6760ba5d32d1c
2018-11-23 16:39 ` Pedro Alves
@ 2018-11-25 14:55 ` Rainer Orth
2018-11-26 13:26 ` Pedro Alves
0 siblings, 1 reply; 10+ messages in thread
From: Rainer Orth @ 2018-11-25 14:55 UTC (permalink / raw)
To: Pedro Alves; +Cc: Sergio Durigan Junior, gdb-patches
Hi Pedro,
>>> And the actual commit failed with another reason:
>>>
>>> https://gdb-build.sergiodj.net/builders/Solaris11-amd64-m64/builds/411/steps/compile%20gdb/logs/stdio
>>>
>>> ../../binutils-gdb/gdb/procfs.c: In function ‘int procfs_notice_thread(procinfo*, procinfo*, void*)’:
>>> ../../binutils-gdb/gdb/procfs.c:3136:41: error: ‘is_exited’ was not declared in this scope
>>> if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid))
>>> ^~~~~~~~~
>>> ../../binutils-gdb/gdb/procfs.c:3136:41: note: suggested alternative: ‘inf_exited’
>>> if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid))
>>> ^~~~~~~~~
>>> inf_exited
>>
>> this is weird: I still see a declaration in gdbthread.h (and also
>> is_running and is_stopped), which should go as well.
>
>That's because I meanwhile pushed this:
> https://sourceware.org/ml/gdb-patches/2018-11/msg00380.html
I only saw that commit after I'd sent my mail.
>So before that we got a link error, and now we get a compile
>error, which is expected.
>
>>
>> With just the typo above fixed, a local build on amd64-pc-solaris2.11
>> has just finished; make check running...
It took me a bit to double-check, but the differences in testsuite
results are within the (usual, mostly thread-related) variations.
So the patch is ok with the missing parenthesis added.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Breakage on builder Solaris11-amd64-m64, revision 080363310650c93ad8e93018bcb6760ba5d32d1c
2018-11-25 14:55 ` Rainer Orth
@ 2018-11-26 13:26 ` Pedro Alves
0 siblings, 0 replies; 10+ messages in thread
From: Pedro Alves @ 2018-11-26 13:26 UTC (permalink / raw)
To: Rainer Orth; +Cc: Sergio Durigan Junior, gdb-patches
On 11/25/2018 02:55 PM, Rainer Orth wrote:
> Hi Pedro,
>
>>>> And the actual commit failed with another reason:
>>>>
>>>> https://gdb-build.sergiodj.net/builders/Solaris11-amd64-m64/builds/411/steps/compile%20gdb/logs/stdio
>>>>
>>>> ../../binutils-gdb/gdb/procfs.c: In function ‘int procfs_notice_thread(procinfo*, procinfo*, void*)’:
>>>> ../../binutils-gdb/gdb/procfs.c:3136:41: error: ‘is_exited’ was not declared in this scope
>>>> if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid))
>>>> ^~~~~~~~~
>>>> ../../binutils-gdb/gdb/procfs.c:3136:41: note: suggested alternative: ‘inf_exited’
>>>> if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid))
>>>> ^~~~~~~~~
>>>> inf_exited
>>>
>>> this is weird: I still see a declaration in gdbthread.h (and also
>>> is_running and is_stopped), which should go as well.
>>
>> That's because I meanwhile pushed this:
>> https://sourceware.org/ml/gdb-patches/2018-11/msg00380.html
>
> I only saw that commit after I'd sent my mail.
>
>> So before that we got a link error, and now we get a compile
>> error, which is expected.
>>
>>>
>>> With just the typo above fixed, a local build on amd64-pc-solaris2.11
>>> has just finished; make check running...
>
> It took me a bit to double-check, but the differences in testsuite
> results are within the (usual, mostly thread-related) variations.
>
> So the patch is ok with the missing parenthesis added.
Thanks much. I've merged it now.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-11-26 13:26 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-22 16:39 Oh dear. I regret to inform you that commit 080363310650c93ad8e93018bcb6760ba5d32d1c might be unfortunate gdb-buildbot
2018-11-22 16:39 ` Breakage on builder Solaris11-sparcv9-m64, revision 080363310650c93ad8e93018bcb6760ba5d32d1c gdb-buildbot
2018-11-22 16:49 ` Breakage on builder Solaris11-amd64-m64, " gdb-buildbot
2018-11-23 13:34 ` Pedro Alves
2018-11-23 14:06 ` Sergio Durigan Junior
2018-11-23 14:12 ` Sergio Durigan Junior
2018-11-23 14:16 ` Rainer Orth
2018-11-23 16:39 ` Pedro Alves
2018-11-25 14:55 ` Rainer Orth
2018-11-26 13:26 ` Pedro Alves
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).