From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17529 invoked by alias); 26 Nov 2018 13:26:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17516 invoked by uid 89); 26 Nov 2018 13:26:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Nov 2018 13:26:41 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7BA903082132; Mon, 26 Nov 2018 13:26:40 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id F28F15DD65; Mon, 26 Nov 2018 13:26:35 +0000 (UTC) Subject: Re: Breakage on builder Solaris11-amd64-m64, revision 080363310650c93ad8e93018bcb6760ba5d32d1c To: Rainer Orth References: <96729b3f-3568-1d41-4bb8-fbe4d037da93@redhat.com> <87sgzr6g7x.fsf@redhat.com> <87mupz6fyr.fsf@redhat.com> Cc: Sergio Durigan Junior , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <3df98fe1-3e3e-f250-3039-3525e0feedfe@redhat.com> Date: Mon, 26 Nov 2018 13:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-11/txt/msg00437.txt.bz2 On 11/25/2018 02:55 PM, Rainer Orth wrote: > Hi Pedro, > >>>> And the actual commit failed with another reason: >>>> >>>> https://gdb-build.sergiodj.net/builders/Solaris11-amd64-m64/builds/411/steps/compile%20gdb/logs/stdio >>>> >>>> ../../binutils-gdb/gdb/procfs.c: In function ‘int procfs_notice_thread(procinfo*, procinfo*, void*)’: >>>> ../../binutils-gdb/gdb/procfs.c:3136:41: error: ‘is_exited’ was not declared in this scope >>>> if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid)) >>>> ^~~~~~~~~ >>>> ../../binutils-gdb/gdb/procfs.c:3136:41: note: suggested alternative: ‘inf_exited’ >>>> if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid)) >>>> ^~~~~~~~~ >>>> inf_exited >>> >>> this is weird: I still see a declaration in gdbthread.h (and also >>> is_running and is_stopped), which should go as well. >> >> That's because I meanwhile pushed this: >> https://sourceware.org/ml/gdb-patches/2018-11/msg00380.html > > I only saw that commit after I'd sent my mail. > >> So before that we got a link error, and now we get a compile >> error, which is expected. >> >>> >>> With just the typo above fixed, a local build on amd64-pc-solaris2.11 >>> has just finished; make check running... > > It took me a bit to double-check, but the differences in testsuite > results are within the (usual, mostly thread-related) variations. > > So the patch is ok with the missing parenthesis added. Thanks much. I've merged it now. Thanks, Pedro Alves