From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/7] Allow more Python scalar conversions
Date: Mon, 24 Sep 2018 02:06:00 -0000 [thread overview]
Message-ID: <3e15a979-8e98-578a-542c-6318efb8c579@simark.ca> (raw)
In-Reply-To: <20180915072459.14934-2-tom@tromey.com>
On 2018-09-15 3:24 a.m., Tom Tromey wrote:
> +proc test_float_conversion {} {
> + gdb_test "python print int(gdb.Value(0))" "0"
> + gdb_test "python print int(gdb.Value(0.0))" "0"
> + gdb_test "python print long(gdb.Value(0))" "0"
> + gdb_test "python print long(gdb.Value(0.0))" "0"
> + gdb_test "python print float(gdb.Value(0.0))" "0\\.0"
> + gdb_test "python print float(gdb.Value(0))" "0\\.0"
> +}
This LGTM, but I just wanted to mention that I would probably have tested
with another value than 0. For example, test that the truncation (int(2.3)
which becomes 2) works correctly. Not really a big deal.
Simon
next prev parent reply other threads:[~2018-09-24 2:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 7:25 [PATCH 0/7] some small python fixes (one including a doc patch) Tom Tromey
2018-09-15 7:25 ` [PATCH 1/7] Allow more Python scalar conversions Tom Tromey
2018-09-24 2:06 ` Simon Marchi [this message]
2018-09-24 4:58 ` Tom Tromey
2018-09-15 7:25 ` [PATCH 5/7] Check for negative argument in Type.template_argument Tom Tromey
2018-09-15 7:25 ` [PATCH 7/7] Allow setting a parameter to raise gdb.GdbError Tom Tromey
2018-09-15 9:16 ` Eli Zaretskii
2018-09-24 2:39 ` Simon Marchi
2018-09-24 4:58 ` Tom Tromey
2018-09-24 5:14 ` Tom Tromey
2018-09-24 7:10 ` Eli Zaretskii
2018-09-24 10:24 ` Tom Tromey
2018-09-24 12:39 ` Eli Zaretskii
2018-09-15 7:25 ` [PATCH 6/7] Consolidate gdb.GdbError handling Tom Tromey
2018-09-15 7:25 ` [PATCH 3/7] Allow conversion of pointers to Python int Tom Tromey
2018-09-15 7:25 ` [PATCH 4/7] Report Python errors coming from gdb.post_event Tom Tromey
2018-09-15 7:25 ` [PATCH 2/7] Preserve sign when converting gdb.Value to Python int Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e15a979-8e98-578a-542c-6318efb8c579@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).