From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 81A343858430 for ; Thu, 27 Jan 2022 21:47:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 81A343858430 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 20RLlZ7v021868 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jan 2022 16:47:39 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 20RLlZ7v021868 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id DE7511ECEB; Thu, 27 Jan 2022 16:47:34 -0500 (EST) Message-ID: <3e1b5e78-bf15-bd9b-1349-1be2c8ea70db@polymtl.ca> Date: Thu, 27 Jan 2022 16:47:34 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4] gdb: work around negative DW_AT_data_member_location GCC 11 bug Content-Language: en-US To: Tom Tromey , Simon Marchi via Gdb-patches References: <20220127171520.2138171-1-simon.marchi@polymtl.ca> <50cd832a-984b-7e5c-ba4f-7891f98afbdf@polymtl.ca> <87pmoc52kg.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87pmoc52kg.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 27 Jan 2022 21:47:35 +0000 X-Spam-Status: No, score=-3033.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jan 2022 21:47:41 -0000 On 2022-01-27 15:46, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> On 2022-01-27 12:15, Simon Marchi wrote: >>> New in v3: >>> >>> - change the test source code from an array of chars to an int, to >>> match what is described in the DWARF > > Simon> Actually, the original version here might have been a simple way to make > Simon> the test work even if the target has ints that are not 4 bytes. So I'll > Simon> revert this bit to the original version, but add a comment. > > Simon> Latest version (v4) is below. > > I read this one too and it looks good. Thanks again. > > Tom Thanks, pushed. Simon