public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: gdb-patches@sourceware.org, Andrew Pinski <pinskia@gmail.com>
Subject: Re: [PATCH] Fix regression: cannot start with LD_PRELOAD=libSegFault.so (PR gdb/18653#c7)
Date: Mon, 15 Jan 2018 22:13:00 -0000	[thread overview]
Message-ID: <3e7891c3-6f34-b73a-d206-a4452bef790f@redhat.com> (raw)
In-Reply-To: <87shbk6s51.fsf@linux-m68k.org>

On 01/05/2018 07:07 PM, Andreas Schwab wrote:
> On Dez 15 2017, Pedro Alves <palves@redhat.com> wrote:
> 
>> +	  /* Use raw fprintf here because we're being called in early
>> +	     startup, because GDB's filtered streams are are
>> +	     created.  */
> 
> s/because/before/
> 

Thanks.  Fixed, along with the double "are".

From db422fb2120e311318657d9c7dd0e7b0b5a5eac9 Mon Sep 17 00:00:00 2001
From: Pedro Alves <palves@redhat.com>
Date: Mon, 15 Jan 2018 20:03:20 +0000
Subject: [PATCH] gdb/common/signals-state-save-restore.c: Fix typos

gdb/ChangeLog:
2018-01-15  Pedro Alves  <palves@redhat.com>

	* common/signals-state-save-restore.c
	(save_original_signals_state): Fix typos.
---
 gdb/ChangeLog                           | 5 +++++
 gdb/common/signals-state-save-restore.c | 3 +--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 284245ed8c6..c831a5c30f9 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-01-15  Pedro Alves  <palves@redhat.com>
+
+	* common/signals-state-save-restore.c
+	(save_original_signals_state): Fix typos.
+
 2017-01-12  Tom Tromey  <tom@tromey.com>
 	    Sergio Durigan Junior  <sergiodj@redhat.com>
 
diff --git a/gdb/common/signals-state-save-restore.c b/gdb/common/signals-state-save-restore.c
index eb281dd32b2..5bb66321bbb 100644
--- a/gdb/common/signals-state-save-restore.c
+++ b/gdb/common/signals-state-save-restore.c
@@ -72,8 +72,7 @@ save_original_signals_state (bool quiet)
 	  found_preinstalled = true;
 
 	  /* Use raw fprintf here because we're being called in early
-	     startup, because GDB's filtered streams are are
-	     created.  */
+	     startup, before GDB's filtered streams are created.  */
 	  fprintf (stderr,
 		   _("warning: Found custom handler for signal "
 		     "%d (%s) preinstalled.\n"), i,
-- 
2.14.3

      reply	other threads:[~2018-01-15 22:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15  2:31 Pedro Alves
2018-01-05 18:34 ` Pedro Alves
2018-01-05 19:07 ` Andreas Schwab
2018-01-15 22:13   ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e7891c3-6f34-b73a-d206-a4452bef790f@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pinskia@gmail.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).