public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>,
	Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] [gdb/symtab] Handle empty file name in .debug_line section
Date: Mon, 17 Apr 2023 18:14:32 +0200	[thread overview]
Message-ID: <3e9b298d-6cb9-50fa-b011-ca378874547a@suse.de> (raw)
In-Reply-To: <87o7nm4kwd.fsf@tromey.com>

On 4/17/23 16:56, Tom Tromey wrote:
>>>>>> Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
>> because read_direct_string transforms "" into a nullptr, and we end up
>> dereferencing the nullptr.
> 
>> Note that the behaviour of read_direct_string has been present since repo
>> creation.
> 
>> Fix this in read_formatted_entries, by transforming nullptr filenames in to ""
>> filenames.
> 
> Thanks, this looks good to me.
> 

Thanks for the review.

> I'm curious if an entry of "" even makes sense, but I think the answer
> doesn't affect the validity of this patch.
> 

Ack, I don't know either, but agreed, so committed.

Thanks,
- Tom

> Reviewed-By: Tom Tromey <tom@tromey.com>
> 
> Tom


  reply	other threads:[~2023-04-17 16:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17  9:17 Tom de Vries
2023-04-17 14:56 ` Tom Tromey
2023-04-17 16:14   ` Tom de Vries [this message]
2023-04-17 16:33     ` Tom de Vries
2023-04-17 16:59       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e9b298d-6cb9-50fa-b011-ca378874547a@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).