From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 77F383858C83 for ; Wed, 19 Oct 2022 18:54:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 77F383858C83 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A874A1FA48; Wed, 19 Oct 2022 18:54:25 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 91A7E13345; Wed, 19 Oct 2022 18:54:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2LBEIuFHUGMFMwAAMHmgww (envelope-from ); Wed, 19 Oct 2022 18:54:25 +0000 Message-ID: <3ea58523-bc8d-f055-2d18-37fefec13e3f@suse.de> Date: Wed, 19 Oct 2022 20:54:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 From: Tom de Vries Subject: Re: [PATCH][gdb/testsuite] Handle missing .note.GNU-stack To: gdb-patches@sourceware.org, Luis Machado References: <20221012145323.GA3743@delia.home> Content-Language: en-US In-Reply-To: <20221012145323.GA3743@delia.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2022 18:54:29 -0000 On 10/12/22 16:53, Tom de Vries wrote: > diff --git a/gdb/testsuite/gdb.arch/arm-disp-step.S b/gdb/testsuite/gdb.arch/arm-disp-step.S > index b67e83e56e0..3cfb6063f40 100644 > --- a/gdb/testsuite/gdb.arch/arm-disp-step.S > +++ b/gdb/testsuite/gdb.arch/arm-disp-step.S > @@ -391,3 +391,4 @@ test_add_rn_pc_end: > bx lr > .size test_add_rn_pc, .-test_add_rn_pc > #endif > + .section .note.GNU-stack,"",@progbits Hi, I realize now that this'll probably need to be: ... + .section .note.GNU-stack,"",%progbits ... and the same for the dwarf assembly test-cases when using target arm* See f.i. 9a5911c08be ("gdb/testsuite/gdb.dwarf2: Replace @ with % for ARM compatability.") What I cannot figure out if that holds as well for aarch64 archs: does that one also use %progbits instead of @progbits? Luis, do you happen to know? Thanks, - Tom