From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2051.outbound.protection.outlook.com [40.107.243.51]) by sourceware.org (Postfix) with ESMTPS id 2FF3A3857C66 for ; Tue, 23 Feb 2021 14:33:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2FF3A3857C66 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Eo5Fy03VG6A2G3MuslwaV1OBPBEZcZz0JPiKZQe3fZoteacTm44WwxKg9QVSv15MkcKN3RStUR0byD/jVsS1pjltL4H7h+RMjEwM3Bd3OFfGRb/DNo3fDIsoQx5kLE0bcGBHNLu/QohjRteJuMttheimH6XoYnUN2e5AYoqdcp62LwFmIMhhNNvIMN0YtWqmzzqycPVosd2Z69ieKVxcMH+JB9U/Ovvy4YZMQWGtaFdG1c747OLf/s1SaqjXz6BSgDhkgHNALoR+7RNWIEs0Tjq3wWo0BNvrQxZ3A5A6LVYvcd5vVL6dHPRFwsog6BbiUAqdTyDZy4urpdqqADDujw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XORcPsCDaLqBaazAX6IgCVapFA0dFla/w7E0tWZDxt0=; b=ZWsT8n6TDLOOLvRbfWztC/SRDY3ip82ku/Gxv/mfr9yRS+9OVJXAgy18m8virItZpWkRPCXZVADDrMvH5N14mkOY7+HJLAjidfkkh7e4XIbdyBJbynPd/HVt6NVEMLwUV1oRdKMtB/355l2UurkHqR0Xdv+QOVlSZnroFnPpgv7Tua0qxDVqz/ipRMPcCGsS51cxjdzmz+P7MYll4L/uhOJjK6RDVLWMp3q/BZ1zOL8ocpnRVyRqWPslEtEKrnb7hbjQKIg9iN551IMWTIPREfbFdJznLHHbKN/XUC1ecRwwLy0uyatn0X3BooPzGcFixqM+7aXxQxvzf/LK6c352w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM6PR12MB2905.namprd12.prod.outlook.com (2603:10b6:5:181::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.33; Tue, 23 Feb 2021 14:33:24 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44%3]) with mapi id 15.20.3868.033; Tue, 23 Feb 2021 14:33:24 +0000 Subject: Re: [PATCH 06/30] Move get_object_address to dwarf_expr_context To: Tom Tromey , Zoran Zaric via Gdb-patches References: <20201207190031.13341-1-Zoran.Zaric@amd.com> <20201207190031.13341-7-Zoran.Zaric@amd.com> <87pn1yq8mq.fsf@tromey.com> From: Zoran Zaric Message-ID: <3ebcefaf-98a4-de23-8b71-909662b5c082@amd.com> Date: Tue, 23 Feb 2021 14:33:19 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <87pn1yq8mq.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2a00:23c7:5a85:6801:3c68:1988:3c97:9289] X-ClientProxiedBy: LO2P265CA0467.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::23) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a00:23c7:5a85:6801:3c68:1988:3c97:9289] (2a00:23c7:5a85:6801:3c68:1988:3c97:9289) by LO2P265CA0467.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.32 via Frontend Transport; Tue, 23 Feb 2021 14:33:23 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 20358791-4b8e-4beb-428f-08d8d807f9f3 X-MS-TrafficTypeDiagnostic: DM6PR12MB2905: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zorVSBdtwCOoA00EKb655Ix0HjSGaqE/ReJgov1uGP4HVl0KaUcIHxxiRc6jpXTcBgUxB4hYS8bra+Lodp88nizp2rb2PJf789b4Ce4S8CAsNlBTfytBRWBt7hBDqN/L8cCCudcKO55W5+CQP2g2OZldDClSX1pp8a6SmMUAc2Yo/+GZIVOJ2CYsZQmRUFhDMi84c+8bVBydH444XsMreMsUAm2ZPxjxQgIDzdSahoPzBjEhqXHhcnK98m3jJsAUkwb+MbLWO2/4C1iUPQMPCLre6ys2FwYm4BtbFubMPAReNOzqBynzRDO6xpWPusaD9sBlFjCFeNX1F4u8v3v5nuqwC8UCxgjuuD8syfTtXPL7+wC+jHa3FgVrVdSwJsM7A7uHuFUnwVELI3/F5ENO0DpJJG0RG6zwhlFKfnPXcwclLH/guIv4ymDsEUz2WPGFZfAAhD9/X9GlKg+XlU3wvwMTsFUk4IxEECXJdc0lp/cZC7W1h/QHpcBU0ZpIskGVxbhTCUnTdIGoJxNwvsWG6pmQhWcq5Oejt8T4RlV1ZZ75ZqOSM0tvt9m532Ou3mxxjDdZQrKqS6Sgiq3smSmW1wOavknfGLJEdIXlElFL3tg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(346002)(366004)(136003)(396003)(376002)(478600001)(2906002)(66946007)(2616005)(186003)(16526019)(6486002)(66556008)(66476007)(36756003)(52116002)(316002)(110136005)(31696002)(8936002)(31686004)(8676002)(5660300002)(6666004)(4744005)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?clRHWkpHcGlJaHZDUGRTblFaRmVSKzZqTXg2NEcvd3hKQk45SG9wMzdPcUVC?= =?utf-8?B?d2tiY3c2djMrV2dUYlhxRnBGUkZzajBSSUxtczlkUFRDVVBUUTU1NmJMc3Ev?= =?utf-8?B?YjVVT0ZQakpBc2E2SUpYazhkYldsNWRFcVBJZ3FVQnRUa0hKa1pMVk41TGJr?= =?utf-8?B?N0lsNjVoWkc4QzVYTkZWQlZTSlR2WGtZdFF1VUJZazltcFY3MHJnUElZY1dy?= =?utf-8?B?WEFaV25WQzhYcWc4dFgwN0tqSXpOWXdzYWRyZUZ0RWgyZzhJVnJDS2lJL2dr?= =?utf-8?B?emdnMmhTMnk2S3dESDhpbVU5TmYyVHovNnB6R2NCNXdKRWFpditCbTlGbFNr?= =?utf-8?B?eFdIZEtKU09jK3dvTXB1OUhwTWRJb1dSSVVUTFBYQWhqVmdoaDNnRFJMT05T?= =?utf-8?B?akdVazluQlNuUXZndjNyaGQ5cVd5M0ZwdUtjR1YzclVpMG1CUURQVXZ6MDdy?= =?utf-8?B?NWhlbzRMb2paQVhjMnpLL3N3U0dnZFFEVWk0aDFDbWIxTEVnT0NwY0ZJclM1?= =?utf-8?B?WkZTWWVOWlBCMk1NZDNBbW1xVGZRMldwUFNRck1GQmMyemNKaDd6NHV2SnJW?= =?utf-8?B?cjVkOHFqOGsyQXA2MEVBb0h3Y2pnMVJKS0tEaVlaOGVxYy9NMVFacnR2MlBq?= =?utf-8?B?WndpTDFiM1BqVHp0YlNkcUYwUTlrbk1JeXFjNlh4ZVlObTYwd1FFNGdDbCt4?= =?utf-8?B?MS8vMmNuWlhQaUM0cDNUR3A4WmE1Qy9Fais0dldQZ0ZXS1VoZXc5VkR4RUtS?= =?utf-8?B?T2hLc2ZOVUVzYVV1a3RsQThWNW1JNHJBSnJKSjZxbWZodFU3cmZZSVpvSGoy?= =?utf-8?B?azB2d2VVUG9aRHhEYTN4dyt4ZUNuZmZVa3lIQkhtUzZXN0pOSG5kUzg3cW8r?= =?utf-8?B?aUk0MU0wWGM0a2dFZnJRWngyeXVxSlpwQy81SGNqbUh6YmdxR2hoN05DQ0pT?= =?utf-8?B?SFMxOWUraFBmb0tacXZWbTV5dTVVVWY0TnV3alhnNnlvZWtVNjBjN3ZxYkhY?= =?utf-8?B?SXVlK3FVL1hoT3pFelU3Uk4xZmNxdXljemFQWGF0MW5uWEtRQVNma0xLUndD?= =?utf-8?B?NWtVWG03Zno5RDhudU1QQTF4M0N2bEcyU09OclMvRHEwbEdtZkE5RnJyYlVi?= =?utf-8?B?OTdwd2xpaGZzWXdOQWxxZVBaakZPUjdZQWxndzNOMXdyODhXbW1CNGlIRGov?= =?utf-8?B?d0tlUHhFcHZDY3hxaGc5NXVKQlB3MVNBMno1bkVaSUpqMEVFc0JKR3VEQ3Zx?= =?utf-8?B?VmtBc0FjODE0bnVqR2Q0RzMrNFluQWxNZ2ExVDBvSGt6Z0xidTB1aVpXRXND?= =?utf-8?B?VEQySzVtOTQwWGV2K1BvTXFNeUl1YnhGRCt6Rk5GbmJlSTZicmxtYUwxQXpF?= =?utf-8?B?a3lsWXd5OWp1NGcxdG1kTjBlNEw5MnFiTEJTc1RBbDBuZ29ibWFVYkJrOEN4?= =?utf-8?B?OGVGYU55YnRVL1FwWW5sR0JpUHRZaU1jc2JONDZTNTZ3SlUreFU2Z1NVS0Qw?= =?utf-8?B?cXB5cU9qY2NRV0E4eld3YlhrcU9YRW9EenVOQ0ZiTzNvSE9Sd3NQNTRjcWhm?= =?utf-8?B?c2J3V1p1MlZyRWdUZEl0aHVhMWFNbW9GMlhqbmEvY0hwa3A5cCt0N0swWVIw?= =?utf-8?B?OXZ0cHg3N3NjeUprN0ovU0lyY0xnbjFCcFEzSW1ROFdlbWZxbWVieVE0Rm1V?= =?utf-8?B?ZGM1ZlcxL3FyTCt5QUVUMENkc1RjNWFVYktJd2xUbHphVVhqbGNVOTdTZVcr?= =?utf-8?B?MHp2VTdYOUFMNEZ5Y0d3eXZCTVhTVCttVXU5YmljZTV5Q081YllXdFNjVFAr?= =?utf-8?B?cERmWk1JL3JzNW1SRXN6ZitUV1BBSVprR0hSNDR0a25Oc1E3NDdCS1lCek55?= =?utf-8?Q?ONz+QovEULpEc?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20358791-4b8e-4beb-428f-08d8d807f9f3 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2021 14:33:24.5893 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bWrJ5/4FilIq3l0u/lnCS0CxgIoxjG6uDKIxH4wpHUdTtF6kEASJXXO9d0UKww/OfpSvYsBEv6IpZf8LjkuFew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2905 X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Feb 2021 14:33:30 -0000 > > Zoran> + per_cu (nullptr), > Zoran> + obj_address (0) > > Another thing I forgot earlier is that gdb is usually using inline > initialization for things like this. > > Zoran> + /* Object address used for the evaluation. */ > Zoran> + CORE_ADDR obj_address; > > ... so this could just be " = 0". > This could be applied in the other patches as well. > > Otherwise this looks good to me. > > Tom > Will be fixed in the next patch set version. Zoran