Re: [PATCH v2 2/2] gdb/dwarf2: fix "info locals" for clang-compiled inlined functions

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2021-04-14 4:14 a.m., Tankut Baris Aktemur wrote:
> diff --git a/gdb/testsuite/gdb.dwarf2/dw2-inline-with-lexical-scope.exp b/gdb/testsuite/gdb.dwarf2/dw2-inline-with-lexical-scope.exp
> new file mode 100644
> index 00000000000..e815c859639
> --- /dev/null
> +++ b/gdb/testsuite/gdb.dwarf2/dw2-inline-with-lexical-scope.exp
> @@ -0,0 +1,137 @@
> +# Copyright 2021 Free Software Foundation, Inc.
> +
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +
> +# Test that scoped local variables in an inlined function are printed
> +# properly.
> +
> +load_lib dwarf.exp
> +
> +# This test can only be run on targets that support DWARF-2 and use
> +# gas.
> +if {![dwarf2_support]} {
> +    return 0
> +}
> +
> +standard_testfile .c .S
> +
> +# Make some DWARF for the test.  The concrete inlined instance
> +# (i.e. the DW_TAG_inlined_subroutine) has a DW_TAG_lexical_block that
> +# does not contain a DW_AT_abstract_origin attribute.  This is
> +# deliberate.  Bad GDB printed duplicate local variables with
> +# "optimized out" values in this case.
> +
> +set asm_file [standard_output_file $srcfile2]
> +Dwarf::assemble $asm_file {
> +    global srcfile srcdir subdir
> +    declare_labels int_label func_label num_label value_label lines_label
> +
> +    get_func_info main
> +    set func_call [gdb_get_line_number "func call"]
> +
> +    cu {} {
> +	compile_unit {
> +	    {language @DW_LANG_C99}
> +	    {name $srcfile}
> +	    {low_pc $main_start addr}
> +	    {high_pc "$main_start + $main_len" addr}
> +	    {stmt_list ${lines_label} DW_FORM_sec_offset}
> +	} {
> +	    int_label: base_type {
> +                {name "int"}
> +                {byte_size 4 sdata}
> +		{encoding @DW_ATE_signed}
> +            }
> +
> +	    func_label: subprogram {
> +		{name func}
> +		{inline 3 data1}

You could maybe use

  {inline @DW_INL_declared_inlined}

here.  The form will be sdata instead of data1, but I don't think that's
a problem.

Otherwise, LGTM, thanks!

Simon