Re: [PATCH v4 2/3] gdb: Add per-remote target variables for memory read and write config

[Pedro Alves <pedro@palves.net>]

On 2022-12-21 1:39 p.m., Christina Schimpe wrote:

> +/* User configurable variables for the number of characters in a
> +   memory read/write packet.  MIN (rsa->remote_packet_size,
> +   rsa->sizeof_g_packet) is the default.  Some targets need smaller
> +   values (fifo overruns, et.al.) and some users need larger values
> +   (speed up transfers).  The variables ``preferred_*'' (the user
> +   request), ``current_*'' (what was actually set) and ``forced_*''
> +   (Positive - a soft limit, negative - a hard limit).  */
> +
> +struct memory_packet_config
> +{
> +  const char *name;
> +  long size;
> +  int fixed_p;
> +};

It seems like this struct would better be split in two like in patch #1, as
we don't really need to store a name per remote connection, as it'll always
be the same for all connections.

However, I don't want to block your patch further, so I'm OK with merging as is.

> @@ -2037,31 +2057,49 @@ set_memory_packet_size (const char *args, struct memory_packet_config *config)

...

>    /* Update the config.  */
>    config->fixed_p = fixed_p;
>    config->size = size;
> +
> +  const char* target_type = get_target_type_name (target_connected);

Formatting:

  "const char *target_type"

> +  gdb_printf (_("The %s %s is set to \"%s\".\n"), config->name, target_type,
> +	      args);
> +
>  }
>  
> +/* Show the memory-read or write-packet size configuration CONFIG of the
> +   target REMOTE.  If REMOTE is nullptr, the default configuration for future
> +   remote targets should be passed in CONFIG.  */
> +
>  static void
> -show_memory_packet_size (struct memory_packet_config *config)
> +show_memory_packet_size (memory_packet_config *config, remote_target *remote)
>  {
> +  const char* target_type = get_target_type_name (remote != nullptr);

Ditto.

OK with the formatting nits fixed.

Pedro Alves