Re: [PATCH v5 0/7] Support for recording some AVX instructions

[Guinevere Larsen <guinevere@redhat.com>]

On 10/25/24 12:46 PM, Tom Tromey wrote:
>>>>>> "Guinevere" == Guinevere Larsen <guinevere@redhat.com> writes:
> Guinevere> The first patch of the series makes GDB aware that it can read pseudo
> Guinevere> registers freom executing and replaying threads, no user-visible
> Guinevere> changes expected. The second adds the capability for the main i386 record
> Guinevere> function to identify and read VEX prefixes, but doesn't add support for
> Guinevere> any instruction yet, so minimal user visible changes (only a slight
> Guinevere> tweak to an error message). The remaining patches add support to related
> Guinevere> instruction, and tests those instructions.
>
> FWIW these look fine to me.
> I didn't really review the target-dependent parts in detail, like I
> didn't look up instruction encodings or anything like that.
>
> Approved-By: Tom Tromey <tom@tromey.com>

Thanks for the review!

I've pushed this! If there is something I missed related to the 
target-specific parts, the test should let us find it easily and figure 
out what's up.

-- 
Cheers,
Guinevere Larsen
She/Her/Hers

>
> Tom
>