From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailsec215.isp.belgacom.be (mailsec215.isp.belgacom.be [195.238.22.111]) by sourceware.org (Postfix) with ESMTPS id CBDA43858C5E for ; Sun, 27 Nov 2022 20:19:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CBDA43858C5E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=skynet.be Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=skynet.be DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=rmail; t=1669580391; x=1701116391; h=message-id:subject:from:to:date:in-reply-to:references: mime-version:content-transfer-encoding; bh=VciKkzum0zKAjRjch7X9DPQbDBgE7N7U/mqzLz6OPpA=; b=mDQ5KB5eQbdBCoOVWrZrNovZB73fEE3RAqsdDPmJcAVJ3RyUXZ7X7zIL JrLQjsvvMlfKRwu4m7eB7hZSvbvda8Qlsef2lHJQc1R2GHMxnSFVY5msb h1bTJveO+OUm+vqoPlZj5lcCa9N7AOn6nzo1HjUuiBFjfZ/yeQUoEkIUa g=; X-ExtLoop: 1 X-IPAS-Result: =?us-ascii?q?A2BlAQCYxYNj/1uGgG0NTYEJCYFGhQmETpEenTSBfg8BA?= =?us-ascii?q?QEBAQEBAQEJRAQBAYUFAoUIJjYHDgECBAEBAQEDAgMBAQEBAQEDAQEGAQEBA?= =?us-ascii?q?QEBBgQBgRyFL4J7IoN9AQEBAyNmCw4KAgImAgJXBgESsxx6gTKBAYRxmmWBZ?= =?us-ascii?q?4EULIkGg2CEMDeBVUSEDzA+iBuCZwSYQRw3AxkrHUADC20KRRtYDgkfHA4XD?= =?us-ascii?q?QUGEgMgbAUKNw8oL2QrHBsHgQwqKBUDBAQDAgYTAyICDSkxFAQpEw0rJ28JA?= =?us-ascii?q?gMiZQUDAwQoLAMJIR8HFhEkPAdWOgEEAwIPIDgGAwkDAiJUcy4RFQUDCxUlC?= =?us-ascii?q?AVLBAg5BQZSEgIKEQMSDwYmRQ5IPjkWBidzDg4TA12BaQQ1gXEKYJlrg34oE?= =?us-ascii?q?xSCKz2SQY5igTOCYZx8NAeDbIFJBgyefDKpGZc3IKdYgWkJggVtgzpSKJxxd?= =?us-ascii?q?DsCBwsBAQMJh0gtgioBAQ?= IronPort-PHdr: A9a23:a5UEqx9K5jCCif9uWVK7ngc9DxPPW53KNwIYoqAql6hJOvz6uci4Y AqAvb401wKBHd2Cra4e0KyO6+GocFdDyK7JiGoFfp1IWk1NouQttCtkPvS4D1bmJuXhdS0wE ZcKflZk+3amLRodQ56mNBXdrXKo8DEdBAj0OxZrKeTpAI7SiNm82/yv95HJbAhEmjWwbalwI Rmqogndq8cbjIt/Iao11hfFv2FEdutIyW5mP16fgwrw6sKt95N/7ipcvO4s+dRdWqvgZaQ4S rJYDDUiM28r4cDgqAfOQwiS6HYCS2saihVHDRTL4xH8RZfxrzD1tvFh1ymAPM35Vq47VDK/5 Kp2UhDoiSMHNzkk8GHLj8F7kaxWrA69qxF53oXZZpyeOvhjcaPHZd4URndPUMZPWSJPAIy8Y ZcAAOQOMuhXtIT9u1kDoAGiCQWwHu7iyDlFjWL2060g1OQhFBnL0hYgH9IPtHTUrc31NL8MX uuozKbH1y/Db/RP2Tfg6YjHbAohoeqRVr93acrRyUgvFwfEjlWIsYzqISmZ1+oXvGiB6OpgT P+vi285pAFruTii3dwsiorJh4IT1F/E6T91z50rKtChTkNwfNGrHodKuS6AK4t2Xt0tQ3tuu Csi1LEKp522cTQFxZg72xLSafyKfoeV7xzjSOqcLjh2inJ4db+xgxu/70aux/PyW8S301tHo CtIn9nCu30C0xHe686KQeZ+8Ee5wTuDyhzf5+VeLUwpi6bWKIQtzqM+m5ccq0jOGjL6lUPrh 6GMbEok4PKn6+H/b7XjoZ+TKpF7hxnlMqQrhsy/GeM4MhUSX2SD+eSzyrnj/UrhTbpOk/E7l rfVvIrHKckapaO1GRJZ3pw+5xu7CTiqyNUYnX8ZI1JZYB+LkpTlNlXULPzlE/uygE6gnCply v3JJLHsBojBImDGkLj7fLZ970BcyBA0zdBa/59UErEBIPP3Wk/wrNzYFgE2Pxa6wun9EtV90 ZoeWX+OAqCHKqPSqkSF5vksI+iMYo8apir9J+I+6PHwlXM5n0QScrGz3ZQLcHC4AuhmI0KBb HbymtsBC3sFvhIiTOz2j12PSSVTZ3e3X60m/DE7C5mrDZzCRoComrOBxiS7EodKaW9cElyMC 2vnd52YW/cQbyKfOsBhnSEfWrS4U48uzw2uuxP6y7V5NerZ4TYYtZX+1Nhv++Lcix8z+iZuD 8uDyW2NSHt0nmxbDwMxiZt+pEt7gnKKy6N4grQMDt1W7ulKehw7MJfGzKpxAoa2Eg3NdJKRQ UqtQti9KSo2U8g6zsAHeUs7HM+t3T7Z2C//O78Uk72THJF8zavG2GHsJstn0D6SzKkgi1g+W sYJKmS8gbdi9gXJHKbSkFSfmrrsf6lKj32Fz3uK0Wfb5BIQawV3S6iQBRgi IronPort-Data: A9a23:5oGEMagfoiPRfXiooMj7/rUCX161BBEKZh0ujC45NGQN5FlHY01je htvUGyPOfrZa2KjKd5ya4jl8B5Tvcfcmt5hSVE/qyBgHytjpJueD7x1DKtQ0wB+jyHnZBg6h ynLQoCYdKjYdleF+lH3dOGJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kobVuKYx6TSCK17L6 I2aT/H3Ygf/gWctaD1MsspvlTs21BjMkGJA1rABTa0T1LPuvyF9JI4SI6i3M0z5TuF8dgJtb 7+epF0R1jqxEyYFUrtJoJ6iGqE5auK60Ty1t5Zjc/PKbi6uCcAF+v1T2PI0MS+7gtgS9jx74 I0lWZeYEW/FMkBQ8QgQe0EwLs1wAUFJ0J7ZK1exg8fK9EbLcEvLwd5zDU0wYKRNr46bAUkWn RAZAANUP0rF3rzmhuv9E7hZ7ighBJCzbcVG4CEmlGqFS6d/KXzAa/yiCdtwxDcxgsFWBfuYe MMDbiNybRnaeDVUOUYRBY54lurAanzXKG0C8AnF+fJfD277kxRfwZ/yKNHuINmWWMUSz0rIg jybxjGsav0dHJnFodafyVq3h+rGhyDTQ4MXHae7sPVj6HWcymZWEBQKXlu2utGijVOkUN9AI lYZvC00osAPGFeDH4C7Bkbk5Sfe7ltFA4sWGuEh7ESB26yS4h2BQGIJSjFIY9sj8sU7LdA36 mK0cxrSLWQHmNWopbi1r994cRva1eMpwaPuqMPKocbpIzUunW3rsi/ycw== IronPort-HdrOrdr: A9a23:eOIt6KCS1L9bcczlHemc55DYdb4zR+YMi2TDDHoBKyC9F/by/f xG885rsSMc9wxhP03I9ervBED4ex7hHP1OkOos1NWZLWzbUQKTRelfBO3ZogEIcBefygcy78 hdmqFFebvNJGk/s8rw+g+8DNpl4PTvysyVuds= X-IronPort-Anti-Spam-Filtered: true Received: from 91.134-128-109.adsl-dyn.isp.belgacom.be (HELO [192.168.1.19]) ([109.128.134.91]) by relay.proximus.be with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2022 21:19:50 +0100 Message-ID: <3f4173f8bcf5256f8a549d99858e5f1f916693f1.camel@skynet.be> Subject: Re: [RFA] Fix leak in the dwarf reader From: Philippe Waroquiers To: Simon Marchi , gdb-patches@sourceware.org Date: Sun, 27 Nov 2022 21:19:48 +0100 In-Reply-To: <11aac52f-27ef-c1d8-1d22-e538bdb8e687@simark.ca> References: <20221127125413.2769629-1-philippe.waroquiers@skynet.be> <11aac52f-27ef-c1d8-1d22-e538bdb8e687@simark.ca> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 2022-11-27 at 13:48 -0500, Simon Marchi wrote: > > On 11/27/22 07:54, Philippe Waroquiers via Gdb-patches wrote: > > Valgrind reports a leak in the dwarf reader (see details below). > > The function dw2_get_file_names_reader is interning in the per_objfile > > all the file names it finds, except the name of 'fnd file name and directory'. > > Instead, it was xstrdup-ing the name. > > Fix the leaks by also interning the name. > > > > This was validated running the tests natively, and under valgrind. > > Leaks have decreased as mentionned below. > > Valgrind detected no error such as double free or use after free. > > I manually checked the uses of this field, it indeed doesn't appear to > be freed, so:` > > Approved-By: Simon Marchi Thanks for the review, pushed with the approved tag.