From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id EA0AE3858C66 for ; Thu, 12 Jan 2023 17:49:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EA0AE3858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 495AC1E0D3; Thu, 12 Jan 2023 12:49:20 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1673545760; bh=PrzHtJCsdYzt0ZqVdL/eVptqGOCIYLqh4uYkUirmb7I=; h=Date:Subject:To:References:From:In-Reply-To:From; b=PfsrxaDRWa5n2lb5QoUZ4JYNuGnXKzECd0FxguK1V5r6g3ArtcWVnmjcSjjSDYOxk 4YQIRBqycgiJihaaHJH/LWYEVJk/cnxUw32SvxKL/FShnATpG2ZGSUxeltvmn44ZOb tTmYQC83voUw+ASrT3hPyXDNJ2FiPPloNIms55M8= Message-ID: <3f6597da-f101-b413-f48b-2f66b77e840c@simark.ca> Date: Thu, 12 Jan 2023 12:49:19 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 3/3] Let Python breakpoints be created silently Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20221208191804.3819129-1-tromey@adacore.com> <20221208191804.3819129-4-tromey@adacore.com> From: Simon Marchi In-Reply-To: <20221208191804.3819129-4-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > @@ -5940,9 +5940,15 @@ the function passed in @code{spec} as a fully-qualified name. It is equivalent > to @code{break}'s @code{-qualified} flag (@pxref{Linespec Locations} and > @ref{Explicit Locations}). > > +The optional @var{announce} argument is a boolean that controls > +whether @var{GDBN} announces the existence of the breakpoint. The > +default is to announce, meaning that a message is printed. Setting > +this argument to false will suppress all output from breakpoint > +creation. I assume this means "all CLI output", but any MI / DAP frontend would still be notified? Otherwise, the code LGTM. Simon