public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom de Vries <tdevries@suse.de>
Cc: Gary Benson <gbenson@redhat.com>,
	gdb-patches@sourceware.org,
	       Pedro Alves <palves@redhat.com>
Subject: Re: Upper case test names
Date: Wed, 17 Oct 2018 12:07:00 -0000	[thread overview]
Message-ID: <3fcc0352796fb53a7d4e5ed06f62aca5@polymtl.ca> (raw)
In-Reply-To: <eaadaf9d-2405-9549-d462-3f7b1f135d7c@suse.de>

On 2018-10-17 03:30, Tom de Vries wrote:
> [ was: Re: [PATCH][gdb/testsuite] Rewrite catch-follow-exec.exp ]
> 
> On 10/16/18 12:11 AM, Simon Marchi wrote:
>> Please use a lower case letter for the test name.
> 
> Hmm, that happens more often, appearantly:
> ...
> find gdb/testsuite/ -type f -name "*.exp" | grep -v /lib/ | xargs egrep
> $'[\t ](fail|pass|unsupported|untested|xfail|kfail) "[A-Z][a-z]' | 
> egrep
> -v 'PowerPC|Rust'
> gdb/testsuite/gdb.ada/bp_inlined_func.exp:   fail "Cannot run to main,
> testcase aborted"
> gdb/testsuite/gdb.ada/excep_handle.exp:   fail "Cannot run to main,
> testcase aborted"
> gdb/testsuite/gdb.ada/mi_string_access.exp:   fail "Cannot run to main,
> testcase aborted"
> gdb/testsuite/gdb.ada/mi_var_union.exp:   fail "Cannot run to main,
> testcase aborted"
> gdb/testsuite/gdb.arch/arc-analyze-prologue.exp:    fail "Can't run to 
> main"
> gdb/testsuite/gdb.arch/arc-decode-insn.exp:    fail "Can't run to main"
> gdb/testsuite/gdb.base/readnever.exp:    untested "Couldn't compile
> ${srcfile}"
> gdb/testsuite/gdb.fortran/printing-types.exp:    untested "Could not 
> run
> to breakpoint MAIN__"
> gdb/testsuite/gdb.guile/scm-lazy-string.exp:    fail "Can't run to 
> main"
> ...
> 
> Does this need fixing?

Sure, it would need fixing, if you want to take the time to do it.  
Here's the reference in our wiki where that rule is stated, for 
reference.

https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Follow_the_test_name_convention

Thanks,

Simon

  reply	other threads:[~2018-10-17 12:07 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05 10:11 [PATCH][gdb/testsuite] Rewrite catch-follow-exec.exp Tom de Vries
2018-10-09 13:52 ` Gary Benson
2018-10-09 16:40   ` Tom de Vries
2018-10-10  9:28     ` Gary Benson
2018-10-10 13:29       ` Simon Marchi
2018-10-10 13:44         ` Gary Benson
2018-10-11  7:47           ` Tom de Vries
2018-10-11  8:33             ` Gary Benson
2018-10-13 22:18               ` Simon Marchi
2018-10-15 19:54                 ` Tom de Vries
2018-10-15 22:12                   ` Simon Marchi
2018-10-23 21:04                   ` Simon Marchi
2018-10-23 21:05                     ` Tom de Vries
2018-10-23 22:38                       ` Tom de Vries
2018-10-23 23:37                         ` Simon Marchi
2018-10-24 11:47                           ` Tom de Vries
2018-10-24 12:09                             ` [PATCH][gdb/testsuite] Log wait status on process no longer exists error Tom de Vries
2018-10-24 14:05                               ` Simon Marchi
2018-12-05 19:35                               ` Pedro Franco de Carvalho
2018-10-15 22:12             ` [PATCH][gdb/testsuite] Rewrite catch-follow-exec.exp Simon Marchi
2018-10-16 16:11               ` Tom de Vries
2018-10-16 17:07               ` Tom de Vries
2018-10-16 20:12                 ` Simon Marchi
2018-10-17  7:30               ` Upper case test names Tom de Vries
2018-10-17 12:07                 ` Simon Marchi [this message]
2018-10-18 12:56                   ` Tom de Vries
2018-10-18 13:05                     ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3fcc0352796fb53a7d4e5ed06f62aca5@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).