From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28553 invoked by alias); 17 Oct 2018 12:07:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28517 invoked by uid 89); 17 Oct 2018 12:07:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Oct 2018 12:07:34 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w9HC7RaX002382 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 17 Oct 2018 08:07:32 -0400 Received: by simark.ca (Postfix, from userid 112) id 8B2D81EA70; Wed, 17 Oct 2018 08:07:27 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 8B0EE1E514; Wed, 17 Oct 2018 08:07:24 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 17 Oct 2018 12:07:00 -0000 From: Simon Marchi To: Tom de Vries Cc: Gary Benson , gdb-patches@sourceware.org, Pedro Alves Subject: Re: Upper case test names In-Reply-To: References: <20181005101122.GA23867@delia> <20181009135155.GB12668@blade.nx> <8f8ffb94-5a0c-8b2b-d541-eaacd7d1f42c@suse.de> <20181010092735.GA29557@blade.nx> <20181010134423.GA23926@blade.nx> <20181011074744.GA7677@delia> <750f69f3ea27d2ca530c896eef51e9eb@polymtl.ca> Message-ID: <3fcc0352796fb53a7d4e5ed06f62aca5@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00364.txt.bz2 On 2018-10-17 03:30, Tom de Vries wrote: > [ was: Re: [PATCH][gdb/testsuite] Rewrite catch-follow-exec.exp ] > > On 10/16/18 12:11 AM, Simon Marchi wrote: >> Please use a lower case letter for the test name. > > Hmm, that happens more often, appearantly: > ... > find gdb/testsuite/ -type f -name "*.exp" | grep -v /lib/ | xargs egrep > $'[\t ](fail|pass|unsupported|untested|xfail|kfail) "[A-Z][a-z]' | > egrep > -v 'PowerPC|Rust' > gdb/testsuite/gdb.ada/bp_inlined_func.exp: fail "Cannot run to main, > testcase aborted" > gdb/testsuite/gdb.ada/excep_handle.exp: fail "Cannot run to main, > testcase aborted" > gdb/testsuite/gdb.ada/mi_string_access.exp: fail "Cannot run to main, > testcase aborted" > gdb/testsuite/gdb.ada/mi_var_union.exp: fail "Cannot run to main, > testcase aborted" > gdb/testsuite/gdb.arch/arc-analyze-prologue.exp: fail "Can't run to > main" > gdb/testsuite/gdb.arch/arc-decode-insn.exp: fail "Can't run to main" > gdb/testsuite/gdb.base/readnever.exp: untested "Couldn't compile > ${srcfile}" > gdb/testsuite/gdb.fortran/printing-types.exp: untested "Could not > run > to breakpoint MAIN__" > gdb/testsuite/gdb.guile/scm-lazy-string.exp: fail "Can't run to > main" > ... > > Does this need fixing? Sure, it would need fixing, if you want to take the time to do it. Here's the reference in our wiki where that rule is stated, for reference. https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Follow_the_test_name_convention Thanks, Simon