From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E1A4F3858D20 for ; Wed, 17 Apr 2024 19:20:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E1A4F3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E1A4F3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713381621; cv=none; b=qFWMopOQQD1Ejg9qBCY+aXaB0/IgA0tVi0wK/hEEGPcvz0WsaZinnyuz1RLTwkcEFLmgQ29MLti/mV7RmFAPbmyLaTavXQlaIkh+cfDa5wrlAuU0KYPjXv1gUub98xqidCrUChJ1EID1uLxexvfg+9OObi2DabbZx9TMc8i6BO8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713381621; c=relaxed/simple; bh=MEaOt4i1xRhWEBTydtLGrRhRbiPtVu6etKIZWOkVFHA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=YNYC/Kvgh7soh7iRHEPVdtHBBH6ugEMwEdS9KiCrx7uafLhcj8kWKfp3zTqPC/fxnTYF7TnN6xMlCpNfn58eycs9aT7nABuFvwf5ZfOiCFwkBT7l/i8D/lh1NCz/OUVSipxP6CPoc03v0Mq7kY13ZNE28nbjfcJU3duncEpkx1I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713381614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V4Py/3bgNPtH5OCeoSkneP+bF7s5MHI8MiHrdc7QTCg=; b=cUrHkkJAryGq6pnoHyNv3HDzIV91cWtvAacpZiZjRJNrD+IUaMBvivB8jS+VZqk1OTpN5B sBXqk9KJUjq/XPGIptRItL6UIaDdkbvkVMIK3RJjfhAfowIv+gTWh+2oPmySDPjAw2mepl j8c+ziYi/SJHFc+wJnbnNDfmfJSIPaY= Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-404-i5sGH82WMCe30NZJMkPcaw-1; Wed, 17 Apr 2024 15:20:13 -0400 X-MC-Unique: i5sGH82WMCe30NZJMkPcaw-1 Received: by mail-oi1-f197.google.com with SMTP id 5614622812f47-3c60bf6b8d5so189289b6e.0 for ; Wed, 17 Apr 2024 12:20:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713381612; x=1713986412; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V4Py/3bgNPtH5OCeoSkneP+bF7s5MHI8MiHrdc7QTCg=; b=q6ZJy+6hMS6f0xCYUsVhpxqtMJh7E8yoF+qv5MWbzENXQkfwT0FyWW4abrMYeMOsc+ K5+So5NYSmf0sgTJXu+aVoOpVBpTX5Uoj1TkjNx8ih2NIIHkQDE5DTH8Hu1gnG7c8iE0 KBHqIn63iGNcV6j1e7JbTiqyoHjTzzVt5uL1R6Lz2nVDk2Vq6tt5JgRtPp/qo6AkuZak iwMiig3QiIrN0uX6YYAYjfvloWojQoNAp4YMfyEC/ZTiEVXyc9r8gOT+eNOKTaa50Wwc M5RBsyM2KboqdQwXJCzOvh71DIVaKUP/IMZNNjCI9C3glR/NeDUUufmFLn9z/0NzGsJo wUgQ== X-Gm-Message-State: AOJu0YzZg/sf2UcSrlmPspIkhXI4bTRbqrZ9/rn2bzNYsEyw3Salq6Bf bgMExe9qHRl01gFGRXDydDcWXi0NybnAXH/KKbNMjLavhvRvPdEvtF1b5H2EnEVkerV7Uv2EMFk lb6cojTypEVLXFEBEuPephXavWr6xLh1nUMSOr9UoIUcbuTI45BWBDjWk/Iw= X-Received: by 2002:a05:6808:154:b0:3c7:3cc:4401 with SMTP id h20-20020a056808015400b003c703cc4401mr634489oie.7.1713381612637; Wed, 17 Apr 2024 12:20:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHhTaiBn5doD+O4CaAgn+3Vbj0N8uyJFAbFFjOM21y6QlF7KpockTSEvqZqte/M9A5avZJJWA== X-Received: by 2002:a05:6808:154:b0:3c7:3cc:4401 with SMTP id h20-20020a056808015400b003c703cc4401mr634472oie.7.1713381612380; Wed, 17 Apr 2024 12:20:12 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1001? ([2804:14d:8084:92c5::1001]) by smtp.gmail.com with ESMTPSA id z11-20020ac875cb000000b004366d3eef03sm7899740qtq.68.2024.04.17.12.20.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Apr 2024 12:20:11 -0700 (PDT) Message-ID: <3fea82e9-692a-4544-824e-33614a8eb8d5@redhat.com> Date: Wed, 17 Apr 2024 16:20:08 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] gdb: Change "list ." command's error when no debuginfo is available To: Eli Zaretskii Cc: gdb-patches@sourceware.org, simark@simark.ca References: <20240416200058.1300296-2-blarsen@redhat.com> <867cgwi4ji.fsf@gnu.org> From: Guinevere Larsen In-Reply-To: <867cgwi4ji.fsf@gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/17/24 08:58, Eli Zaretskii wrote: >> From: Guinevere Larsen >> Cc: Simon Marchi >> Date: Tue, 16 Apr 2024 17:00:59 -0300 >> >> From: Simon Marchi >> >> Currently, when a user tries to list the current location, there are 2 >> different error messages that can happen, either: >> >> (gdb) list . >> No symbol table is loaded. Use the "file" command. >> or >> (gdb) list . >> No debug information available to print source lines. >> >> The difference here is if gdb can find any symtabs at all or not, which >> is not something too important for end-users - and isn't informative at >> all. This commit changes it so that the error always says that there >> isn't debug information available, with these two variants: >> >> (gdb) list . >> No debug information available to print source lines at current PC (0x55555555511d). >> or >> (gdb) list . >> No debug information available to print source lines at default location. >> >> The difference now is if the inferior has started already, which is >> controlled by the user and may be useful. > How about this text instead: > > Insufficient debug info for showing source lines at current PC (0x55555555511d). > You mean this change only for the error when the inferior has already started, or to the prefix of both errors? Seeing as the errors are for the same root cause, I'd like to keep the prefix the same. -- Cheers, Guinevere Larsen She/Her/Hers