From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by sourceware.org (Postfix) with ESMTPS id B7AF33858D20 for ; Tue, 11 Apr 2023 13:15:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B7AF33858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f42.google.com with SMTP id q29so7366258wrc.3 for ; Tue, 11 Apr 2023 06:15:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681218899; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vEDgJ6GDQrQcsNBpENam0kJtN4ZvW5JIAqf6AhjVFek=; b=eCYMHWp2JME8AU/ldt4sA74Cai5MYjVTiUCiK59raGRnmcwdzc5Y7bAmrjaB7pZYv8 7OLlfRDsfmkKY/i3y+y5i4BhhxL8w1myuCmpJ2pxVm3ZLaZo9obZdBlxXc7M92MpVp1D tZrfzYoCSMitwIihSWpDiCjuLqpFLrlcc+dkVcGJONiF42YotruVjL/HMpS4CxzKsykE ZrtO09B8DqycXgd8yDkQ4PMfiqqD0sNeAi/wLVjlVXL6ZJ5ZDlZI64td/6p4oVA2HGlx ahiEJt57uXOkTAFDW4tg0/gcGpQZ2bhTDZ69vIXSdfeh43JClDWZmH1dNqHdQ3ySZn5L aBRg== X-Gm-Message-State: AAQBX9fGQEh+XFQZnmDFH2yG3HIwJBgOKxoHk/uRyJCDCo6VZLxpflJQ i6D+5XUmakz+V8Sts6lklz96G25ySFN7MA== X-Google-Smtp-Source: AKy350Z5Dt2e2YdNsUYCdNHC3iZ3HUESxhIqqAyeCsXWBroPm2aD/n7rk5jCgPeBmIdOBB4ZMIZAzg== X-Received: by 2002:a05:6000:ca:b0:2ef:bbe1:5f85 with SMTP id q10-20020a05600000ca00b002efbbe15f85mr2175920wrx.9.1681218899058; Tue, 11 Apr 2023 06:14:59 -0700 (PDT) Received: from ?IPv6:2001:8a0:f90a:9800::1fe? ([2001:8a0:f90a:9800::1fe]) by smtp.gmail.com with ESMTPSA id y8-20020adfee08000000b002c5a1bd5280sm14496498wrn.95.2023.04.11.06.14.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Apr 2023 06:14:58 -0700 (PDT) Subject: Re: [PATCH v5] [PR mi/29554] New PRINT-VALUES option '--scalar-values'. To: Gareth Rees , Andrew Burgess Cc: gdb-patches@sourceware.org References: <87fsftateu.fsf@redhat.com> <20221020174702.514681-1-grees@undo.io> <87bkl3h153.fsf@redhat.com> From: Pedro Alves Message-ID: <3ff442b8-7e8d-cadc-475b-ec2b20be3c3b@palves.net> Date: Tue, 11 Apr 2023 14:15:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-03-11 11:58 a.m., Gareth Rees via Gdb-patches wrote: > Andrew Burgess wrote: >> I'm happy to go with option #2, but I still think option #1 would be a >> better choice. It would change IDE behaviour in some cases, but I don't >> see why that change would break any IDEs, and I can't imagine how the >> current behaviour can be considered the right thing to do. > > I've posted a patch v6 implementing solution #1 (that is, updating the > --simple-values option). I've also taken account of all your review > comments, where they applied to solution #1. I rebased the patch so that > it now applies cleanly to the GDB master branch. > > I think it's worth trying to see if we can get agreement on solution #1 > as it is the simpler solution. But I'd also be happy to go with solution > #2 (that is, adding a new --scalar-values option) if the GDB maintainers > agree that is the better solution. > FWIW, I read the discussion from v1 to v5 (here), and I also think solution #1 is appropriate here.