From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26109 invoked by alias); 13 Feb 2020 20:29:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26101 invoked by uid 89); 13 Feb 2020 20:29:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=sk:regcach, HX-Languages-Length:513 X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Feb 2020 20:29:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581625771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lz6VL15Llq3b7d8VOo53F1o67MFKXBpnGbjYnB/L09w=; b=c+GAaCIZ+YLYAejcJqBSNzqTXzW0LFhnRvmLSR8dEOITXziCKHaAL9VcEJYjtIQh8OGf92 6dve/DKEz76UcByWMGj7KL0WONbKGgPetGE3dvSGhk8ujv7CkPoBIHFal9T+aZKqbdHrk6 ZB1mSSRlwHLbYPZEqnVXIpPR13Z4N1I= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-49-VZgHkz7hMOO4fEr9Gv6NgQ-1; Thu, 13 Feb 2020 15:29:30 -0500 Received: by mail-wr1-f72.google.com with SMTP id z15so2910357wrw.0 for ; Thu, 13 Feb 2020 12:29:30 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id z25sm4357288wmf.14.2020.02.13.12.29.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Feb 2020 12:29:28 -0800 (PST) Subject: Re: [PATCH 38/58] gdbserver: turn target ops 'read_pc' and 'write_pc' into methods To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <96b9fd062fd77a263e2a467461af04a3b720b6ef.1581410934.git.tankut.baris.aktemur@intel.com> From: Pedro Alves Message-ID: <40244955-5b5b-f7e5-5761-041f39df9ad1@redhat.com> Date: Thu, 13 Feb 2020 20:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <96b9fd062fd77a263e2a467461af04a3b720b6ef.1581410934.git.tankut.baris.aktemur@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00531.txt.bz2 On 2/11/20 9:01 AM, Tankut Baris Aktemur wrote: > + > +CORE_ADDR > +process_target::read_pc (regcache *regcache) > +{ > + gdb_assert_not_reached ("regcache_read_pc: Unable to find PC"); "regcache_read_pc" is stale. > +} > + > +void > +process_target::write_pc (regcache *regcache, CORE_ADDR pc) > +{ > + gdb_assert_not_reached ("regcache_write_pc: Unable to update PC"); Ditto "regcache_write_pc". > +} Thanks, Pedro Alves