From: Pedro Alves <palves@redhat.com>
To: Antoine Tremblay <antoine.tremblay@ericsson.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] Add emit_less_unsigned test in trace-condition.exp
Date: Fri, 27 May 2016 12:02:00 -0000 [thread overview]
Message-ID: <4099b62e-3ac6-e184-104b-5cf5bd1b3b4d@redhat.com> (raw)
In-Reply-To: <1463504594-4419-2-git-send-email-antoine.tremblay@ericsson.com>
On 05/17/2016 06:03 PM, Antoine Tremblay wrote:
> diff --git a/gdb/testsuite/gdb.trace/trace-condition.exp b/gdb/testsuite/gdb.trace/trace-condition.exp
> index fa031ba..f5b59b1 100644
> --- a/gdb/testsuite/gdb.trace/trace-condition.exp
> +++ b/gdb/testsuite/gdb.trace/trace-condition.exp
> @@ -151,6 +151,7 @@ foreach trace_command { "trace" "ftrace" } {
> test_tracepoints $trace_command "(0xaaaaaaaa ^ 0x55555555) == 0xffffffff" 10
> test_tracepoints $trace_command "~0xaaaaaaaa == 0x55555555" 10
> test_tracepoints $trace_command "21 < 42" 10
> + test_tracepoints $trace_command "21U < 42U" 10
Shouldn't we add:
test_tracepoints $trace_command "42U < 21U" 0
?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-05-27 12:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 17:03 [PATCH 1/4] Move trace conditions tests from ftrace.exp to trace-condition.exp Antoine Tremblay
2016-05-17 17:03 ` [PATCH 4/4] Add tests for 64bit values in trace-condition.exp Antoine Tremblay
2016-05-27 12:08 ` Pedro Alves
2016-05-27 12:36 ` Antoine Tremblay
2016-05-17 17:03 ` [PATCH 3/4] Add variable length tests for emit_ref " Antoine Tremblay
2016-05-27 12:05 ` Pedro Alves
2016-05-27 13:04 ` Antoine Tremblay
2016-05-17 17:03 ` [PATCH 2/4] Add emit_less_unsigned test " Antoine Tremblay
2016-05-27 12:02 ` Pedro Alves [this message]
2016-05-27 12:36 ` Antoine Tremblay
2016-05-27 12:00 ` [PATCH 1/4] Move trace conditions tests from ftrace.exp to trace-condition.exp Pedro Alves
2016-05-27 12:35 ` Antoine Tremblay
2016-05-27 12:48 ` Pedro Alves
2016-05-27 12:51 ` Antoine Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4099b62e-3ac6-e184-104b-5cf5bd1b3b4d@redhat.com \
--to=palves@redhat.com \
--cc=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).