From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 9AFC53858D34 for ; Fri, 3 Jul 2020 00:00:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9AFC53858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 33EFF1ED05; Thu, 2 Jul 2020 20:00:18 -0400 (EDT) Subject: Re: [PATCH 0/7] Add gdb support for Cygwin x86_64 core dumps To: Jon Turney , gdb-patches@sourceware.org References: <20200701213225.14144-1-jon.turney@dronecode.org.uk> From: Simon Marchi Message-ID: <40a6da6e-dbdc-e07d-449b-a05595ff94e0@simark.ca> Date: Thu, 2 Jul 2020 20:00:17 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200701213225.14144-1-jon.turney@dronecode.org.uk> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jul 2020 00:00:20 -0000 On 2020-07-01 5:32 p.m., Jon Turney wrote: > As far as I know, the only way to generate these "core dumps" is to use > Cygwin's 'dumper' tool, which requires some fixes on x86_64 [1]. > > [1] https://cygwin.com/pipermail/cygwin-patches/2020q3/010313.html > > Jon Turney (7): > Read tid from correct offset in win32pstatus NOTE_INFO_THREAD > Don't apply size constraint to all win32pstatus ELF notes. > Don't hardcode CONTEXT size for a NOTE_INFO_THREAD win32pstatus note > Add sniffer for Cygwin x86_64 core dumps > Add amd64_windows_gregset_reg_offset > Promote windows_core_xfer_shared_libraries and windows_core_pid_to_str > Add handling for 64-bit module addresses in Cygwin core dumps > > bfd/ChangeLog | 20 ++++++++ > bfd/elf.c | 25 +++++---- > gdb/ChangeLog | 23 +++++++++ > gdb/amd64-windows-tdep.c | 100 ++++++++++++++++++++++++++++++++++++ > gdb/i386-windows-tdep.c | 100 +----------------------------------- > gdb/windows-tdep.c | 108 +++++++++++++++++++++++++++++++++++++++ > gdb/windows-tdep.h | 8 +++ > 7 files changed, 276 insertions(+), 108 deletions(-) > > -- > 2.27.0 > I've sent a few comments, but in general the GDB bits look fine to me. But as Tom said, the bfd bits need to be approved by the binutils folks. Simon