From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 52A4A385840C for ; Thu, 1 Dec 2022 01:34:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 52A4A385840C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=us.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=us.ibm.com Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B11Hg2L028616 for ; Thu, 1 Dec 2022 01:33:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=Mg2qYp3QFIWbR4zXzYRY3BjN3FrUQGteMi8yOLm/gjw=; b=MNNE+rv3WPvBI0TKBEvZ4I0fxMDOlGOFjDdQ84A3y2XeebFpLPFo1l7D6C/yXx+myq29 HDvFFsXGKJbAmmvZHu1KaH9JNuazzUgry3RKedGVPqnAHWQaXIU3UDeGiSpkohuQNKsk 13x2Xr8J9sSE0gRlmrZ3s4IXymsOMJZU1wkZtMe50bm5pywfHN/9XNArXYaghqmW1ukH X8uvavIW2RYO2Uudp1ZENGpqN3PTpDvTRZy7S43QQuoR1J3ufrjw3HDcntudSuMdOtE5 7AaSIkw2cm1H0yaTG9yBIOJ4pqFs0Z5JifyNwi5c2L7JiD9PvxAQB4RVvf2E09Quvdpy bQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3m6jft89j3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 01 Dec 2022 01:33:59 +0000 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2B11UK0M005838 for ; Thu, 1 Dec 2022 01:33:58 GMT Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3m6jft89hx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Dec 2022 01:33:58 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2B11K2lc032343; Thu, 1 Dec 2022 01:33:57 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma03dal.us.ibm.com with ESMTP id 3m3ae9yg1m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Dec 2022 01:33:57 +0000 Received: from smtpav05.dal12v.mail.ibm.com ([9.208.128.132]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2B11Y1U013566552 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 1 Dec 2022 01:34:02 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 63E6758056; Thu, 1 Dec 2022 01:33:56 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 085F458052; Thu, 1 Dec 2022 01:33:56 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.163.52.7]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 1 Dec 2022 01:33:55 +0000 (GMT) Message-ID: <40ae618990682da7b6e790ac7d69d899d2da7ec8.camel@us.ibm.com> Subject: Re: [PATCH V4] PowerPC, fix gdb.reverse/finish-reverse-bkpt.exp and gdb.reverse/next-reverse-bkpt-over-sr.exp From: Carl Love To: Ulrich Weigand , "gdb-patches@sourceware.org" , "blarsen@redhat.com" Cc: "will_schmidt@vnet.ibm.com" Date: Wed, 30 Nov 2022 17:33:55 -0800 In-Reply-To: <930d9b2f37859733ce04996a1e8cd699bbb59c8a.camel@de.ibm.com> References: <69b2451b-1baf-8bd4-25dd-a1b46963981f@redhat.com> <75b124722aa20466d5044fa115b679b61ff83010.camel@de.ibm.com> <526c2ea0e35214ef46c248ae88bcd1346fa8e574.camel@us.ibm.com> <682e79ba-0e4b-3209-4fa2-e94ef8e6c978@redhat.com> <015a43bb0dfedfd85f864a2abb9ae005d95103cb.camel@us.ibm.com> <930d9b2f37859733ce04996a1e8cd699bbb59c8a.camel@de.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: hym0_zpnDhZ6T2NxZjZCL3k-AAJ4fBPV X-Proofpoint-ORIG-GUID: htKI15-o7Y1WwikorQAXM_ccLhnMVsdY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-30_04,2022-11-30_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 phishscore=0 suspectscore=0 bulkscore=0 spamscore=0 adultscore=0 mlxlogscore=337 mlxscore=0 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212010007 X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 2022-11-30 at 11:30 +0000, Ulrich Weigand wrote: > Carl Love wrote: > > > +# Move to the function pointer call to void_func so we will use > > the GEP > > +# to enter void_func and break. > > +set breakloc [gdb_get_line_number "FUNCTION PTR" "$srcfile"] > > +gdb_test "break $breakloc" \ > > + "Breakpoint $decimal at .*$srcfile, line $breakloc\." \ > > + "set breakpoint on funp" > > +gdb_continue_to_breakpoint "funp call" ".*$srcfile:$breakloc.*" > > Do we still need this? In the new source file, there is only > a single call to void_func (via function pointer), so the > tbreak below should already stop there: Yes, we can just use the tbreak since we have removed all the stuff from the source file used by the other tests. Removed the break on FUNCTION_PTR. The label in the source file is also no longer needed, removed. > > > set breakloc [gdb_get_line_number "VOID FUNC" "$srcfile"] > > gdb_test "tbreak void_func" \ > > "Temporary breakpoint $decimal at .*$srcfile, line $breakloc\." > > \ > > +int > > +callee() { /* ENTER CALLEE */ > > + return myglob++; /* ARRIVED IN CALLEE */ > > +} /* RETURN FROM CALLEE */ > > These comment markers seem to be nowhere used. Yes, they are left overs in the original source file and are now not needed. Removed. > > + exit (0); /* end of main */ > > Comment marker should be all-upper-case like the others. Fixed. > > > +# Move to the function pointer call to the callee call after the > > function > > +# pointer call to callee to begin the test. The function pointer > > call to > > +# callee will use the Global Entry Point on Power. > > This comment seems confusing. Fixed the comment. Will repost the patch. Thanks for the review. Carl