public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Lancelot SIX <Lancelot.Six@amd.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/testsuite/gdb.rocm: Fix incorrect use of continue N in multi-inferior-gpu.exp
Date: Tue, 17 Oct 2023 12:21:25 +0100	[thread overview]
Message-ID: <40b21f94-9834-4366-956f-6c6b146899f9@amd.com> (raw)
In-Reply-To: <20231017111629.307261-1-lancelot.six@amd.com>

Hi,


> diff --git a/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp b/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp
> index 18b4172ff09..958b70e6df1 100644
> --- a/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp
> +++ b/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp
> @@ -68,8 +68,10 @@ proc do_test {} {
>   	foreach thread $stopped_gpu_threads {
>   	    set infnumber [lindex [split $thread .] 0]
>   	    gdb_test "thread $thread" "Switching to thread.*"
> -	    gdb_test_multiple "continue $thread" "" {
> -		-re "\\\[Inferior $infnumber \[^\n\r\]* exited normally\\]\r\n$::gdb_prompt " {
> +	    # Continue this thread, and consime the prompt
                                             ^
There is a typo here.  I have fixed it locally.

Best,
Lancelot.

> +	    gdb_test "continue&" "" "continue GPU thread in $infnumber"
> +	    gdb_test_multiple "" "wait for inferior $infnumber" {
> +		-re "\\\[Inferior $infnumber \[^\n\r\]* exited normally\\\]\r\n" {
>   		    pass $gdb_test_name
>   		}
>   	    }

  reply	other threads:[~2023-10-17 11:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-17 11:16 Lancelot Six
2023-10-17 11:21 ` Lancelot SIX [this message]
2023-10-17 14:25 ` Simon Marchi
2023-10-17 14:41   ` Lancelot SIX
2023-10-17 14:48     ` Simon Marchi
2023-10-18  8:32       ` Lancelot SIX
2023-10-18 10:24 ` [PATCH v2] " Lancelot Six
2023-10-18 20:26   ` Simon Marchi
2023-10-18 20:32     ` Lancelot SIX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40b21f94-9834-4366-956f-6c6b146899f9@amd.com \
    --to=lancelot.six@amd.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).