RE: [Patch, microblaze]: Port of Linux gdbserver

[Ajit Kumar Agarwal <ajit.kumar.agarwal@xilinx.com>]

-----Original Message-----
From: Joel Brobecker [mailto:brobecker@adacore.com] 
Sent: Wednesday, September 10, 2014 8:13 PM
To: Ajit Kumar Agarwal
Cc: Michael Eager; gdb-patches@sourceware.org; Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala
Subject: Re: [Patch, microblaze]: Port of Linux gdbserver

[with my patch-champion hat]

I can't review the gdbserver Changes, but I can look at the rest.

>     ChangeLog:
>     2014-10-09  Ajit Agarwal  <ajitkum@xilinx.com>
> 
>         * configure.host (microblaze): New.
>         (microblaze*-*-linux*): New.
>         * configure.tgt (build_gdbserver): New Definition.
>         * gdbserver/Makefile.in (microblaze-linux.c): New target.
>         * gdbserver/configure.srv (microblaze*-*-linux*): New target.
>         * gdbserver/linux-microblaze-low.c: New file.

Sorry Ajit. I should have seen this in the previous iteration, but there are a couple more nits in the ChangeLog entry that you'll need to fix.

>>First, gdb and gdb/gdbserver have distinct ChangeLog files, so you'll need to have 2 ChangeLog entries if you touch both areas at the same time.  This >>means that the filenames in gdbserver should not be prefixed with "gdbserver/" in your ChangeLog entry.

>>Also, change "ChangeLog:" to "gdb/ChangeLog:" and "gdbserver/ChangeLog:".

>>Please exclude the configure.host change. This looks unrelated.

I will incorporate this.
> diff --git a/gdb/configure.tgt b/gdb/configure.tgt index 
> 01311b2..e4894da 100644
> --- a/gdb/configure.tgt
> +++ b/gdb/configure.tgt
> @@ -343,6 +343,7 @@ microblaze*-linux-*|microblaze*-*-linux*)
>  	gdb_target_obs="microblaze-tdep.o microblaze-linux-tdep.o microblaze-rom.o \
>  			monitor.o dsrec.o solib-svr4.o symfile-mem.o linux-tdep.o"
>  	gdb_sim=../sim/microblaze/libsim.a
> +        build_gdbserver=yes
>  	;;
>  microblaze*-*-*)
>  	# Target: Xilinx MicroBlaze running standalone diff --git 
> a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in index 
> 1447e61..b2a01f5 100644
> --- a/gdb/gdbserver/Makefile.in
> +++ b/gdb/gdbserver/Makefile.in
> @@ -153,6 +153,7 @@ SFILES=	$(srcdir)/gdbreplay.c $(srcdir)/inferiors.c $(srcdir)/dll.c \
>  	$(srcdir)/linux-ia64-low.c $(srcdir)/linux-low.c \
>  	$(srcdir)/linux-m32r-low.c \
>  	$(srcdir)/linux-m68k-low.c $(srcdir)/linux-mips-low.c \
> +        $(srcdir)/linux-microblaze-low.c \
>  	$(srcdir)/linux-nios2-low.c \
>  	$(srcdir)/linux-ppc-low.c \
>  	$(srcdir)/linux-s390-low.c \
> @@ -364,6 +365,7 @@ clean:
>  	rm -f amd64-mpx.c amd64-mpx-linux.c
>  	rm -f amd64-avx512.c amd64-avx512-linux.c
>  	rm -f i386-mmx.c i386-mmx-linux.c
> +        rm -f microblaze-linux.c
>  	rm -f x32.c x32-linux.c
>  	rm -f x32-avx.c x32-avx-linux.c
>  	rm -f x32-avx512.c x32-avx512-linux.c

>>There are indentation errors in the two hunks above. Use tabs.

I will do this.

> @@ -634,6 +636,8 @@ mips64-linux.c : $(srcdir)/../regformats/mips64-linux.dat $(regdat_sh)
>  	$(SHELL) $(regdat_sh) $(srcdir)/../regformats/mips64-linux.dat 
> mips64-linux.c  mips64-dsp-linux.c : $(srcdir)/../regformats/mips64-dsp-linux.dat $(regdat_sh)
>  	$(SHELL) $(regdat_sh) $(srcdir)/../regformats/mips64-dsp-linux.dat 
> mips64-dsp-linux.c
> +microblaze-linux.c : $(srcdir)/../regformats/microblaze-with-stack-protect.dat $(regdat_sh)
> +        $(SHELL) $(regdat_sh) 
> +$(srcdir)/../regformats/microblaze-with-stack-protect.dat  
> +microblaze-linux.c
>  nios2-linux.c :	$(srcdir)/../regformats/nios2-linux.dat $(regdat_sh)
>  	$(SHELL) $(regdat_sh) $(srcdir)/../regformats/nios2-linux.dat 
> nios2-linux.c  powerpc-32.c : 
> $(srcdir)/../regformats/rs6000/powerpc-32.dat $(regdat_sh) diff --git 
> a/gdb/gdbserver/configure.srv b/gdb/gdbserver/configure.srv index 
> 679fc9f..16e44ee 100644
> --- a/gdb/gdbserver/configure.srv
> +++ b/gdb/gdbserver/configure.srv
> @@ -194,6 +194,12 @@ case "${target}" in
>  			srv_linux_usrregs=yes
>  			srv_linux_thread_db=yes
>  			;;
> +  microblaze*-*-linux*) srv_regobj=microblaze-linux.o
> +                        srv_tgtobj="$srv_linux_obj linux-microblaze-low.o"
> +                        srv_linux_usrregs=yes
> +                        srv_linux_regsets=yes
> +                        srv_linux_thread_db=yes
> +                        ;;
>    nios2*-*-linux*)	srv_regobj="nios2-linux.o"
>  			srv_tgtobj="$srv_linux_obj linux-nios2-low.o"
>  			srv_xmlfiles="nios2-linux.xml"
> diff --git a/gdb/gdbserver/linux-microblaze-low.c 
> b/gdb/gdbserver/linux-microblaze-low.c
> new file mode 100644
> index 0000000..b86b4f5
> --- /dev/null
> +++ b/gdb/gdbserver/linux-microblaze-low.c

>>It looks to me like you have many many trailing spaces in the file you are submitting. Please strip them.

>>Some lines are too long, also.

Joel: I have splitted the lines where it exceeds 80 Cols. I have removed trailing spaces as much as I can. Could 
You please give  one example of the trailing space which I have not removed.

Thanks & Regards
Ajit
--
Joel